* [PATCH] arm64: dts: ls1046a: Fast read m25p60
2019-05-16 11:47 [PATCH] arm64: dts: ls1012a: Add QSPI support for ls1012a Kuldeep Singh
@ 2019-05-16 11:47 ` Kuldeep Singh
2019-05-23 8:47 ` Shawn Guo
2019-05-16 11:47 ` [PATCH] arm64: dts: ls1088a: Add QSPI support Kuldeep Singh
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Kuldeep Singh @ 2019-05-16 11:47 UTC (permalink / raw)
To: shawnguo@kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mtd@lists.infradead.org
Cc: Kuldeep Singh, broonie@kernel.org, Ashish Kumar,
bbrezillon@kernel.org
QSPI support is added for kernel version greater than 5.0 and supports
quad mode defined by
TX-WIDTH = <4>, RX-WIDTH = <4>
RDB/QDS has two 64MB flash from SPANSION(s25fs512s)
Signed-off-by: Ashish Kumar <ashish.kumar@nxp.com>
Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com>
---
arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts | 3 ++-
arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 6 ++++--
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
index eec62c63dafe..43a5ef6357d5 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
@@ -166,9 +166,10 @@
status = "okay";
qflash0: flash@0 {
- compatible = "spansion,m25p80";
+ compatible = "spansion,m25p80", "jedec,spi-nor";
#address-cells = <1>;
#size-cells = <1>;
+ m25p,fast-read;
spi-max-frequency = <20000000>;
spi-rx-bus-width = <4>;
spi-tx-bus-width = <4>;
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
index 6a6514d0e5a9..85105a20fc04 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
@@ -102,9 +102,10 @@
status = "okay";
qflash0: flash@0 {
- compatible = "spansion,m25p80";
+ compatible = "spansion,m25p80", "jedec,spi-nor";
#address-cells = <1>;
#size-cells = <1>;
+ m25p,fast-read;
spi-max-frequency = <20000000>;
spi-rx-bus-width = <4>;
spi-tx-bus-width = <4>;
@@ -112,9 +113,10 @@
};
qflash1: flash@1 {
- compatible = "spansion,m25p80";
+ compatible = "spansion,m25p80", "jedec,spi-nor";
#address-cells = <1>;
#size-cells = <1>;
+ m25p,fast-read;
spi-max-frequency = <20000000>;
spi-rx-bus-width = <4>;
spi-tx-bus-width = <4>;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] arm64: dts: ls1046a: Fast read m25p60
2019-05-16 11:47 ` [PATCH] arm64: dts: ls1046a: Fast read m25p60 Kuldeep Singh
@ 2019-05-23 8:47 ` Shawn Guo
0 siblings, 0 replies; 9+ messages in thread
From: Shawn Guo @ 2019-05-23 8:47 UTC (permalink / raw)
To: Kuldeep Singh
Cc: devicetree@vger.kernel.org, bbrezillon@kernel.org, Ashish Kumar,
broonie@kernel.org, linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
On Thu, May 16, 2019 at 11:47:06AM +0000, Kuldeep Singh wrote:
> QSPI support is added for kernel version greater than 5.0 and supports
> quad mode defined by
> TX-WIDTH = <4>, RX-WIDTH = <4>
>
> RDB/QDS has two 64MB flash from SPANSION(s25fs512s)
>
> Signed-off-by: Ashish Kumar <ashish.kumar@nxp.com>
> Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com>
Please do not send patch in message encoding with base64. I do not
apply it.
Shawn
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts | 3 ++-
> arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 6 ++++--
> 2 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> index eec62c63dafe..43a5ef6357d5 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> @@ -166,9 +166,10 @@
> status = "okay";
>
> qflash0: flash@0 {
> - compatible = "spansion,m25p80";
> + compatible = "spansion,m25p80", "jedec,spi-nor";
> #address-cells = <1>;
> #size-cells = <1>;
> + m25p,fast-read;
> spi-max-frequency = <20000000>;
> spi-rx-bus-width = <4>;
> spi-tx-bus-width = <4>;
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> index 6a6514d0e5a9..85105a20fc04 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> @@ -102,9 +102,10 @@
> status = "okay";
>
> qflash0: flash@0 {
> - compatible = "spansion,m25p80";
> + compatible = "spansion,m25p80", "jedec,spi-nor";
> #address-cells = <1>;
> #size-cells = <1>;
> + m25p,fast-read;
> spi-max-frequency = <20000000>;
> spi-rx-bus-width = <4>;
> spi-tx-bus-width = <4>;
> @@ -112,9 +113,10 @@
> };
>
> qflash1: flash@1 {
> - compatible = "spansion,m25p80";
> + compatible = "spansion,m25p80", "jedec,spi-nor";
> #address-cells = <1>;
> #size-cells = <1>;
> + m25p,fast-read;
> spi-max-frequency = <20000000>;
> spi-rx-bus-width = <4>;
> spi-tx-bus-width = <4>;
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] arm64: dts: ls1088a: Add QSPI support
2019-05-16 11:47 [PATCH] arm64: dts: ls1012a: Add QSPI support for ls1012a Kuldeep Singh
2019-05-16 11:47 ` [PATCH] arm64: dts: ls1046a: Fast read m25p60 Kuldeep Singh
@ 2019-05-16 11:47 ` Kuldeep Singh
2019-05-23 8:48 ` Shawn Guo
2019-05-16 11:47 ` [PATCH] arm64: dts: ls208x: Remove non-compatible driver device from qspi node Kuldeep Singh
2019-05-23 8:43 ` [PATCH] arm64: dts: ls1012a: Add QSPI support for ls1012a Shawn Guo
3 siblings, 1 reply; 9+ messages in thread
From: Kuldeep Singh @ 2019-05-16 11:47 UTC (permalink / raw)
To: shawnguo@kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mtd@lists.infradead.org
Cc: Kuldeep Singh, broonie@kernel.org, Ashish Kumar,
bbrezillon@kernel.org
QSPI support is added for kernel version greater than 5.0 and supports
quad mode defined by
TX-WIDTH = <4>, RX-WIDTH = <4>
RDB/QDS has two 64MB flash from SPANSION(s25fs512s)
Signed-off-by: Ashish Kumar <ashish.kumar@nxp.com>
Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com>
---
Dependency on https://patchwork.ozlabs.org/patch/1100471/
Dependency on https://patchwork.ozlabs.org/patch/1100472/
.../boot/dts/freescale/fsl-ls1088a-qds.dts | 26 +++++++++++++++++++
.../boot/dts/freescale/fsl-ls1088a-rdb.dts | 26 +++++++++++++++++++
.../arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 13 ++++++++++
3 files changed, 65 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts
index 6f48d21b97c0..f01f7fca9df7 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts
@@ -98,6 +98,32 @@
};
};
+&qspi {
+ status = "okay";
+
+ qflash0: flash@0 {
+ compatible = "spansion,m25p80", "jedec,spi-nor";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ m25p,fast-read;
+ spi-max-frequency = <20000000>;
+ spi-rx-bus-width = <4>;
+ spi-tx-bus-width = <4>;
+ reg = <0>;
+ };
+
+ qflash1: flash@1 {
+ compatible = "spansion,m25p80", "jedec,spi-nor";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ m25p,fast-read;
+ spi-max-frequency = <20000000>;
+ spi-rx-bus-width = <4>;
+ spi-tx-bus-width = <4>;
+ reg = <1>;
+ };
+};
+
&duart0 {
status = "okay";
};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
index 8e925df6c01c..bdec7e996dbe 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
@@ -74,6 +74,32 @@
};
};
+&qspi {
+ status = "okay";
+
+ qflash0: flash@0 {
+ compatible = "spansion,m25p80", "jedec,spi-nor";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ m25p,fast-read;
+ spi-max-frequency = <20000000>;
+ spi-rx-bus-width = <4>;
+ spi-tx-bus-width = <4>;
+ reg = <0>;
+ };
+
+ qflash1: flash@1 {
+ compatible = "spansion,m25p80", "jedec,spi-nor";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ m25p,fast-read;
+ spi-max-frequency = <20000000>;
+ spi-rx-bus-width = <4>;
+ spi-tx-bus-width = <4>;
+ reg = <1>;
+ };
+};
+
&duart0 {
status = "okay";
};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
index 661137ffa319..96424fd9cd2e 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
@@ -318,6 +318,19 @@
status = "disabled";
};
+ qspi: spi@20c0000 {
+ status = "disabled";
+ compatible = "fsl,ls2080a-qspi", "fsl,ls1088a-qspi";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x0 0x20c0000 0x0 0x10000>,
+ <0x0 0x20000000 0x0 0x10000000>;
+ reg-names = "QuadSPI", "QuadSPI-memory";
+ interrupts = <0 25 0x4>; /* Level high type */
+ clocks = <&clockgen 4 3>, <&clockgen 4 3>;
+ clock-names = "qspi_en", "qspi";
+ };
+
i2c0: i2c@2000000 {
compatible = "fsl,vf610-i2c";
#address-cells = <1>;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] arm64: dts: ls1088a: Add QSPI support
2019-05-16 11:47 ` [PATCH] arm64: dts: ls1088a: Add QSPI support Kuldeep Singh
@ 2019-05-23 8:48 ` Shawn Guo
0 siblings, 0 replies; 9+ messages in thread
From: Shawn Guo @ 2019-05-23 8:48 UTC (permalink / raw)
To: Kuldeep Singh
Cc: devicetree@vger.kernel.org, bbrezillon@kernel.org, Ashish Kumar,
broonie@kernel.org, linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
On Thu, May 16, 2019 at 11:47:07AM +0000, Kuldeep Singh wrote:
> QSPI support is added for kernel version greater than 5.0 and supports
> quad mode defined by
> TX-WIDTH = <4>, RX-WIDTH = <4>
>
> RDB/QDS has two 64MB flash from SPANSION(s25fs512s)
>
> Signed-off-by: Ashish Kumar <ashish.kumar@nxp.com>
> Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com>
> ---
> Dependency on https://patchwork.ozlabs.org/patch/1100471/
> Dependency on https://patchwork.ozlabs.org/patch/1100472/
Please send dts changes only after dependencies get accepted.
Shawn
>
> .../boot/dts/freescale/fsl-ls1088a-qds.dts | 26 +++++++++++++++++++
> .../boot/dts/freescale/fsl-ls1088a-rdb.dts | 26 +++++++++++++++++++
> .../arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 13 ++++++++++
> 3 files changed, 65 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts
> index 6f48d21b97c0..f01f7fca9df7 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts
> @@ -98,6 +98,32 @@
> };
> };
>
> +&qspi {
> + status = "okay";
> +
> + qflash0: flash@0 {
> + compatible = "spansion,m25p80", "jedec,spi-nor";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + m25p,fast-read;
> + spi-max-frequency = <20000000>;
> + spi-rx-bus-width = <4>;
> + spi-tx-bus-width = <4>;
> + reg = <0>;
> + };
> +
> + qflash1: flash@1 {
> + compatible = "spansion,m25p80", "jedec,spi-nor";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + m25p,fast-read;
> + spi-max-frequency = <20000000>;
> + spi-rx-bus-width = <4>;
> + spi-tx-bus-width = <4>;
> + reg = <1>;
> + };
> +};
> +
> &duart0 {
> status = "okay";
> };
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> index 8e925df6c01c..bdec7e996dbe 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> @@ -74,6 +74,32 @@
> };
> };
>
> +&qspi {
> + status = "okay";
> +
> + qflash0: flash@0 {
> + compatible = "spansion,m25p80", "jedec,spi-nor";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + m25p,fast-read;
> + spi-max-frequency = <20000000>;
> + spi-rx-bus-width = <4>;
> + spi-tx-bus-width = <4>;
> + reg = <0>;
> + };
> +
> + qflash1: flash@1 {
> + compatible = "spansion,m25p80", "jedec,spi-nor";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + m25p,fast-read;
> + spi-max-frequency = <20000000>;
> + spi-rx-bus-width = <4>;
> + spi-tx-bus-width = <4>;
> + reg = <1>;
> + };
> +};
> +
> &duart0 {
> status = "okay";
> };
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index 661137ffa319..96424fd9cd2e 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -318,6 +318,19 @@
> status = "disabled";
> };
>
> + qspi: spi@20c0000 {
> + status = "disabled";
> + compatible = "fsl,ls2080a-qspi", "fsl,ls1088a-qspi";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x0 0x20c0000 0x0 0x10000>,
> + <0x0 0x20000000 0x0 0x10000000>;
> + reg-names = "QuadSPI", "QuadSPI-memory";
> + interrupts = <0 25 0x4>; /* Level high type */
> + clocks = <&clockgen 4 3>, <&clockgen 4 3>;
> + clock-names = "qspi_en", "qspi";
> + };
> +
> i2c0: i2c@2000000 {
> compatible = "fsl,vf610-i2c";
> #address-cells = <1>;
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] arm64: dts: ls208x: Remove non-compatible driver device from qspi node
2019-05-16 11:47 [PATCH] arm64: dts: ls1012a: Add QSPI support for ls1012a Kuldeep Singh
2019-05-16 11:47 ` [PATCH] arm64: dts: ls1046a: Fast read m25p60 Kuldeep Singh
2019-05-16 11:47 ` [PATCH] arm64: dts: ls1088a: Add QSPI support Kuldeep Singh
@ 2019-05-16 11:47 ` Kuldeep Singh
2019-05-23 8:43 ` [PATCH] arm64: dts: ls1012a: Add QSPI support for ls1012a Shawn Guo
3 siblings, 0 replies; 9+ messages in thread
From: Kuldeep Singh @ 2019-05-16 11:47 UTC (permalink / raw)
To: shawnguo@kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mtd@lists.infradead.org
Cc: Kuldeep Singh, broonie@kernel.org, Ashish Kumar,
bbrezillon@kernel.org
Since device properties are different, so remove fsl, ls1021a-qspi
Signed-off-by: Ashish Kumar <ashish.kumar@nxp.com>
Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com>
---
Dependency on https://patchwork.ozlabs.org/patch/1100471/
Dependency on https://patchwork.ozlabs.org/patch/1100472/
arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
index d7e78dcd153d..8e5ba513b24f 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
@@ -606,7 +606,7 @@
qspi: spi@20c0000 {
status = "disabled";
- compatible = "fsl,ls2080a-qspi", "fsl,ls1021a-qspi";
+ compatible = "fsl,ls2080a-qspi";
#address-cells = <1>;
#size-cells = <0>;
reg = <0x0 0x20c0000 0x0 0x10000>,
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] arm64: dts: ls1012a: Add QSPI support for ls1012a
2019-05-16 11:47 [PATCH] arm64: dts: ls1012a: Add QSPI support for ls1012a Kuldeep Singh
` (2 preceding siblings ...)
2019-05-16 11:47 ` [PATCH] arm64: dts: ls208x: Remove non-compatible driver device from qspi node Kuldeep Singh
@ 2019-05-23 8:43 ` Shawn Guo
2019-05-23 9:01 ` Schrempf Frieder
3 siblings, 1 reply; 9+ messages in thread
From: Shawn Guo @ 2019-05-23 8:43 UTC (permalink / raw)
To: Kuldeep Singh
Cc: devicetree@vger.kernel.org, bbrezillon@kernel.org, Ashish Kumar,
broonie@kernel.org, linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
On Thu, May 16, 2019 at 11:47:04AM +0000, Kuldeep Singh wrote:
> QSPI support is added for kernel version greater than 5.0 and supports
> quad mode defined by
> TX-WIDTH = <4>, RX-WIDTH = <4>
>
> RDB/QDS has one 64MB flash from SPANSION(s25fs512s)
>
> Signed-off-by: Ashish Kumar <ashish.kumar@nxp.com>
> Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com>
> ---
> Dependency on https://patchwork.ozlabs.org/patch/1100471/
> Dependency on https://patchwork.ozlabs.org/patch/1100472/
>
> .../arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts | 15 +++++++++++++++
> .../arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts | 15 +++++++++++++++
> arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts | 15 +++++++++++++++
> arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts | 15 +++++++++++++++
> arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 15 +++++++++++++++
> 5 files changed, 75 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
> index f90c040fd5e8..8826278b37bf 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
> @@ -61,6 +61,21 @@
> status = "okay";
> };
>
> +&qspi {
Please sort these labeling nodes alphabetically. That said, &qspi
should go after &i2c0.
> + status = "okay";
> +
> + qflash0: flash@0 {
> + compatible = "spansion,m25p80", "jedec,spi-nor";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + m25p,fast-read;
> + spi-max-frequency = <20000000>;
> + spi-rx-bus-width = <4>;
> + spi-tx-bus-width = <4>;
> + reg = <0>;
> + };
> +};
> +
> &i2c0 {
> status = "okay";
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts
> index 8749634c55ee..0246e8c97628 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts
> @@ -20,6 +20,21 @@
> status = "okay";
> };
>
> +&qspi {
> + status = "okay";
> +
> + qflash0: flash@0 {
> + compatible = "spansion,m25p80", "jedec,spi-nor";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + m25p,fast-read;
> + spi-max-frequency = <20000000>;
> + spi-rx-bus-width = <4>;
> + spi-tx-bus-width = <4>;
> + reg = <0>;
> + };
> +};
> +
> &i2c0 {
> status = "okay";
> };
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
> index 2fb1cb1f7d8f..c304fa20c1c9 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
> @@ -90,6 +90,21 @@
> };
> };
>
> +&qspi {
> + status = "okay";
> +
> + qflash0: flash@0 {
> + compatible = "spansion,m25p80", "jedec,spi-nor";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + m25p,fast-read;
> + spi-max-frequency = <20000000>;
> + spi-rx-bus-width = <4>;
> + spi-tx-bus-width = <4>;
> + reg = <0>;
> + };
> +};
> +
> &duart0 {
> status = "okay";
> };
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> index 5edb1e137a52..6017e9cfe40a 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> @@ -38,3 +38,18 @@
> &sata {
> status = "okay";
> };
> +
> +&qspi {
> + status = "okay";
> +
> + qflash0: flash@0 {
> + compatible = "spansion,m25p80", "jedec,spi-nor";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + m25p,fast-read;
> + spi-max-frequency = <20000000>;
> + spi-rx-bus-width = <4>;
> + spi-tx-bus-width = <4>;
> + reg = <0>;
> + };
> +};
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> index ec6257a5b251..268268c6a149 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> @@ -350,6 +350,21 @@
> status = "disabled";
> };
>
> + qspi: spi@1550000 {
Please sort node with unit-address in that address. That said, it
should go before esdhc@1560000.
> + compatible = "fsl,ls1021a-qspi", "fsl,ls1012a-qspi";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x0 0x1550000 0x0 0x10000>,
> + <0x0 0x40000000 0x0 0x10000000>;
> + reg-names = "QuadSPI", "QuadSPI-memory";
> + interrupts = <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>;
> + clock-names = "qspi_en", "qspi";
> + clocks = <&clockgen 4 1>, <&clockgen 4 1>;
> + big-endian;
> + fsl,qspi-has-second-chip;
Undocumented property?
Shawn
> + status = "disabled";
> + };
> +
> duart0: serial@21c0500 {
> compatible = "fsl,ns16550", "ns16550a";
> reg = <0x00 0x21c0500 0x0 0x100>;
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] arm64: dts: ls1012a: Add QSPI support for ls1012a
2019-05-23 8:43 ` [PATCH] arm64: dts: ls1012a: Add QSPI support for ls1012a Shawn Guo
@ 2019-05-23 9:01 ` Schrempf Frieder
2019-05-23 9:19 ` [EXT] " Kuldeep Singh
0 siblings, 1 reply; 9+ messages in thread
From: Schrempf Frieder @ 2019-05-23 9:01 UTC (permalink / raw)
To: Shawn Guo, Kuldeep Singh
Cc: devicetree@vger.kernel.org, bbrezillon@kernel.org, Ashish Kumar,
broonie@kernel.org, linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
On 23.05.19 10:43, Shawn Guo wrote:
> On Thu, May 16, 2019 at 11:47:04AM +0000, Kuldeep Singh wrote:
>> QSPI support is added for kernel version greater than 5.0 and supports
>> quad mode defined by
>> TX-WIDTH = <4>, RX-WIDTH = <4>
>>
>> RDB/QDS has one 64MB flash from SPANSION(s25fs512s)
>>
>> Signed-off-by: Ashish Kumar <ashish.kumar@nxp.com>
>> Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com>
>> ---
>> Dependency on https://patchwork.ozlabs.org/patch/1100471/
>> Dependency on https://patchwork.ozlabs.org/patch/1100472/
>>
>> .../arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts | 15 +++++++++++++++
>> .../arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts | 15 +++++++++++++++
>> arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts | 15 +++++++++++++++
>> arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts | 15 +++++++++++++++
>> arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 15 +++++++++++++++
>> 5 files changed, 75 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
>> index f90c040fd5e8..8826278b37bf 100644
>> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
>> @@ -61,6 +61,21 @@
>> status = "okay";
>> };
>>
>> +&qspi {
>
> Please sort these labeling nodes alphabetically. That said, &qspi
> should go after &i2c0.
>
>> + status = "okay";
>> +
>> + qflash0: flash@0 {
>> + compatible = "spansion,m25p80", "jedec,spi-nor";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + m25p,fast-read;
>> + spi-max-frequency = <20000000>;
>> + spi-rx-bus-width = <4>;
>> + spi-tx-bus-width = <4>;
>> + reg = <0>;
>> + };
>> +};
>> +
>> &i2c0 {
>> status = "okay";
>>
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts
>> index 8749634c55ee..0246e8c97628 100644
>> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts
>> @@ -20,6 +20,21 @@
>> status = "okay";
>> };
>>
>> +&qspi {
>> + status = "okay";
>> +
>> + qflash0: flash@0 {
>> + compatible = "spansion,m25p80", "jedec,spi-nor";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + m25p,fast-read;
>> + spi-max-frequency = <20000000>;
>> + spi-rx-bus-width = <4>;
>> + spi-tx-bus-width = <4>;
>> + reg = <0>;
>> + };
>> +};
>> +
>> &i2c0 {
>> status = "okay";
>> };
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
>> index 2fb1cb1f7d8f..c304fa20c1c9 100644
>> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
>> @@ -90,6 +90,21 @@
>> };
>> };
>>
>> +&qspi {
>> + status = "okay";
>> +
>> + qflash0: flash@0 {
>> + compatible = "spansion,m25p80", "jedec,spi-nor";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + m25p,fast-read;
>> + spi-max-frequency = <20000000>;
>> + spi-rx-bus-width = <4>;
>> + spi-tx-bus-width = <4>;
>> + reg = <0>;
>> + };
>> +};
>> +
>> &duart0 {
>> status = "okay";
>> };
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
>> index 5edb1e137a52..6017e9cfe40a 100644
>> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
>> @@ -38,3 +38,18 @@
>> &sata {
>> status = "okay";
>> };
>> +
>> +&qspi {
>> + status = "okay";
>> +
>> + qflash0: flash@0 {
>> + compatible = "spansion,m25p80", "jedec,spi-nor";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + m25p,fast-read;
>> + spi-max-frequency = <20000000>;
>> + spi-rx-bus-width = <4>;
>> + spi-tx-bus-width = <4>;
>> + reg = <0>;
>> + };
>> +};
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
>> index ec6257a5b251..268268c6a149 100644
>> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
>> @@ -350,6 +350,21 @@
>> status = "disabled";
>> };
>>
>> + qspi: spi@1550000 {
>
> Please sort node with unit-address in that address. That said, it
> should go before esdhc@1560000.
>
>> + compatible = "fsl,ls1021a-qspi", "fsl,ls1012a-qspi";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <0x0 0x1550000 0x0 0x10000>,
>> + <0x0 0x40000000 0x0 0x10000000>;
>> + reg-names = "QuadSPI", "QuadSPI-memory";
>> + interrupts = <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>;
>> + clock-names = "qspi_en", "qspi";
>> + clocks = <&clockgen 4 1>, <&clockgen 4 1>;
>> + big-endian;
>> + fsl,qspi-has-second-chip;
>
> Undocumented property?
Both properties, "fsl,qspi-has-second-chip" and "big-endian" are deprecated.
See:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=78df30808961cd32f0517c7469886386b0680852
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: [EXT] Re: [PATCH] arm64: dts: ls1012a: Add QSPI support for ls1012a
2019-05-23 9:01 ` Schrempf Frieder
@ 2019-05-23 9:19 ` Kuldeep Singh
0 siblings, 0 replies; 9+ messages in thread
From: Kuldeep Singh @ 2019-05-23 9:19 UTC (permalink / raw)
To: Schrempf Frieder, Shawn Guo
Cc: devicetree@vger.kernel.org, bbrezillon@kernel.org, Ashish Kumar,
broonie@kernel.org, linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Hi Shawn and Frieder,
> -----Original Message-----
> From: Schrempf Frieder [mailto:frieder.schrempf@kontron.de]
> Sent: Thursday, May 23, 2019 2:31 PM
> To: Shawn Guo <shawnguo@kernel.org>; Kuldeep Singh
> <kuldeep.singh@nxp.com>
> Cc: devicetree@vger.kernel.org; bbrezillon@kernel.org; Ashish Kumar
> <ashish.kumar@nxp.com>; broonie@kernel.org; linux-
> mtd@lists.infradead.org; linux-arm-kernel@lists.infradead.org
> Subject: [EXT] Re: [PATCH] arm64: dts: ls1012a: Add QSPI support for ls1012a
>
> Caution: EXT Email
>
> On 23.05.19 10:43, Shawn Guo wrote:
> > On Thu, May 16, 2019 at 11:47:04AM +0000, Kuldeep Singh wrote:
> >> QSPI support is added for kernel version greater than 5.0 and
> >> supports quad mode defined by TX-WIDTH = <4>, RX-WIDTH = <4>
> >>
> >> RDB/QDS has one 64MB flash from SPANSION(s25fs512s)
> >>
> >> Signed-off-by: Ashish Kumar <ashish.kumar@nxp.com>
> >> Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com>
> >> ---
> >> Dependency on
> >>
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat
> >>
> chwork.ozlabs.org%2Fpatch%2F1100471%2F&data=02%7C01%7Ckuldee
> p.sin
> >>
> gh%40nxp.com%7C5f9556e9b9b943c5568608d6df5d2e40%7C686ea1d3bc2b4
> c6fa92
> >>
> cd99c5c301635%7C0%7C0%7C636941988633482881&sdata=Pj4XNJHmhK
> HtBrzg
> >> eC%2BNA7Lkl3BDEdL1uEVqAnoPcS8%3D&reserved=0
> >> Dependency on
> >>
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat
> >>
> chwork.ozlabs.org%2Fpatch%2F1100472%2F&data=02%7C01%7Ckuldee
> p.sin
> >>
> gh%40nxp.com%7C5f9556e9b9b943c5568608d6df5d2e40%7C686ea1d3bc2b4
> c6fa92
> >>
> cd99c5c301635%7C0%7C0%7C636941988633482881&sdata=zZ4jCpNyxQl
> CL6uU
> >> PK8LG%2BVV8jWOCBg45ZrGoqT3gnU%3D&reserved=0
> >>
> >> .../arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts | 15
> +++++++++++++++
> >> .../arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts | 15
> +++++++++++++++
> >> arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts | 15
> +++++++++++++++
> >> arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts | 15
> +++++++++++++++
> >> arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 15
> +++++++++++++++
> >> 5 files changed, 75 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
> >> b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
> >> index f90c040fd5e8..8826278b37bf 100644
> >> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
> >> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
> >> @@ -61,6 +61,21 @@
> >> status = "okay";
> >> };
> >>
> >> +&qspi {
> >
> > Please sort these labeling nodes alphabetically. That said, &qspi
> > should go after &i2c0.
Ok, will update in next version
> >
> >> + status = "okay";
> >> +
> >> + qflash0: flash@0 {
> >> + compatible = "spansion,m25p80", "jedec,spi-nor";
> >> + #address-cells = <1>;
> >> + #size-cells = <1>;
> >> + m25p,fast-read;
> >> + spi-max-frequency = <20000000>;
> >> + spi-rx-bus-width = <4>;
> >> + spi-tx-bus-width = <4>;
> >> + reg = <0>;
> >> + };
> >> +};
> >> +
> >> &i2c0 {
> >> status = "okay";
> >>
> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts
> >> b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts
> >> index 8749634c55ee..0246e8c97628 100644
> >> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts
> >> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts
> >> @@ -20,6 +20,21 @@
> >> status = "okay";
> >> };
> >>
> >> +&qspi {
> >> + status = "okay";
> >> +
> >> + qflash0: flash@0 {
> >> + compatible = "spansion,m25p80", "jedec,spi-nor";
> >> + #address-cells = <1>;
> >> + #size-cells = <1>;
> >> + m25p,fast-read;
> >> + spi-max-frequency = <20000000>;
> >> + spi-rx-bus-width = <4>;
> >> + spi-tx-bus-width = <4>;
> >> + reg = <0>;
> >> + };
> >> +};
> >> +
> >> &i2c0 {
> >> status = "okay";
> >> };
> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
> >> b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
> >> index 2fb1cb1f7d8f..c304fa20c1c9 100644
> >> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
> >> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
> >> @@ -90,6 +90,21 @@
> >> };
> >> };
> >>
> >> +&qspi {
> >> + status = "okay";
> >> +
> >> + qflash0: flash@0 {
> >> + compatible = "spansion,m25p80", "jedec,spi-nor";
> >> + #address-cells = <1>;
> >> + #size-cells = <1>;
> >> + m25p,fast-read;
> >> + spi-max-frequency = <20000000>;
> >> + spi-rx-bus-width = <4>;
> >> + spi-tx-bus-width = <4>;
> >> + reg = <0>;
> >> + };
> >> +};
> >> +
> >> &duart0 {
> >> status = "okay";
> >> };
> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> >> b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> >> index 5edb1e137a52..6017e9cfe40a 100644
> >> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> >> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> >> @@ -38,3 +38,18 @@
> >> &sata {
> >> status = "okay";
> >> };
> >> +
> >> +&qspi {
> >> + status = "okay";
> >> +
> >> + qflash0: flash@0 {
> >> + compatible = "spansion,m25p80", "jedec,spi-nor";
> >> + #address-cells = <1>;
> >> + #size-cells = <1>;
> >> + m25p,fast-read;
> >> + spi-max-frequency = <20000000>;
> >> + spi-rx-bus-width = <4>;
> >> + spi-tx-bus-width = <4>;
> >> + reg = <0>;
> >> + };
> >> +};
> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> >> b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> >> index ec6257a5b251..268268c6a149 100644
> >> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> >> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> >> @@ -350,6 +350,21 @@
> >> status = "disabled";
> >> };
> >>
> >> + qspi: spi@1550000 {
> >
> > Please sort node with unit-address in that address. That said, it
> > should go before esdhc@1560000.
Ok
> >
> >> + compatible = "fsl,ls1021a-qspi", "fsl,ls1012a-qspi";
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> + reg = <0x0 0x1550000 0x0 0x10000>,
> >> + <0x0 0x40000000 0x0 0x10000000>;
> >> + reg-names = "QuadSPI", "QuadSPI-memory";
> >> + interrupts = <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>;
> >> + clock-names = "qspi_en", "qspi";
> >> + clocks = <&clockgen 4 1>, <&clockgen 4 1>;
> >> + big-endian;
> >> + fsl,qspi-has-second-chip;
> >
> > Undocumented property?
>
> Both properties, "fsl,qspi-has-second-chip" and "big-endian" are deprecated.
Will remove both in next version
>
> See:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.ke
> rnel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git%2
> Fcommit%2F%3Fid%3D78df30808961cd32f0517c7469886386b0680852&d
> ata=02%7C01%7Ckuldeep.singh%40nxp.com%7C5f9556e9b9b943c5568608d6
> df5d2e40%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6369419886
> 33482881&sdata=CDxhRylo%2FLO2rHtEUu5DhtFiBr%2BWFRQl0%2BJFVJ
> T7y%2B0%3D&reserved=0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread