From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD987C282E1 for ; Fri, 24 May 2019 20:43:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B118A21871 for ; Fri, 24 May 2019 20:43:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="H2MfvTy+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B118A21871 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5X3WnhZgYQ7QH5lKbBsXe+jqxvvM8dzLoZbnOXh+jSM=; b=H2MfvTy+r+DlamiC4xGARngmI WzbCUrR/LzMVtQgiKQ1X4HsFI7pHXpzTW6DjwK9nz508+olozDeNJSYbJhPWeUd8y5XMljnrUizgn F5H0ncVUmKEQo9SJW6SQ0GmfqnwnCIFuJdKWmsQfL1Tgn31sw6FOZm+eAXa/OHmN2vNujX9Pr52je ZqK8s2oZbk1BYJ2tiYkjMQuPTXe6Xzv8yAeiKAQy7/L5kVyU9rzBcu0Po5ukLF0SasAXnrDiOuKNh 3i92mBeEe2/CA6PtiC1BgkMkodhX8CAd73bWXQOWpDqxvBmJc+HnQXlIwJxH5cdgNS9oska/Eay/r i669+7WNw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hUH1g-00044U-Rc; Fri, 24 May 2019 20:42:52 +0000 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hUH1c-00042z-ML for linux-arm-kernel@lists.infradead.org; Fri, 24 May 2019 20:42:50 +0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id E738D80302; Fri, 24 May 2019 22:42:29 +0200 (CEST) Date: Fri, 24 May 2019 22:42:39 +0200 From: Pavel Machek To: Angus Ainslie Subject: Re: [PATCH v14 1/3] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit Message-ID: <20190524204239.GA18646@amd> References: <20190524183257.16066-1-angus@akkea.ca> <20190524183257.16066-2-angus@akkea.ca> MIME-Version: 1.0 In-Reply-To: <20190524183257.16066-2-angus@akkea.ca> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190524_134248_878772_14CF1434 X-CRM114-Status: GOOD ( 12.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Fabio Estevam , Sascha Hauer , linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , angus.ainslie@puri.sm, Shawn Guo , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============0098320423127141892==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0098320423127141892== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="FL5UXtIhxfXey3p5" Content-Disposition: inline --FL5UXtIhxfXey3p5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > + leds { > + compatible =3D "gpio-leds"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pinctrl_gpio_leds>; > + > + led1 { > + label =3D "LED 1"; > + gpios =3D <&gpio1 13 GPIO_ACTIVE_HIGH>; > + default-state =3D "off"; > + }; > + }; I had comments about these... > + vibrator { > + compatible =3D "gpio-vibrator"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pinctrl_haptic>; > + enable-gpios =3D <&gpio5 4 GPIO_ACTIVE_LOW>; > + vcc-supply =3D <®_3v3_p>; > + }; Thanks! > + charger@6b { /* bq25896 */ > + compatible =3D "ti,bq25890"; > + reg =3D <0x6b>; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pinctrl_charger>; > + interrupt-parent =3D <&gpio3>; > + interrupts =3D <25 IRQ_TYPE_EDGE_FALLING>; > + ti,battery-regulation-voltage =3D <4192000>; /* 4.192V */ > + ti,charge-current =3D <1600000>; /* 1.6 A */ > + ti,termination-current =3D <66000>; /* 66mA */ > + ti,precharge-current =3D <1300000>; /* 1.3A */ > + ti,minimum-sys-voltage =3D <2750000>; /* 2.75V */ > + ti,boost-voltage =3D <5000000>; /* 5V */ > + ti,boost-max-current =3D <50000>; /* 50mA */ > + }; And this. Did they get lost somewhere? Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --FL5UXtIhxfXey3p5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlzoVz8ACgkQMOfwapXb+vIdgQCghne8A075NT7kuQmW7jP5hq3r KZUAoKXRSu20WmzRx4utr7RCAfCkzzmY =GIv0 -----END PGP SIGNATURE----- --FL5UXtIhxfXey3p5-- --===============0098320423127141892== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0098320423127141892==--