From: Vinod Koul <vkoul@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: dmaengine@vger.kernel.org, dan.j.williams@intel.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/2] dmaengine: ti: edma: Polled completion support
Date: Mon, 27 May 2019 12:09:32 +0530 [thread overview]
Message-ID: <20190527063932.GE15118@vkoul-mobl> (raw)
In-Reply-To: <19b0d346-5249-e832-8eea-685c8e7706e2@ti.com>
On 23-05-19, 13:57, Peter Ujfalusi wrote:
> Vinod,
>
> On 21/05/2019 12.36, Peter Ujfalusi wrote:
> > Hi,
> >
> > Changes since v2:
> > - Fix typo in the comment for patch 0
> >
> > Changes since v1:
> > - Cleanup patch for the array register handling
> > - typo fixed in patch2 commit message
> >
> > The code around the array register access was pretty confusing for the first
> > look, so clean them up first then use the cleaner way in the polled handling.
> >
> > When a DMA client driver decides that it is not providing callback for
> > completion of a transfer (and/or does not set the DMA_PREP_INTERRUPT) but
> > it will poll the status of the transfer (in case of short memcpy for
> > example) we will not get interrupt for the completion of the transfer and
> > will not mark the transaction as done.
> >
> > Check the event registers (ER and EER) and if the channel is inactive then
> > return wioth DMA_COMPLETE to let the client know that the transfer is
> > completed.
>
> Please do not pick this up yet, I got report that it might cause side
> effect which I need to debug to understand.
OK dropped for queue
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-05-27 6:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 9:36 [PATCH v3 0/2] dmaengine: ti: edma: Polled completion support Peter Ujfalusi
2019-05-21 9:36 ` [PATCH v3 1/2] dmaengine: ti: edma: Clean up the 2x32bit array register accesses Peter Ujfalusi
2019-05-21 9:36 ` [PATCH v3 2/2] dmaengine: ti: edma: Enable support for polled (memcpy) completion Peter Ujfalusi
2019-05-23 10:57 ` [PATCH v3 0/2] dmaengine: ti: edma: Polled completion support Peter Ujfalusi
2019-05-27 6:39 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190527063932.GE15118@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox