From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Yegor Timoshenko <yegortimoshenko@riseup.net>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: allwinner: a64: bananapi-m64: enable UART2
Date: Mon, 27 May 2019 11:58:49 +0200 [thread overview]
Message-ID: <20190527095849.uvsivexbb6tfjccw@flea> (raw)
In-Reply-To: <20190526094715.12289-1-yegortimoshenko@riseup.net>
[-- Attachment #1.1: Type: text/plain, Size: 1449 bytes --]
Hi,
On Sun, May 26, 2019 at 12:47:15PM +0300, Yegor Timoshenko wrote:
> BananaPi M64 exposes UART2 interface that is supposed to be enabled
> by default (see "Default Function" in the pin definition table from
> the manufacturer [1]).
>
> [1]: https://bananapi.gitbooks.io/bpi-m64/en/bpi-m64gpiopindefine.html
>
> Signed-off-by: Yegor Timoshenko <yegortimoshenko@riseup.net>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> index 094cfed13df9..100d1a8fd292 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> @@ -54,6 +54,7 @@
> ethernet0 = &emac;
> serial0 = &uart0;
> serial1 = &uart1;
> + serial2 = &uart2;
> };
>
> chosen {
> @@ -312,6 +313,12 @@
> status = "okay";
> };
>
> +&uart2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart2_pins>;
> + status = "okay";
> +};
> +
Unfortunately, this can still be used for something else. Our policy
so far has been that we would fill the muxing but keep the nodes
disabled so that it's easier for people that want to enable it, but it
seems like it's already using the default muxing as well.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-05-27 9:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-26 9:47 [PATCH] arm64: dts: allwinner: a64: bananapi-m64: enable UART2 Yegor Timoshenko
2019-05-27 9:58 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190527095849.uvsivexbb6tfjccw@flea \
--to=maxime.ripard@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=yegortimoshenko@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox