From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EC69C04AB6 for ; Tue, 28 May 2019 12:20:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3359C2081C for ; Tue, 28 May 2019 12:20:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ssiqo4Ra" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3359C2081C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I5dkeYxolBSP0JUTkv7+gA1acaKJPyyFmI4NuywxqIA=; b=Ssiqo4RaLK0cLr 5vr1wPYbml4Dh5FMbTnJycWn+uKZY1gVCnVMAPkL4euPbkwVnxw3PkZVfV+ijbsNKHNRQ+egbCaWa 9KhGyqKO4XY6I+GdE/grl6AcBddlKppUnCe3FtXKElKKGv9cw1qWBDp+0Ul8m5P+4MwdCtiPWYS65 EOvrVyQZBkJ8J0d3e40pBE9SwgU9280rnpEITWq1PO5pTDThW8hgzm5Wn4C7hu1hj+RoAAcs+s/+4 az8ZpXbhfkTu61UXOE4SwuvpY/IcHu6QFzhvJQlkPtmGC1moe/rNlXnLhCxKAth+ScM/r98L2hfoS Fhphjbv1iMJhmCN4VN0A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVb5y-0007pN-MY; Tue, 28 May 2019 12:20:46 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVb5v-0007p0-BF for linux-arm-kernel@lists.infradead.org; Tue, 28 May 2019 12:20:45 +0000 Received: from localhost (lfbn-1-10718-76.w90-89.abo.wanadoo.fr [90.89.68.76]) (Authenticated sender: maxime.ripard@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 6E6FA200017; Tue, 28 May 2019 12:20:26 +0000 (UTC) Date: Tue, 28 May 2019 14:20:25 +0200 From: Maxime Ripard To: Alexandre Belloni Subject: Re: [PATCH 01/10] dt-bindings: rtc: Move trivial RTC over to trivial devices Message-ID: <20190528122025.vv4oyt5cwetj2hzp@flea> References: <290402405a34506997fd2fab2c4c1486dbe6b7e5.1558958381.git-series.maxime.ripard@bootlin.com> <20190527120626.GM3274@piout.net> <20190527121832.lui2n6vhlemlqy2z@flea> <20190527160657.GN3274@piout.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190527160657.GN3274@piout.net> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190528_052043_538603_592A1770 X-CRM114-Status: GOOD ( 17.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Chen-Yu Tsai , Rob Herring , Frank Rowand , linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mon, May 27, 2019 at 06:06:57PM +0200, Alexandre Belloni wrote: > On 27/05/2019 14:18:32+0200, Maxime Ripard wrote: > > Hi Alex, > > > > On Mon, May 27, 2019 at 02:06:26PM +0200, Alexandre Belloni wrote: > > > On 27/05/2019 14:00:33+0200, Maxime Ripard wrote: > > > > The RTC generic bindings has a bunch of devices that have a pretty simple > > > > binding, with just compatible, reg and optional interrupts properties. > > > > > > > > > > This is not true, they all also support the star-year property, this is > > > why they are not in the trivial-devices file anymore. > > > > Ok, I misunderstood the binding then. > > > > Should we create a separate file for the trivial RTC, on the model of > > the trivial-devices but supporting all the RTC properties? > > I would say that this is the way forward. Note that all the RTCs > support start-year but you will have to check for the other > properties. The way this will work is that it's a two layers thing. Patch 2 creates a generic RTC binding schema that will match on two things: - Schemas including it directly, - any devicetree node following the node name pattern. The point of that schema is to validate that every node (or binding), if it has those properties, the schemas will make sure that it's the proper type, (and if we would have any) ranges, etc. Then, it's up for the driver schemas to do a more on-point validation, with whatever constraints they have. They can choose to restrict the set of properties, or not to, it's really up to the device schema. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel