From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E45BC04AB6 for ; Tue, 28 May 2019 20:30:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64B2320B7C for ; Tue, 28 May 2019 20:30:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NO50ejI9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Ba1Cm97v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64B2320B7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e43yoRXtTKOxyn1DbAePdqnyUkFu7BE+aEgjI/WkfkA=; b=NO50ejI9+oV+Fa Lm8Rpma35N/2q2JzFgA2/RQ0iMmH/OMpYJyQMmNN/c3gQ26i/SL/iQOIrTj0W9+GPZiDL/GNGfP2x Blfc4VFQxKgyo+TXSx80F7ggII+A5AUvoVpff26bFjARcErei508j+EOj+/CW4sIwYI5brR6bof3h bN7xeeV7Vi0/mCAybBdxHsB7Pg6LKfuxXPPy/vKtvkpvMr1OPZ8NIPcc5Ne819umc83v/8FXUvE27 lzcqdvQe5Ax3ru3jSqxgU02FAyjKxaPlcC1ihGWpwdtxvhMJDJpErHHhgRSca4c401tS6xrapWTJZ NzN5FbVL/vQKj8lGtHWw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVijK-0000PJ-5Z; Tue, 28 May 2019 20:29:54 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVijF-0000Nv-PX for linux-arm-kernel@lists.infradead.org; Tue, 28 May 2019 20:29:51 +0000 Received: by mail-pf1-x443.google.com with SMTP id j2so8357pfe.6 for ; Tue, 28 May 2019 13:29:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=CH0uDuCm1IZlUutTSqd9yHCBwqxTh5kY/MOarp++qiU=; b=Ba1Cm97vb6ARxJQgfFXGjdotGsHAP99t/791OfuTEFhQFlnonFvYATsLPtmM952cBb ajhyIOeCIEH27PBz35HtzQmv3gJxOblUx4CDV+xaaHSLjF9wB9h5iRcgoBr1N3KZ0TQ7 DALG2D46yz9XpmIQQwMbvthZxrRnlJkstuZII= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CH0uDuCm1IZlUutTSqd9yHCBwqxTh5kY/MOarp++qiU=; b=igw2eQ3rjqptEVa2Okjv/5P/s8U3zTDRvC+6A9lhbungdb6vodov7p8lNXzHCWmPSD JZqb6ePvzMlwumOEyGgg45V+zBpgCqTFWXSRaP+hJjKDymoHd/OQ0vFPu7G2AFQjL1vt nFSw4ArjG2PZallA8KQBfbTD6yHNYF6W0qyxr/xqp40yCoVEiq4dVWpo6XeRE2r4p470 38DIQrlNC0ye5baFozC1YV/C4P4pBc0N38ptJQGh6NHCvSyLexkcTTOTrbo2rJ0SkBm/ IKed8fAwi96xXKWyvY+TiIzdEk+zBXMeL3eR7oJAUy4nQGNRciFzA7q/TEJTF+NzHaPq LuOg== X-Gm-Message-State: APjAAAV9PS3Ndki9HxPtrreRhfCXoTh4mMz6L/tZUntAQXjxlPnxh+uU i5ggS/+Rz5fEuJTUruKnGElwtQ== X-Google-Smtp-Source: APXvYqyJR8ErjR2+NyhyJOJUsta+0OAa1/KNcVcMUt+b3JS9GeD6tSPYwwARr6LFNFDtWBcPhMCA2w== X-Received: by 2002:a63:ff23:: with SMTP id k35mr103694764pgi.139.1559075388740; Tue, 28 May 2019 13:29:48 -0700 (PDT) Received: from localhost ([2620:15c:202:1:75a:3f6e:21d:9374]) by smtp.gmail.com with ESMTPSA id f29sm23276944pfq.11.2019.05.28.13.29.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 May 2019 13:29:47 -0700 (PDT) Date: Tue, 28 May 2019 13:29:47 -0700 From: Matthias Kaehlcke To: Douglas Anderson Subject: Re: [PATCH] ARM: dts: rockchip: Add pin names for rk3288-veyron jaq, mickey, speedy Message-ID: <20190528202947.GL40515@google.com> References: <20190524233309.45420-1-dianders@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190524233309.45420-1-dianders@chromium.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190528_132949_855462_1EFB33E8 X-CRM114-Status: GOOD ( 16.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Heiko Stuebner , briannorris@chromium.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , ryandcase@chromium.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 24, 2019 at 04:33:09PM -0700, Douglas Anderson wrote: > This is like commit 0ca87bd5baa6 ("ARM: dts: rockchip: Add pin names > for rk3288-veyron-jerry") and commit ca3516b32cd9 ("ARM: dts: > rockchip: Add pin names for rk3288-veyron-minnie") but for 3 more > veyron boards. > > A few notes: > - While there is most certainly duplication between all the veyron > boards, it still feels like it is sane to just have each board have > a full list of its pin names. The format of "gpio-line-names" does > not lend itself to one-off overriding and besides it seems sane to > more fully match schematic names. Also note that the extra > duplication here is only in source code and is unlikely to ever > change (since these boards are shipped). Duplication in the .dtb > files is unavoidable. > - veyron-jaq and veyron-mighty are very closely related and so I have > shared a single list for them both with comments on how they are > different. This is just a typo fix on one of the boards, a possible > missing signal on one of the boards (or perhaps I was never given > the most recent schematics?) and dealing with the fact that one of > the two boards has full sized SD. > > Signed-off-by: Douglas Anderson Reviewed-by: Matthias Kaehlcke