From: Eduardo Valentin <edubezval@gmail.com>
To: Yuantian Tang <andy.tang@nxp.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org, daniel.lezcano@linaro.org,
linux-kernel@vger.kernel.org, leoyang.li@nxp.com,
robh+dt@kernel.org, rui.zhang@intel.com, shawnguo@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: ls1028a: Add Thermal Monitor Unit node
Date: Tue, 28 May 2019 19:53:32 -0700 [thread overview]
Message-ID: <20190529025331.GB2419@localhost.localdomain> (raw)
In-Reply-To: <20190425082640.37982-1-andy.tang@nxp.com>
On Thu, Apr 25, 2019 at 04:26:40PM +0800, Yuantian Tang wrote:
> The Thermal Monitoring Unit (TMU) monitors and reports the
> temperature from 2 remote temperature measurement sites
> located on ls1028a chip.
> Add TMU dts node to enable this feature.
>
> Signed-off-by: Yuantian Tang <andy.tang@nxp.com>
I dont see anything wrong from a thermal standpoint.
Acked-by: Eduardo Valentin <edubezval@gmail.com>
Please get this via your arch tree maintainer to avoid merge conflicts.
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 114 ++++++++++++++++++++++++
> 1 files changed, 114 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index b045812..a25f5fc 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -29,6 +29,7 @@
> clocks = <&clockgen 1 0>;
> next-level-cache = <&l2>;
> cpu-idle-states = <&CPU_PH20>;
> + #cooling-cells = <2>;
> };
>
> cpu1: cpu@1 {
> @@ -39,6 +40,7 @@
> clocks = <&clockgen 1 0>;
> next-level-cache = <&l2>;
> cpu-idle-states = <&CPU_PH20>;
> + #cooling-cells = <2>;
> };
>
> l2: l2-cache {
> @@ -398,6 +400,118 @@
> status = "disabled";
> };
>
> + tmu: tmu@1f00000 {
> + compatible = "fsl,qoriq-tmu";
> + reg = <0x0 0x1f80000 0x0 0x10000>;
> + interrupts = <0 23 0x4>;
> + fsl,tmu-range = <0xb0000 0xa0026 0x80048 0x70061>;
> + fsl,tmu-calibration = <0x00000000 0x00000024
> + 0x00000001 0x0000002b
> + 0x00000002 0x00000031
> + 0x00000003 0x00000038
> + 0x00000004 0x0000003f
> + 0x00000005 0x00000045
> + 0x00000006 0x0000004c
> + 0x00000007 0x00000053
> + 0x00000008 0x00000059
> + 0x00000009 0x00000060
> + 0x0000000a 0x00000066
> + 0x0000000b 0x0000006d
> +
> + 0x00010000 0x0000001c
> + 0x00010001 0x00000024
> + 0x00010002 0x0000002c
> + 0x00010003 0x00000035
> + 0x00010004 0x0000003d
> + 0x00010005 0x00000045
> + 0x00010006 0x0000004d
> + 0x00010007 0x00000045
> + 0x00010008 0x0000005e
> + 0x00010009 0x00000066
> + 0x0001000a 0x0000006e
> +
> + 0x00020000 0x00000018
> + 0x00020001 0x00000022
> + 0x00020002 0x0000002d
> + 0x00020003 0x00000038
> + 0x00020004 0x00000043
> + 0x00020005 0x0000004d
> + 0x00020006 0x00000058
> + 0x00020007 0x00000063
> + 0x00020008 0x0000006e
> +
> + 0x00030000 0x00000010
> + 0x00030001 0x0000001c
> + 0x00030002 0x00000029
> + 0x00030003 0x00000036
> + 0x00030004 0x00000042
> + 0x00030005 0x0000004f
> + 0x00030006 0x0000005b
> + 0x00030007 0x00000068>;
> + little-endian;
> + #thermal-sensor-cells = <1>;
> + };
> +
> + thermal-zones {
> + core-cluster {
> + polling-delay-passive = <1000>;
> + polling-delay = <5000>;
> + thermal-sensors = <&tmu 0>;
> +
> + trips {
> + core_cluster_alert: core-cluster-alert {
> + temperature = <85000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> + core_cluster_crit: core-cluster-crit {
> + temperature = <95000>;
> + hysteresis = <2000>;
> + type = "critical";
> + };
> + };
> +
> + cooling-maps {
> + map0 {
> + trip = <&core_cluster_alert>;
> + cooling-device =
> + <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + };
> + };
> + };
> +
> + ddr-controller {
> + polling-delay-passive = <1000>;
> + polling-delay = <5000>;
> + thermal-sensors = <&tmu 1>;
> +
> + trips {
> + ddr_controller_alert: ddr-controller-alert {
> + temperature = <85000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> + ddr_controller_crit: ddr-controller-crit {
> + temperature = <95000>;
> + hysteresis = <2000>;
> + type = "critical";
> + };
> + };
> +
> + cooling-maps {
> + map0 {
> + trip = <&ddr_controller_alert>;
> + cooling-device =
> + <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + };
> + };
> + };
> + };
> +
> pcie@1f0000000 { /* Integrated Endpoint Root Complex */
> compatible = "pci-host-ecam-generic";
> reg = <0x01 0xf0000000 0x0 0x100000>;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-29 2:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 8:26 [PATCH] arm64: dts: ls1028a: Add Thermal Monitor Unit node Yuantian Tang
2019-05-29 2:53 ` Eduardo Valentin [this message]
2019-05-29 3:26 ` [EXT] " Andy Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529025331.GB2419@localhost.localdomain \
--to=edubezval@gmail.com \
--cc=andy.tang@nxp.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).