From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDCB5C28CC0 for ; Wed, 29 May 2019 10:28:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C46692070D for ; Wed, 29 May 2019 10:28:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sZXxj/jY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n5oxxiJD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C46692070D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6g5mgMs/e3CJHZRPP3s8ruagZ2NIlgUQ3uzjYsOlNbk=; b=sZXxj/jYkEPo+V jWL8SpnT0jia6PGSKJTpNfpVZCSGlBVsMH0K6bCUyzwvQFnPgMKhxFtTmZF2L29zIVYZ9vVI+L88c rvPzwVKYXabMbFYiqAXUXKgGhuKkxk4C131JQbkzGyEiz98GrudqquugMlgNlIH6djb7obmyphnhK LWbpRgH++gauBs9bYLVzLjGUdC9JR+tBztwc0N+HwnPNEN4ZHUU++SXL1GoSMrZwNa7gp3wXrkkqd t1uRTYzIb6X51/5wfPYWumOIsFOdOnMvdScRM0wQb+6xdlVSsE0nYoUhAEB1uA516PDTNtZuyP9Jm 9zTMt6dpXYh1Q6eMyZuA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVvoU-0001jb-Mp; Wed, 29 May 2019 10:28:06 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVvnQ-0000R2-6y for linux-arm-kernel@lists.infradead.org; Wed, 29 May 2019 10:27:04 +0000 Received: by mail-wr1-x444.google.com with SMTP id f8so1378025wrt.1 for ; Wed, 29 May 2019 03:27:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F4ek3zhf26WPz8SCGgna791YOt0uckHhipVYXfvPpfU=; b=n5oxxiJDyt8yneaPCfXwu7Qf4lqKWCndkvzR5bGCkZ9MPGzEORul3krIgIDgl45oGN PWUt79YD421ML4vQTauuPSKigORoLW0kbcOgo8l9GQbfaLW6YSzA0/kWc+eJoXPkMYr6 c17dOtopGGPXF6R/h4HZafeIEVm4xvOQyhScfNEjXEI01dhmeRd8rbgV9DIpnHTDnmqy dR3GyA/2sMKBoFxrHKzN42Toj0nG8xEgdldygrVWF2Oo5lhSQQIOul0OXeVe+frc5tFE 6zuV0vSREi73pASxy66Ys/47ZyrfHBe6QpytHNfzBt/omfnDA3e3VuB0QUASbu0LY3aW dSfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F4ek3zhf26WPz8SCGgna791YOt0uckHhipVYXfvPpfU=; b=uKIWIBs5DJSdnppBzeNlLSFsRPfOtnXhv0/2RKZhovTgceGvry292HveNSJXRG7ff4 A8dZnHpGDMe60slsB4oj1AgWHB6gVcvGWAntoy2NkPHZ1evPSlE5gGS8tECUx1j0SjYo 8fGQJVcXIFZTjJG5EoNoN3P+P7mjdwEvWtcGtSBmM9r7jHiDT/GlbjGJPmzsQ+vE54ur wO0LR5XNmZ0Ow4zZvyAwFbCtIVyR1C+oVL40Bp42ONUHqkNm9FzAYEwh4qYjWdpMYEJ5 9JgE6Mj2o4qnzRU/rp/DNFx4H3YtboAjTOL+ehm2yeNt82iVxm6kkVf03V/MxKciQbMz vDdA== X-Gm-Message-State: APjAAAV1rLRIVvVyqcwNHu7/313XKW6I0d5AWZjDBLM3l27bUAWh2giE T4u4/AtlM+wBTg16D8di9XdbamjV X-Google-Smtp-Source: APXvYqzzqvqYh9R4VEQzQroevdoud8G85S2Hh/csnHhyDgdBiZ+4LqpzQDY8Qqva1KFlLCrzMbuoAQ== X-Received: by 2002:adf:ef83:: with SMTP id d3mr8922611wro.253.1559125618796; Wed, 29 May 2019 03:26:58 -0700 (PDT) Received: from localhost (p2E5BEF36.dip0.t-ipconnect.de. [46.91.239.54]) by smtp.gmail.com with ESMTPSA id r8sm498454wrt.92.2019.05.29.03.26.58 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 29 May 2019 03:26:58 -0700 (PDT) From: Thierry Reding To: Thierry Reding Subject: [PATCH 2/2] soc/tegra: pmc: Avoid crash for non-wake IRQs Date: Wed, 29 May 2019 12:26:54 +0200 Message-Id: <20190529102654.14665-2-thierry.reding@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190529102654.14665-1-thierry.reding@gmail.com> References: <20190529102654.14665-1-thierry.reding@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190529_032701_180331_ED03FBF0 X-CRM114-Status: GOOD ( 11.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, Bitan Biswas , linux-arm-kernel@lists.infradead.org, Jon Hunter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Thierry Reding For interrupts that are not wakeup sources but that may end up getting mapped through the PMC as interrupt parent (this can happen for GPIOs), return early in order to avoid a subsequent crash from an out-of-bounds access to the register region. Reported-by: Bitan Biswas Signed-off-by: Thierry Reding --- drivers/soc/tegra/pmc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c index 653fe2c466f6..6e66b5e293be 100644 --- a/drivers/soc/tegra/pmc.c +++ b/drivers/soc/tegra/pmc.c @@ -1924,6 +1924,9 @@ static int tegra_pmc_irq_set_wake(struct irq_data *data, unsigned int on) unsigned int offset, bit; u32 value; + if (WARN_ON(data->hwirq == ULONG_MAX)) + return 0; + offset = data->hwirq / 32; bit = data->hwirq % 32; -- 2.21.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel