From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CCB0C28CC0 for ; Thu, 30 May 2019 12:58:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6631625934 for ; Thu, 30 May 2019 12:58:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tG34RI3n"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="au90tRQV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6631625934 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f2V7fklwo7qfAiUyQVGCXLtzvB2ist7SHBsQy+mSmrA=; b=tG34RI3nakX1JI Yzu1RBZEF9v5q2aN9h3tECryFrXhTRB/9Gi1C3jWlY6+4m1U51KNE4xMRbUYZvntnpL94vB2sg7fP wHTMqS1jTgzxMZNN39U09aTNgE/BnD/NwIpGC4QX/mGHev82OXQ8xghjMJZV86SBLZAoggYQkLI9M cTRiso6+7JGarTMrpSjlV2SEtlHXacXrBQJzbjPP/BlD/6HSD8Q4A2gV+S5i0nDW0mu1EH7zQrZeo vAdm2ioNqA7qxa+asZceH2NDCysvnGHWvFu52ZtWb6hMWqlFAvOq4zt/Z4UjHGZNZJRD2faWJ86fd 4G9m0w7fvztvP5CZyfpA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWKds-0002eQ-0j; Thu, 30 May 2019 12:58:48 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWKdo-0002dC-V3; Thu, 30 May 2019 12:58:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xB8+uSAdIi4vE4Eke8RLPhwzB3Hq8CNeR8jI1cAMG4Y=; b=au90tRQVfIG3mn4gw9H55zbnEe 2X/auosHq6eeIf3yI8q9MoXw6bsCpn+t+hQuP4nMOsfZAU3LJLwuxeCEpqFbkIy5EbfQ7UQJg5x46 hn1FMNgYEko9UF2kViIYhRyXeXVgyfJl3zpWoGGZxey0OkaZYCr2oONQjsUf+qWzxJl0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hWKdc-0006T7-PS; Thu, 30 May 2019 14:58:32 +0200 Date: Thu, 30 May 2019 14:58:32 +0200 From: Andrew Lunn To: Biao Huang Subject: Re: [PATCH 3/4] net: stmmac: modify default value of tx-frames Message-ID: <20190530125832.GB22727@lunn.ch> References: <1559206484-1825-1-git-send-email-biao.huang@mediatek.com> <1559206484-1825-4-git-send-email-biao.huang@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1559206484-1825-4-git-send-email-biao.huang@mediatek.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190530_055845_154587_F78E4ACC X-CRM114-Status: UNSURE ( 9.73 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jianguo.zhang@mediatek.com, Alexandre Torgue , boon.leong.ong@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, yt.shen@mediatek.com, Jose Abreu , linux-mediatek@lists.infradead.org, Maxime Coquelin , Matthias Brugger , Giuseppe Cavallaro , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 30, 2019 at 04:54:43PM +0800, Biao Huang wrote: > the default value of tx-frames is 25, it's too late when > passing tstamp to stack, then the ptp4l will fail: > > ptp4l -i eth0 -f gPTP.cfg -m > ptp4l: selected /dev/ptp0 as PTP clock > ptp4l: port 1: INITIALIZING to LISTENING on INITIALIZE > ptp4l: port 0: INITIALIZING to LISTENING on INITIALIZE > ptp4l: port 1: link up > ptp4l: timed out while polling for tx timestamp > ptp4l: increasing tx_timestamp_timeout may correct this issue, > but it is likely caused by a driver bug > ptp4l: port 1: send peer delay response failed > ptp4l: port 1: LISTENING to FAULTY on FAULT_DETECTED (FT_UNSPECIFIED) > > ptp4l tests pass when changing the tx-frames from 25 to 1 with > ethtool -C option. > It should be fine to set tx-frames default value to 1, so ptp4l will pass > by default. Hi Biao What does this do to the number of interrupts? Do we get 25 times more interrupts? Have you done any performance tests to see if this causes performance regressions? Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel