From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C71D3C28CC3 for ; Thu, 30 May 2019 16:08:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A090825D5D for ; Thu, 30 May 2019 16:08:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="l4QLEePW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="cVdkU0Us" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A090825D5D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tBz74qp50Mo8vRFjKHxJ9RXNCDuMPtcnDSF9LhIybrc=; b=l4QLEePWA1MJgp dKPvLCn8XS6O3seuTgfPhnNSF7kQ+LyO0/9L79TnHHWoqc5DNNjzu7/EjJyQfaROBQO8afNlVIc9p YC56fv8X7tFUb4hYPqIbDLGZDMwKuOEb4gZsHBe/qYBmpa5M0q92g/wCQkqhtZtyyyXtWX1gtt55i koOoFTycIWkHY4FOFT1Pq0eNSrMOo5D7WQeGgWS0LjspGi/SsBZ3IrEjTwJkt/2AyXYK0Z76rmjr7 //26/4WTlTMAIoRufCm3BGKpiiSWrxMRXyturR1LcuS/prn1HrDWiW8m+mnmf+9V+gCjETjzevS2a UkxHupuP86LdQ5tK9fLg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWNbU-0006Ez-0B; Thu, 30 May 2019 16:08:32 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWNbP-0006Cq-Hr for linux-arm-kernel@lists.infradead.org; Thu, 30 May 2019 16:08:29 +0000 Received: by mail-pl1-x641.google.com with SMTP id e7so2274540pln.4 for ; Thu, 30 May 2019 09:08:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=CCzOFuBrRzsjGJT6QYZDplwoC8znNP+oEnCTc9pJCd8=; b=cVdkU0UsiubYEXpbBQbS7cvSuFjQe08Adw6e346iSTE5OsA/QADaLcgAVFLBakmg6z 2Q2O38L63Bn80R60xkrnN8k4evgFKp+1SBFNsoKvL2F2vTQOA/WqzUnFi3fuWiBpjCnh bf2mpR9Tm+9Kh9qyWRGBinlrH9NFfRCKnnjE4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CCzOFuBrRzsjGJT6QYZDplwoC8znNP+oEnCTc9pJCd8=; b=ejJCY+506blieUe+36tx1qRG6Oj2LWmJ0F0O55zIb1CdM0zv72mJYDJB04tlX7a0Sj LG7wi5NPpeRtNVAlU2kfVUULeLpqXBoqYsbiYPs7DwHJtAfxBJ2wAhrsUx6J4+pxoev7 Oh8Ee20rUCaiROOYxmbdyjOLOMvXGCdUYf+EWH4tzwoMtDyDMtsx+6NeLQu/L/ajfV4P bHfFEifBaNTscBJjQmW2u5XRZVyyaSsLPF6a92dsvFD/wPlzPO8bZzFKz5o/ALQlcNp8 w9I79N2gv9hxRWiao1/Dm9jwMmknwd6VmxwAlXRw8hrFfpm0tX0esNkmrpKVKkjzdof4 r00A== X-Gm-Message-State: APjAAAUMQ9OcmuGjvZSxtoweuxbv2OuugRgzSru/ExOitWMGtasEG/bv qxqsEumcxsG4Qy5xBJ1WlN6vhg== X-Google-Smtp-Source: APXvYqwTufU4ReY8GoGuWrjOS8pyLhEFpYHGf/dPgPB2mg1+d5otdc1js0QS6kCxqXlGXEcw9FpdAA== X-Received: by 2002:a17:902:690b:: with SMTP id j11mr4416976plk.149.1559232506416; Thu, 30 May 2019 09:08:26 -0700 (PDT) Received: from localhost ([2620:15c:202:1:75a:3f6e:21d:9374]) by smtp.gmail.com with ESMTPSA id a69sm4045967pfa.81.2019.05.30.09.08.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 May 2019 09:08:25 -0700 (PDT) Date: Thu, 30 May 2019 09:08:25 -0700 From: Matthias Kaehlcke To: Hsin-Yi Wang Subject: Re: [PATCH v2 1/8] arm64: dts: mt8183: add thermal zone node Message-ID: <20190530160825.GM40515@google.com> References: <1557494826-6044-1-git-send-email-michael.kao@mediatek.com> <1557494826-6044-2-git-send-email-michael.kao@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190530_090827_596684_7F7FF1C9 X-CRM114-Status: GOOD ( 15.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Daniel Lezcano , lkml , "michael.kao" , Eduardo Valentin , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , Zhang Rui , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 30, 2019 at 02:27:28PM +0800, Hsin-Yi Wang wrote: > On Fri, May 10, 2019 at 9:27 PM michael.kao wrote: > > > + > > + tzts1: tzts1 { > > + polling-delay-passive = <0>; > > + polling-delay = <0>; > > + thermal-sensors = <&thermal 1>; > > + sustainable-power = <0>; > > + trips {}; > > + cooling-maps {}; > > + }; > > + > Is 0 a valid initial sustainable-power setting? Since we'll still get > warning[1] about this, though it might not be harmful. > > If 0 is a valid setting, maybe we should consider showing the warning > of not setting this property in [2]? > > [1] https://elixir.bootlin.com/linux/latest/source/drivers/thermal/power_allocator.c#L570 > [2] https://elixir.bootlin.com/linux/latest/source/drivers/thermal/of-thermal.c#L1049 IIUC a value of 0 is pointless, the thermal framework will still use an estimated value: https://elixir.bootlin.com/linux/v5.1.5/source/drivers/thermal/power_allocator.c#L203 As commented on v1 (https://patchwork.kernel.org/patch/10926519/#22620905) the value of the property may depend on the thermal characteristics of the device, there is not one correct value per SoC/core. If it is specified at SoC level device makers should be aware that they might have to override it for 'optimal' behavior on their device. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel