From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: marc.zyngier@arm.com, Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
open list <linux-kernel@vger.kernel.org>,
Shaokun Zhang <zhangshaokun@hisilicon.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/2] arm64: smp: Include smp_plat.h from smp.h
Date: Fri, 31 May 2019 00:34:27 +0100 [thread overview]
Message-ID: <20190530233427.qbaa76ukbzuuic22@shell.armlinux.org.uk> (raw)
In-Reply-To: <43c5568f-b230-0ed2-e810-7870703b54f0@gmail.com>
On Thu, May 30, 2019 at 04:20:37PM -0700, Florian Fainelli wrote:
> On 5/30/19 4:17 PM, Russell King - ARM Linux admin wrote:
> > On Thu, May 30, 2019 at 04:14:28PM -0700, Florian Fainelli wrote:
> >> On 5/30/19 4:05 PM, Florian Fainelli wrote:
> >>> Hi ARM64 maintainers,
> >>>
> >>> This patch series aims at enabling irq-bcm7038-l1.c on
> >>> ARM64/ARCH_BRCMSTB, this driver makes use of cpu_logical_map[] and in
> >>> order to avoid adding a CONFIG_ARM64 conditional inclusion of
> >>> smp_plat.h, instead smp.h includes smp_plat.h, which is in turn included
> >>> by linux/smp.h.
> >>>
> >>> If you like the approach, I would suggest to carry that through the
> >>> Broadcom ARM64 SoC pull request for 5.3.
> >>
> >> ARM (32-bit) needs the same thing kind of thing so a conditional include
> >> may be appropriate after all...
> >
> > The whole idea of the smp_plat.h vs smp.h separation is to avoid
> > including lots of arch-private stuff in the rest of the kernel
> > build, thereby exposing arch-private stuff to the world. I'm be
> > opposed to that.
>
> I was on the fence, sent it just in case, but ended up doing this:
>
> https://lore.kernel.org/patchwork/patch/1082410/
>
> will take patch #2 through the Broadcom ARM64 SoC tree once this patch
> above gets accepted.
Well, there's another alternative: we move just what is required from
smp_plat.h to smp.h.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-30 23:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 23:05 [PATCH 0/2] arm64: smp: Include smp_plat.h from smp.h Florian Fainelli
2019-05-30 23:05 ` [PATCH 1/2] " Florian Fainelli
2019-05-30 23:05 ` [PATCH 2/2] arm64: Enable BCM7038_L1_IRQ for ARCH_BRCMSTB Florian Fainelli
2019-06-11 22:03 ` Florian Fainelli
2019-05-30 23:14 ` [PATCH 0/2] arm64: smp: Include smp_plat.h from smp.h Florian Fainelli
2019-05-30 23:17 ` Russell King - ARM Linux admin
2019-05-30 23:20 ` Florian Fainelli
2019-05-30 23:34 ` Russell King - ARM Linux admin [this message]
2019-06-03 11:09 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190530233427.qbaa76ukbzuuic22@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=catalin.marinas@arm.com \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=will.deacon@arm.com \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox