From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10751C04AB6 for ; Fri, 31 May 2019 04:02:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA540263A6 for ; Fri, 31 May 2019 04:02:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iOkn3Jac"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VXw9JliX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA540263A6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UV+vl7RTJEGRhUF9TxyaD6JwBzhbtgPW+LrWyoffNuw=; b=iOkn3JacDWW6Hs WCT+CPGI+AHhTnlna7jazooeMGWxJWieHTOjtuQr35MeNH8GuIU+FQ9Bq4thIduHwVQzvNT0qwLzF ITRisFBnbaKX++5FJ6ifeC7u4+unnpfN+m19DJiG6ZnZEU9e6GCGzm1fpq94YdSYE3qmLbFGHl13k RP+QNtciMBaAVGUrAGEkIMl1unqSAQkUoRzQgTvZDJqOJHn1PI6bGdx4wl7Ha3J55Kp1rGQ76JP2g +KDGfq6EsKbfhUUPLmm9hDOgEIcYCvDC+8Ohj1hFuX0vPr6KWEYQDDMOA9CvduE3lwwtJCjuuERQJ NN2vUzE4r4KEbLpAMtaA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWYkX-0001jF-Tr; Fri, 31 May 2019 04:02:37 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWYkT-0001hm-Pi for linux-arm-kernel@lists.infradead.org; Fri, 31 May 2019 04:02:35 +0000 Received: by mail-pf1-x441.google.com with SMTP id d126so5334242pfd.2 for ; Thu, 30 May 2019 21:02:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ukEC3MMMF7VZfZKjRmeuoQSQX5eGcJH/5lmeM5Xiv1s=; b=VXw9JliX+By7ETjpg/VwT4cIvO5bt9B5kaUNS2hcsP92UbdLa1fgpaQAE/XPqJSi/7 qBTnZtb9FYsYB/JtGEalVQ7ZZYtdHM4K5tJy44QI1wae6QDJJ6S6xEvY4zV25yXLj0CZ 2MZqvtdmBIoISzz2bpfpAUYtDs14qrbKfwdwqmhwipBSmelAD2M1dde0La5Nr8hrGpXN vSzuF5L7pr/hdm+lHqsgGzCD0/7xwed8vMYeMKe/4H5rC+PljIl3sPxhcohWdzLdxYFR D2w+5vzntIcMRodAV6qZV7cE2XYHYiHmQrgogQZ7ubjNO0Lh9y3elutJb5Pb9iO8vsbM QB5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ukEC3MMMF7VZfZKjRmeuoQSQX5eGcJH/5lmeM5Xiv1s=; b=Tx+an2SpbhfZP6Q0mMVeUtLoIRN0d04NdsOoBCYnXuHXsrZlJ45M4CqxfMp8BgpsBs 4iZU/Eg4RcPsoYFTbsiw60TQuoOrcH/igxEHhPOq4VXQHfP0L+tmswJshZGlZ4zLECY6 E+tbKwbZgF41QjsLwmtpey6bjEwNYoMLqxT27t7KB/fydrg3smKozQR0eNqRSnwSVG2b eKSNdpeNb84fLHvG7DVzuZyvidanPM7vkdXswAHV+xl6X0aB3yT+nnjYOHSJ/SebFPVc xtoZoGXxGzc0vLeS8i722Ev3Oxo5R1Z4Tr56i9pZRz7PkhiOjFHMhahN+LybfJsp42cz B55Q== X-Gm-Message-State: APjAAAU4ik3I8XNAQ9Q0ZiVncD9RpReBMzlr4LL0fDnm5VaImjBFOZyE 0JG6dhnk3S8wKiube75xDBEY X-Google-Smtp-Source: APXvYqzvhodd3uafA/IahYHPivWkQXtELuD62p5DCQP+wY6MG98U46yQKwyEMeP2EeyQeZcrUWJbVQ== X-Received: by 2002:a17:90a:26a9:: with SMTP id m38mr6679956pje.93.1559275352740; Thu, 30 May 2019 21:02:32 -0700 (PDT) Received: from Mani-XPS-13-9360 ([2405:204:72cb:ebf2:a51d:3877:feab:5634]) by smtp.gmail.com with ESMTPSA id q7sm4348899pjb.0.2019.05.30.21.02.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 May 2019 21:02:31 -0700 (PDT) Date: Fri, 31 May 2019 09:32:22 +0530 From: Manivannan Sadhasivam To: Anand Moon Subject: Re: [PATCH] arm64: dts: rockchip: Add missing PCIe pwr amd rst configuration Message-ID: <20190531040222.GB9641@Mani-XPS-13-9360> References: <20190530125837.730-1-linux.amoon@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190530125837.730-1-linux.amoon@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190530_210233_975933_934E0B5B X-CRM114-Status: GOOD ( 17.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Heiko Stuebner , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , Jagan Teki , Enric Balletbo i Serra , Ezequiel Garcia , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Thu, May 30, 2019 at 12:58:37PM +0000, Anand Moon wrote: > This patch add missing PCIe gpio and pinctrl for power (#PCIE_PWR) > also add PCIe gpio and pinctrl for reset (#PCIE_PERST_L). > > Signed-off-by: Anand Moon > --- > Tested on Rock960 Model A > --- > arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi > index c7d48d41e184..f5bef6b0fe89 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi > @@ -55,9 +55,10 @@ > > vcc3v3_pcie: vcc3v3-pcie-regulator { > compatible = "regulator-fixed"; > + gpio = <&gpio2 RK_PA2 GPIO_ACTIVE_HIGH>; > enable-active-high; > pinctrl-names = "default"; > - pinctrl-0 = <&pcie_drv>; > + pinctrl-0 = <&pcie_drv &pcie_pwr>; > regulator-boot-on; > regulator-name = "vcc3v3_pcie"; > regulator-min-microvolt = <3300000>; > @@ -381,9 +382,10 @@ > }; > > &pcie0 { > + ep-gpio = <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>; > num-lanes = <4>; > pinctrl-names = "default"; > - pinctrl-0 = <&pcie_clkreqn_cpm>; > + pinctrl-0 = <&pcie_clkreqn_cpm &pcie_perst_l>; > vpcie3v3-supply = <&vcc3v3_pcie>; > status = "okay"; > }; > @@ -408,6 +410,16 @@ > }; > }; > > + pcie { > + pcie_pwr: pcie-pwr { > + rockchip,pins = <2 RK_PA2 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + > + pcie_perst_l:pcie-perst-l { > + rockchip,pins = <2 RK_PD4 RK_FUNC_GPIO &pcfg_pull_none>; > + }; Which schematics did you refer? According to Rock960 v2.1 schematics [1], below is the pin mapping for PCI-E PWR and PERST: PCIE_PERST - GPIO2_A2 PCIE_PWR - GPIO2_A5 Above mapping holds true for Rock960 version 1.1, 1.2 and 1.3. Also, rk3399-rock960.dtsi is common for both Rock960 and Ficus boards, so the board specific parts should go to rk3399-rock960.dts and rk3399-ficus.dts. Thanks, Mani [1] https://dl.vamrs.com/products/rock960/docs/hw/rock960_sch_v12_20180314.pdf > + }; > + > sdmmc { > sdmmc_bus1: sdmmc-bus1 { > rockchip,pins = > -- > 2.21.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel