From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9428CC04AB6 for ; Fri, 31 May 2019 15:57:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6666323AF8 for ; Fri, 31 May 2019 15:57:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SuiF6nI+"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="lMzx7007" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6666323AF8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+8rw3Jx7YmYC2oLQV8sIp249udB6q7zPZZ3lxmkn1lQ=; b=SuiF6nI+nOVWh7 9xafpp/eACtlLs9S21Q03KaJMOpy7+T5Z9csguDpgkyay0iYiEM2bJBCsng8GHUEotcw099JT/Onf aO0wUTbZ/fCR1sO7EvOD9ZL9hjc1Lz4oPZaBdozhRmWlbUJ+awJTBH3h+Xu79VqEyoULlrZWTT3Bc ZZzcnpnkMP5XDetcMq9qWDxDg2wernwE7Ou5Vj2uXVSar2CH5E6MJf4hAR1GcS3tsJ66j9Ka2pZQd cLxnQHMFRexH7/l8sTQ4F8oVr19iIj7mLS5yhx7V9IsCSugU+23NdtCoM/tudecs9BmoP/4gBJfvu tQl6MnhEpD61HDkpN+CA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWju6-0006Jf-DS; Fri, 31 May 2019 15:57:14 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWju2-0006Iy-82 for linux-arm-kernel@lists.infradead.org; Fri, 31 May 2019 15:57:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1qsXgMdZdZCVb0zGvBJg48inoUnxWB9wnqlIe6TKCKQ=; b=lMzx7007xbCUygcV/Kwz6yH5h pJYhIa7kqEoC8Rw1iqQw3xkJOSwAesHfalzwzBCi8y7A/9zGdvLks6XMBdMoCxpcIZ/MkHZhMWgAB JX5K+LbyeV5/uhWl3BShi2oZ/cnTfbzsHols4Q+n0888jF51iq9bCqOif3FboCBteN6zZnZ9ahfzN uV84PRibXhMiD7FLhG5VoedR1rTjvueaPF8MSngs1qWniJ+iogk5hfAvaq5Ng7EOXJmoC73nfBq4Z HDznL08UeMSuZLvIw1Oj+mgg+Mm1okBQzjokAa89kNYtAMeUYBvob8jPJd+Yo+XGrgNX5fQmdTz4Z qydNMxa1A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:52758) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hWjtx-0001gZ-3z; Fri, 31 May 2019 16:57:05 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.89) (envelope-from ) id 1hWjts-0006T6-L2; Fri, 31 May 2019 16:57:00 +0100 Date: Fri, 31 May 2019 16:57:00 +0100 From: Russell King - ARM Linux admin To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH] serial: sa1100: add note about modem control signals Message-ID: <20190531155700.crrawgf3iot2sm2t@shell.armlinux.org.uk> References: <20190531151032.tfrl7yqph6wsg5pl@pengutronix.de> <20190531153135.sboekptwx4jxlpeg@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190531153135.sboekptwx4jxlpeg@pengutronix.de> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190531_085710_286468_5D46F4D4 X-CRM114-Status: GOOD ( 16.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jiri Slaby Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 31, 2019 at 05:31:35PM +0200, Uwe Kleine-K=F6nig wrote: > Hello Russell, > = > On Fri, May 31, 2019 at 04:24:04PM +0100, Russell King wrote: > > As suggested by Uwe, add a note indicating that the modem control > > signals do not support interrupts, which precludes the driver from > > using mctrl_gpio_init(). > > = > > Suggested-by: Uwe Kleine-K=F6nig > > Signed-off-by: Russell King > > --- > > = > > Uwe, something like this? > > = > > drivers/tty/serial/sa1100.c | 3 +++ > > 1 file changed, 3 insertions(+) > > = > > diff --git a/drivers/tty/serial/sa1100.c b/drivers/tty/serial/sa1100.c > > index a6b4309b62fc..d7dbf0576be8 100644 > > --- a/drivers/tty/serial/sa1100.c > > +++ b/drivers/tty/serial/sa1100.c > > @@ -949,6 +949,9 @@ static int sa1100_serial_resume(struct platform_dev= ice *dev) > > static int sa1100_serial_add_one_port(struct sa1100_port *sport, struc= t platform_device *dev) > > { > > sport->port.dev =3D &dev->dev; > > + > > + // GPIO driver does not support interrupts for these modem > > + // control signals, so the serial driver polls them. > > sport->gpios =3D mctrl_gpio_init_noauto(sport->port.dev, 0); > > if (IS_ERR(sport->gpios)) { > > int err =3D PTR_ERR(sport->gpios); > = > I would mention that because of this mctrl_gpio_init cannot be used. Ok. > (And I would have expected C-like comments). It seems that Linus has changed his opinion on C99 commenting style, from "it's not real C" to "I prefer it": https://lore.kernel.org/patchwork/patch/852060/ Yes, this is mostly about the SPDX commenting style, but Linus seems to be expressing a general preference towards "//" style comments over "/* */" comments, especially for new comments. Specifically see replies #14 and #18, especially #18 where the discussion moves towards trailing-line comments for structure members. -- = RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps = up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel