From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A370BC04AB6 for ; Fri, 31 May 2019 16:32:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A60925B65 for ; Fri, 31 May 2019 16:32:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V9mDKC4O" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A60925B65 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H7tLfDSmBsEbSVkxfKAOHiJOD3JowgAJ4K3kBVxpboU=; b=V9mDKC4OhVLyLf +V9HM0QWL4hUVkpkfUK7jFW9f5MKpAMBOipgeqUlXI453lbA+1ntYwrrwqpLbsxQA8R0q80bFwjwX Cfawb0nFJ59qHuGQc7MYHnlPLsOuKtSq7cfZ9wOO7L6SK1DKrd1F79TOvci0E/j+7t1q+Aujv/2lz Eu6ng3Y7m9z36B/FMxSEdprqyWgJGrmpwjsnyXtSHDD+PSH+fznrdQ25+MsKqPcZzrWbufhK02cPz fl3hONtMnvyJEwpp1bSXK8/DpiMUvV6d2WOQN8U0eGnZDOgnLAeIUn9fnwku3YmHrUiOPK8ldhqIi bknATtHKIFq/rYdSas0g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWkSI-0003lG-2W; Fri, 31 May 2019 16:32:34 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWkSD-0003l4-C7; Fri, 31 May 2019 16:32:29 +0000 Date: Fri, 31 May 2019 09:32:29 -0700 From: Christoph Hellwig To: laurentiu.tudor@nxp.com Subject: Re: [PATCH v3 5/6] dpaa_eth: fix iova handling for contiguous frames Message-ID: <20190531163229.GA8708@infradead.org> References: <20190530141951.6704-1-laurentiu.tudor@nxp.com> <20190530141951.6704-6-laurentiu.tudor@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190530141951.6704-6-laurentiu.tudor@nxp.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: madalin.bucur@nxp.com, netdev@vger.kernel.org, roy.pledge@nxp.com, linux-kernel@vger.kernel.org, leoyang.li@nxp.com, Joakim.Tjernlund@infinera.com, iommu@lists.linux-foundation.org, camelia.groza@nxp.com, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 30, 2019 at 05:19:50PM +0300, laurentiu.tudor@nxp.com wrote: > +static phys_addr_t dpaa_iova_to_phys(const struct dpaa_priv *priv, > + dma_addr_t addr) > +{ > + return priv->domain ? iommu_iova_to_phys(priv->domain, addr) : addr; > +} Again, a driver using the iommu API must not call iommu_* APIs. This chane is not acceptable. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel