From: "George G. Davis" <george_davis@mentor.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Michal Marek <michal.lkml@markovi.net>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
open list <linux-kernel@vger.kernel.org>,
Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC][PATCH] Makefile: Fix checkstack.pl arm64 wrong or unknown architecture
Date: Fri, 31 May 2019 12:39:08 -0400 [thread overview]
Message-ID: <20190531163908.GB10644@mam-gdavis-lt> (raw)
In-Reply-To: <CAK7LNATXzLzttF_gLA4wdfE1ue+bLPhvDZVsTKbB5K3nrN3jng@mail.gmail.com>
Hello Masahiro,
On Sat, Jun 01, 2019 at 01:02:37AM +0900, Masahiro Yamada wrote:
> On Sat, Jun 1, 2019 at 12:27 AM George G. Davis <george_davis@mentor.com> wrote:
> >
> > The following error occurs for the `make ARCH=arm64 checkstack` case:
> >
> > aarch64-linux-gnu-objdump -d vmlinux $(find . -name '*.ko') | \
> > perl ./scripts/checkstack.pl arm64
> > wrong or unknown architecture "arm64"
> >
> > Fix the above error by setting `CHECKSTACK_ARCH := aarch64` for the
> > ARCH=arm64 case.
> >
> > Signed-off-by: George G. Davis <george_davis@mentor.com>
>
>
> Why don't you fix scripts/checkstack.pl ?
Like so?:
diff --git a/scripts/checkstack.pl b/scripts/checkstack.pl
index 122aef5e4e14..8502de57e2ef 100755
--- a/scripts/checkstack.pl
+++ b/scripts/checkstack.pl
@@ -41,6 +41,8 @@ my (@stack, $re, $dre, $x, $xs, $funcre);
if ($arch eq "") {
$arch = `uname -m`;
chomp($arch);
+ } elsif ($arch eq 'arm64') {
+ $arch = "aarch64";
}
$x = "[0-9a-f]"; # hex character
Thanks!
> > diff --git a/Makefile b/Makefile
> > index 11358153d8f2..3e615e8553c0 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1695,7 +1695,11 @@ PHONY += checkstack kernelrelease kernelversion image_name
> > ifeq ($(ARCH), um)
> > CHECKSTACK_ARCH := $(SUBARCH)
> > else
> > -CHECKSTACK_ARCH := $(ARCH)
> > + ifeq ($(ARCH), arm64)
> > + CHECKSTACK_ARCH := aarch64
> > + else
> > + CHECKSTACK_ARCH := $(ARCH)
> > + endif
> > endif
> > checkstack:
> > $(OBJDUMP) -d vmlinux $$(find . -name '*.ko') | \
> > --
> > 2.7.4
> >
>
>
> --
> Best Regards
> Masahiro Yamada
--
Regards,
George
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-31 16:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 15:26 [RFC][PATCH] Makefile: Fix checkstack.pl arm64 wrong or unknown architecture George G. Davis
2019-05-31 16:02 ` Masahiro Yamada
2019-05-31 16:39 ` George G. Davis [this message]
2019-05-31 17:22 ` Masahiro Yamada
2019-05-31 17:45 ` George G. Davis
2019-06-01 2:09 ` Masahiro Yamada
2019-06-03 14:34 ` George G. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531163908.GB10644@mam-gdavis-lt \
--to=george_davis@mentor.com \
--cc=apw@canonical.com \
--cc=catalin.marinas@arm.com \
--cc=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=will.deacon@arm.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox