From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0C8CC04AB6 for ; Fri, 31 May 2019 17:45:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8717F26D56 for ; Fri, 31 May 2019 17:45:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mez56xM3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8717F26D56 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mentor.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iHDsB57zF4dmwxu7tSAl/8fagGEcKSlsT/TwaXfMbTw=; b=mez56xM3BoCH52 NnJkg97dffvSSEhU4KRcLPiIPywFNifDhLYSCuBmIbS0Odt8suT9HAS/duZ8+RComNTbrvnpzjrVo dv7Qr4XxZTNuXg0EnbXuZpB1OxlWn8vGwTofWXQqkL1jYYpMuLJGyBcTRug342oZp+UfOjHHa3cLA OCEFQIihuDjw7AWahGFwXfg0J70kvMezvj+rXxQlGYvmxI8mNkywk4rRXntqCDGRq6rl+H1bG5VM6 n+R7z5t/bUvJbtnAhfg5dCGHQtBppxY7R0PQ+Uz9h4KoYQE3Wbi85yz2verPiaP9NgKAmtmFfM6VR B1PjOMgCFNcU+q3Fj2Ug==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWlan-0001f8-2C; Fri, 31 May 2019 17:45:25 +0000 Received: from relay1.mentorg.com ([192.94.38.131]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWlae-0001ZC-0V for linux-arm-kernel@lists.infradead.org; Fri, 31 May 2019 17:45:17 +0000 Received: from svr-orw-mbx-01.mgc.mentorg.com ([147.34.90.201]) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1hWlaY-00048y-04 from George_Davis@mentor.com ; Fri, 31 May 2019 10:45:10 -0700 Received: from localhost (147.34.91.1) by svr-orw-mbx-01.mgc.mentorg.com (147.34.90.201) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Fri, 31 May 2019 10:45:07 -0700 Date: Fri, 31 May 2019 13:45:06 -0400 From: "George G. Davis" To: Masahiro Yamada Subject: Re: [RFC][PATCH] Makefile: Fix checkstack.pl arm64 wrong or unknown architecture Message-ID: <20190531174506.GC10644@mam-gdavis-lt> References: <1559316388-19565-1-git-send-email-george_davis@mentor.com> <20190531163908.GB10644@mam-gdavis-lt> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-ClientProxiedBy: svr-orw-mbx-02.mgc.mentorg.com (147.34.90.202) To svr-orw-mbx-01.mgc.mentorg.com (147.34.90.201) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190531_104516_105782_514887D1 X-CRM114-Status: GOOD ( 16.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Marek , Linux Kbuild mailing list , Catalin Marinas , Will Deacon , open list , Joe Perches , Andy Whitcroft , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Masahiro, On Sat, Jun 01, 2019 at 02:22:36AM +0900, Masahiro Yamada wrote: // CUT > As far as I understood, checkstack.pl is supposed to > understand both ARCH= and 'uname -m'. > > > For example, the following commit supports x86, x86_64, i386, > by using regular expression. > > commit fda9f9903be6c3b590472c175c514b0834bb3c83 > Author: Konstantin Khlebnikov > Date: Fri Aug 8 14:23:35 2014 -0700 > > scripts/checkstack.pl: automatically handle 32-bit and 64-bit mode > for ARCH=x86 > > This patch adds support for ARCH=x86 into checkstack. > > > > Following this pattern, does this work for you? > > diff --git a/scripts/checkstack.pl b/scripts/checkstack.pl > index 122aef5e4e14..371bd17a4983 100755 > --- a/scripts/checkstack.pl > +++ b/scripts/checkstack.pl > @@ -46,7 +46,7 @@ my (@stack, $re, $dre, $x, $xs, $funcre); > $x = "[0-9a-f]"; # hex character > $xs = "[0-9a-f ]"; # hex character or space > $funcre = qr/^$x* <(.*)>:$/; > - if ($arch eq 'aarch64') { > + if ($arch =~ '^(aarch|arm)64$') { Yes, that works, thanks! Will you submit a fix or would you like me to resubmit with the above suggested fix? Thanks again! > #ffffffc0006325cc: a9bb7bfd stp x29, > x30, [sp, #-80]! > #a110: d11643ff sub sp, sp, #0x590 > $re = qr/^.*stp.*sp, \#-([0-9]{1,8})\]\!/o; > > > > -- > Best Regards > Masahiro Yamada -- Regards, George _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel