Re: [RFC][PATCH] Makefile: Fix checkstack.pl arm64 wrong or unknown architecture

George G. Davis
2019-05-31T16:39:23Z

Hello Masahiro,

On Sat, Jun 01, 2019 at 01:02:37AM +0900, Masahiro Yamada wrote:
> On Sat, Jun 1, 2019 at 12:27 AM George G. Davis <george_davis@mentor.com> wrote:
> >
> > The following error occurs for the `make ARCH=arm64 checkstack` case:
> >
> > aarch64-linux-gnu-objdump -d vmlinux $(find . -name '*.ko') | \
> > perl ./scripts/checkstack.pl arm64
> > wrong or unknown architecture "arm64"
> >
> > Fix the above error by setting `CHECKSTACK_ARCH := aarch64` for the
> > ARCH=arm64 case.
> >
> > Signed-off-by: George G. Davis <george_davis@mentor.com>
>
>
> Why don't you fix scripts/checkstack.pl ?

Like so?:

diff --git a/scripts/checkstack.pl b/scripts/checkstack.pl
index 122aef5e4e14..8502de57e2ef 100755
--- a/scripts/checkstack.pl
+++ b/scripts/checkstack.pl
@@ -41,6 +41,8 @@ my (@stack, $re, $dre, $x, $xs, $funcre);
if ($arch eq "") {
$arch = `uname -m`;
chomp($arch);
+ } elsif ($arch eq 'arm64') {
+ $arch = "aarch64";
}

$x = "[0-9a-f]"; # hex character

Thanks!

> > diff --git a/Makefile b/Makefile
> > index 11358153d8f2..3e615e8553c0 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1695,7 +1695,11 @@ PHONY += checkstack kernelrelease kernelversion image_name
> > ifeq ($(ARCH), um)
> > CHECKSTACK_ARCH := $(SUBARCH)
> > else
> > -CHECKSTACK_ARCH := $(ARCH)
> > + ifeq ($(ARCH), arm64)
> > + CHECKSTACK_ARCH := aarch64
> > + else
> > + CHECKSTACK_ARCH := $(ARCH)
> > + endif
> > endif
> > checkstack:
> > $(OBJDUMP) -d vmlinux $$(find . -name '*.ko') | \
> > --
> > 2.7.4
> >
>
>
> --
> Best Regards
> Masahiro Yamada

--
Regards,
George