Re: [RFC][PATCH] Makefile: Fix checkstack.pl arm64 wrong or unknown architecture

George G. Davis
2019-05-31T17:45:38Z

Hello Masahiro,

On Sat, Jun 01, 2019 at 02:22:36AM +0900, Masahiro Yamada wrote:

// CUT

> As far as I understood, checkstack.pl is supposed to
> understand both ARCH= and 'uname -m'.
>
>
> For example, the following commit supports x86, x86_64, i386,
> by using regular expression.
>
> commit fda9f9903be6c3b590472c175c514b0834bb3c83
> Author: Konstantin Khlebnikov <koct9i@gmail.com>
> Date: Fri Aug 8 14:23:35 2014 -0700
>
> scripts/checkstack.pl: automatically handle 32-bit and 64-bit mode
> for ARCH=x86
>
> This patch adds support for ARCH=x86 into checkstack.
>
>
>
> Following this pattern, does this work for you?
>
> diff --git a/scripts/checkstack.pl b/scripts/checkstack.pl
> index 122aef5e4e14..371bd17a4983 100755
> --- a/scripts/checkstack.pl
> +++ b/scripts/checkstack.pl
> @@ -46,7 +46,7 @@ my (@stack, $re, $dre, $x, $xs, $funcre);
> $x = "[0-9a-f]"; # hex character
> $xs = "[0-9a-f ]"; # hex character or space
> $funcre = qr/^$x* <(.*)>:$/;
> - if ($arch eq 'aarch64') {
> + if ($arch =~ '^(aarch|arm)64$') {

Yes, that works, thanks!

Will you submit a fix or would you like me to resubmit with the above suggested
fix?

Thanks again!

> #ffffffc0006325cc: a9bb7bfd stp x29,
> x30, [sp, #-80]!
> #a110: d11643ff sub sp, sp, #0x590
> $re = qr/^.*stp.*sp, \#-([0-9]{1,8})\]\!/o;
>
>
>
> --
> Best Regards
> Masahiro Yamada

--
Regards,
George