Re: [RFC][PATCH] Makefile: Fix checkstack.pl arm64 wrong or unknown architecture

Masahiro Yamada
2019-05-31T16:04:01Z

On Sat, Jun 1, 2019 at 12:27 AM George G. Davis <george_davis@mentor.com> wrote:
>
> The following error occurs for the `make ARCH=arm64 checkstack` case:
>
> aarch64-linux-gnu-objdump -d vmlinux $(find . -name '*.ko') | \
> perl ./scripts/checkstack.pl arm64
> wrong or unknown architecture "arm64"
>
> Fix the above error by setting `CHECKSTACK_ARCH := aarch64` for the
> ARCH=arm64 case.
>
> Signed-off-by: George G. Davis <george_davis@mentor.com>

Why don't you fix scripts/checkstack.pl ?

> ---
> Makefile | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 11358153d8f2..3e615e8553c0 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1695,7 +1695,11 @@ PHONY += checkstack kernelrelease kernelversion image_name
> ifeq ($(ARCH), um)
> CHECKSTACK_ARCH := $(SUBARCH)
> else
> -CHECKSTACK_ARCH := $(ARCH)
> + ifeq ($(ARCH), arm64)
> + CHECKSTACK_ARCH := aarch64
> + else
> + CHECKSTACK_ARCH := $(ARCH)
> + endif
> endif
> checkstack:
> $(OBJDUMP) -d vmlinux $$(find . -name '*.ko') | \
> --
> 2.7.4
>

--
Best Regards
Masahiro Yamada