From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DD71C04AB6 for ; Fri, 31 May 2019 18:32:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64E822231F for ; Fri, 31 May 2019 18:32:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PdVxxDZv"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pnA32Q//" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64E822231F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U+Tl7Gw06da0TcVQlALiYyUX36ccw6bf2P7vDOxrN1o=; b=PdVxxDZvW0z1xh C49oGnPQ7JJc0ywzAnzoqx4w6eU8p2P6MNwMUhaPV44HEIM1P5gKp1J5+oCbc9NgPiilGKTRVzq+P vmEfvL3oP9i4SPwSwL7t71nHsXycyMAtt2eqqnK1EuASFy20W79aRVs/MmWRbp4/aITXuJW0R1wbv D+ZgsvTLassInDc+UdFY+UX4KPDvc2hSltpxH+g1lgTM9rgxtxmCTzrHT7mAZG2+dvphlqwd9TzWg ybdT4b79qVAwRbAxRIuQOT3MsBGR1YJpp5Ch8V2zTnLUrQOF8QpLUZQdkHfcXFrVNxrHDefdPjazA KymZ14S1Z6M4PhBPFHSw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWmKS-0004l1-7s; Fri, 31 May 2019 18:32:36 +0000 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWmKO-0004kC-O5 for linux-arm-kernel@lists.infradead.org; Fri, 31 May 2019 18:32:34 +0000 Received: by mail-ed1-x544.google.com with SMTP id a8so15909792edx.3 for ; Fri, 31 May 2019 11:32:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/qCEAxJby+Q3JZ8llKzwy+sZNSav6qCCM0ocEIgzH0k=; b=pnA32Q//XASMsJVTAIORwQ21Lho5quheH7a5SypaIQCMLMIGfEoFksi/ihA7ieW7oW 0k2RRAe8q6vYgDPEe9tILYVo2DQ17b2LlwcGJ4Z2KokwZlydXvUaQ4jlSRyQsUf5qWtf BgR8MOc3fktLlLPSQz4/QtCmnYQc0IZAx1EI5CCqgDIpT5DiMGImyQaLU5Tugy8pCta4 6mTeWQBBi5vm10k9BzI/xPMw/sV32PS7rBtcjVDxC+pM94/USalh2aDx9kPucMWBKsDn vYE2L1T8UAUjMXP5KyfJOvizbZ2vnogz3af3NAdB8nYpGXxKuh9tD6fzhmQcGysydUXi c6lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/qCEAxJby+Q3JZ8llKzwy+sZNSav6qCCM0ocEIgzH0k=; b=bff1GUbQ28swPbUCHgWDUdVlvPAjH9hekMn2Is7n2nRfYu/Fi0p30yeSxKmTADlles PE/Lk1H60pi5gTvnS0nFN9KThqEOUYUwS/RS0ehWD7V6/zxoUIdELDShH8OfXYwVCsrz CfIUZJkzVvtOgXl0apCHz1Him+LqmnuSq9UgJbV5kG5bivSqCUYXvVxS66pIIp4P/dOd LPD+gw7C2ucEoj+ig6vCAhWOcUwISlDBsOmu7ixAa1MgXByeBXLy2Pzs+wK3Zc3ZzCOY 4wy0qL0n2zXgI4AkSsj3cGofPb3bxs83ebAkv44GpNErI2BTnKbpGC1KF+y6ZghgvstH rl9Q== X-Gm-Message-State: APjAAAWCApTiRXCZdvi+eDihuPC8TqH1RTAdkztSBXVxVjkX/X9f+ExZ KY0dkEj05mssmPrg3qFFSR0= X-Google-Smtp-Source: APXvYqxfLxURqU5ciVrR3TSIjSt8BDjYXtDZo/7u98PKRRpTcl7yXsUg4F/tkPwh30o1QhOS6CWM4g== X-Received: by 2002:a17:906:265b:: with SMTP id i27mr10809987ejc.147.1559327550493; Fri, 31 May 2019 11:32:30 -0700 (PDT) Received: from archlinux-epyc ([2a01:4f9:2b:2b15::2]) by smtp.gmail.com with ESMTPSA id n8sm1111182ejk.45.2019.05.31.11.32.29 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 31 May 2019 11:32:29 -0700 (PDT) Date: Fri, 31 May 2019 11:32:27 -0700 From: Nathan Chancellor To: Arnd Bergmann Subject: Re: [PATCH] ARM: xor-neon: Replace __GNUC__ checks with CONFIG_CC_IS_GCC Message-ID: <20190531183227.GA34102@archlinux-epyc> References: <20190528235742.105510-1-natechancellor@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190531_113232_778464_2C2BFEE7 X-CRM114-Status: GOOD ( 13.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ard Biesheuvel , Nicolas Pitre , Nick Desaulniers , Linux Kernel Mailing List , Stefan Agner , Russell King , clang-built-linux , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 31, 2019 at 10:05:22AM +0200, Arnd Bergmann wrote: > If I remember correctly, we also had the same issue with older versions > of clang, possibly even newer ones. Shouldn't we check for a minimum > compiler version when building with clang to ensure that the code is > really vectorized? > > Arnd Even on tip of tree, it doesn't look like vectorization happens properly. With -S -Rpass-missed='.*' added to the xor-neon.c command: /home/nathan/cbl/linux-next/include/asm-generic/xor.h:15:2: remark: the cost-model indicates that interleaving is not beneficial [-Rpass-missed=loop-vectorize] /home/nathan/cbl/linux-next/include/asm-generic/xor.h:11:1: remark: List vectorization was possible but not beneficial with cost 0 >= 0 [-Rpass-missed=slp-vectorizer] xor_8regs_2(unsigned long bytes, unsigned long *p1, unsigned long *p2) ^ So right now, it doesn't look like there is a minimum version for clang and I don't think adding a warning for clang is productive (what is a user supposed to do?) Cheers, Nathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel