From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBBFFC04AB6 for ; Fri, 31 May 2019 20:26:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B056926EEC for ; Fri, 31 May 2019 20:26:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="C9DvNv1M"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xv43EpmE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B056926EEC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VKm+txD2a8vXZkm54WAEkq853mxwrD277YIOcDzAv/E=; b=C9DvNv1MAJwf2N Ir821pBxosGDI+OAlZs8Gwfx2uLIt1vXwiyMubQh0ZCUGfS6EJS2Ux2QONsB0ohplTy1DKK1fjASs pXIhYBm0P0YphJXejfNkiPE8nykmCp+fRvPOB+O6Kbt/gI2BQhrte3i/R1PhyXNTg5WxyzSt9/iOp LY+Un4swzTD72/2IdbcOyHa17rdyeumirUE4uo8td7c1sUKHkSBr4wcNluDdB1DlY3KpNNKZt1NBz i2pXVOgU3oJu5SQdjfWthCaLX2DiQqVkTfiHaCIr8z8Mz9wCjYcoaYBMJ85GjJiAJT9nly+2eYWN6 E0sQvgcdXp7jeda/1mNw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWo6R-00083k-5W; Fri, 31 May 2019 20:26:15 +0000 Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWo6O-00082q-7W for linux-arm-kernel@lists.infradead.org; Fri, 31 May 2019 20:26:13 +0000 Received: by mail-ed1-x543.google.com with SMTP id f20so16281259edt.12 for ; Fri, 31 May 2019 13:26:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Gkdrhj+L2y9Un3DqIxCBN2IczH3NAgr/P0YLMvWGg3k=; b=Xv43EpmEIYCOnqrcH6IC1jp47hvR8jTZmpsuMilbWt6IoPWH1ceBQLdNcwW1Ar1Tfc BaL/lNspAs5IRQaUY2ITsepMDgaj4bX36mXu8JbEV2gn5MfxqziePZ1goCdh5rxF2xRA ephcT0SA8NIjA9rlqzcqsDfFXVSRJ4VndZuCK5rnmo2R7Pa8KPARwxESCUxVSjFOQ1bw nn6Bxa61HWZ7m7UPLW9L54TSAB8QXfwRo79eIgjevEGPWCKOOxgF3+WGb9v93fCtZ3wH 8Y6Ye6iZTLO/yFY9AUWH/B6+RJj7c9Q/h8j3uw1AQaxu4kNzFkHkNhvxFovkT2M13MWh GCLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Gkdrhj+L2y9Un3DqIxCBN2IczH3NAgr/P0YLMvWGg3k=; b=PM773bjdgT6EhTU7Q+me4fh5e3woKKy2w8LaiJm7QEm65iEs4eKLs9BVTSDniDgN0B sUmt4TF9bgx7pCxFDBhXrjogoqkBT0Sd2gAvb8xQ4oMjRsgzVGrDyR0IdA6xHqh9p3EA 65ZE0gHDdhpzsSlZ/eMJpuGirD/Htcn4a8JUWexo3wdSZnS8JRof8x6/VGruY1G50eQw lifcNeqdDRsUeCHKaq+ECG0VeUf8Bt9YSNkf08aGIm62Wn06vAae+Ow8+1IpFzbQl2F7 1kSjM84ccKMApxrtU9Eie/JGPFi1NghxFRIV3HLCW6JnCVtU6+2QEUPdjEgjafxMny3q OTMQ== X-Gm-Message-State: APjAAAXy45NejIRbX0nFBebE9tieqOsOaXSzRqJu4cnlOa/KDTDef3bK 7bJyiqpN0s6O0K8pEV++tqGZcTO6m4Izsg== X-Google-Smtp-Source: APXvYqxixZFEj5U32gsuL97OYf945hk0gTpmJ868WJqXPlesOklKj4GB4h8NEuJIo6Ibi7k6Kx9AYA== X-Received: by 2002:a17:906:a94c:: with SMTP id hh12mr11415070ejb.143.1559334368623; Fri, 31 May 2019 13:26:08 -0700 (PDT) Received: from archlinux-epyc ([2a01:4f9:2b:2b15::2]) by smtp.gmail.com with ESMTPSA id i45sm1892124eda.67.2019.05.31.13.26.07 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 31 May 2019 13:26:07 -0700 (PDT) Date: Fri, 31 May 2019 13:26:05 -0700 From: Nathan Chancellor To: Nick Desaulniers Subject: Re: [PATCH] ARM: xor-neon: Replace __GNUC__ checks with CONFIG_CC_IS_GCC Message-ID: <20190531202605.GA78113@archlinux-epyc> References: <20190528235742.105510-1-natechancellor@gmail.com> <20190531183227.GA34102@archlinux-epyc> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190531_132612_297847_54F96343 X-CRM114-Status: GOOD ( 15.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Nicolas Pitre , Ard Biesheuvel , Linux Kernel Mailing List , Stefan Agner , Russell King , clang-built-linux , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 31, 2019 at 01:06:13PM -0700, Nick Desaulniers wrote: > On Fri, May 31, 2019 at 12:21 PM Arnd Bergmann wrote: > > clang, I would suggest dropping your patch then, and instead adding > > I disagree. The minimum version of gcc required to build the kernel > is 4.6, so the comment about older versions of gcc is irrelevant and > should be removed. > > Nathan's -Rpass warnings are warning that vectorization was not > calculated to be profitable **for 1 of the 4 functions** by LLVM. > Surely we wouldn't disable NEON opts for XOR because 1 of 4 was not > vectorized? Well I kept it short but clang warns that all of the loops are not profitable. However, the config option for xor-neon.c is CONFIG_XOR_BLOCKS, which also controls the arm64 implementation. We wouldn't want to disable it for clang altogether if it works on arm64 fine. If it turns out to be broken for both, I suppose I would be okay with disabling CONFIG_XOR_BLOCKS for clang but it should be done in a separate patch as this one should be applied regardless of clang working or not (because this warning will appear again when clang is fixed). Cheers, Nathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel