From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAC5DC04AB6 for ; Sat, 1 Jun 2019 00:29:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 897262708F for ; Sat, 1 Jun 2019 00:29:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rmwH7nGU"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g7AQ2p/R" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 897262708F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LnYkbaI1nOpGLrB+cXz54Vqhr8VewBVap/cYx1GztIA=; b=rmwH7nGUI6COnB OxB2X9ZoawhyPQ7caV58daQU6K6herAP0yHIkR4VLtH8GTYkdsb2xI7iRcWBTZzCJ/f6umpDKa1/+ PIgrABAnEDcV4r5zwNl0B2V5r/z5Dl3h01HHGJ8d47iEljuCBH7560te+qTdp7atNlE+Ww0pfpN4P a4b6J7N9YBUu7R03iZfS+lHcG/wT1AOZi4UU82WpvdWjk0wO5RaJt9lBbxJXCtgqsvL/GYaMyCg7V 2GvK6dwDqpoO9aNEdaQF6QFB9XTCO3C/W+sRhnpAgTsiub47eIQ1d25brvA54R2S3Rcl8grV0oStd mHiIDPCNJXPkrlUOLGbg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWrtT-0008AU-KW; Sat, 01 Jun 2019 00:29:07 +0000 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWrtQ-00089n-Mt for linux-arm-kernel@lists.infradead.org; Sat, 01 Jun 2019 00:29:06 +0000 Received: by mail-ed1-x542.google.com with SMTP id w37so17102864edw.4 for ; Fri, 31 May 2019 17:29:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JNA+M2HNg5wC58bq9MZMCh6YyzsCVe0fiW59+AoI+uk=; b=g7AQ2p/RBhEEwukGt++EPQDzHYe3xAanZFkwZbDE2W/aOJnnVSHjYYJyumy9E3fGIK MOYIQP5P9hNJ/8I6BMNJauiYurLi7++SWUKkh10Q0nWDqa9uayZhElnX4el7hGmqoNvQ U7uDj2Hrst9GJYcVKnfWPPlSLGRmh66qyJC8yFR3EgO6/8uK/fwbLtw2klXXCQaeRD8/ cAOBe+wMbSvjmTJrdxom7WKJ/rNw/wJEXVVro9JNLuP15MDMgzMFcESSm4cOTSUSbSKn h8IjqqdAea5IqczJoAirb11KMsrKfU/IZIVZODIfcvwgHHbdNwEoNCf5v/lUFY04XvUp O2sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JNA+M2HNg5wC58bq9MZMCh6YyzsCVe0fiW59+AoI+uk=; b=SGVn1VLQa11n5OVvNiS8qzdYUajbPEHUg8OgDKv9x+4YhBkVT4CE6o5HEEUr/ul5AF ru4ZchGSjv2gtBHDhOg1RiiGmyBcmgOn+dUMcYuh0apJ18FDQOo7pjAZ8tznoiTi30Ec 7RA4qa+e5DOn2vNk30mTbLMp3Dj7HFsXFyC+qUJSooZ39KJYwYMTmVluFvZ3NNGpD3fN wPnJu/3VjizZG0RLtNXo0b7UkTLglo5w703JQiwza+41QVS7GJZNNAX3cXMPrwUAslGr D4ITdUG9XqYkVb9zY5BDaIPp2NS7eGq77Lqd1DWeZliSucwybC6BJtOVFADk3qRUE/77 JCrw== X-Gm-Message-State: APjAAAVbgfVtmQj32hbphm531FsPpeqE2isIyIyyPQDzjv9Wjeyzv24i G/0aRB/JK5WqS35m4ElhimQ= X-Google-Smtp-Source: APXvYqyjHBP6Ky2mspUst454rSxki3hW4y23rkcxYomBYUoZjYnk+QD/AlcwIriW+0mzpinwEfLa/w== X-Received: by 2002:a50:bb24:: with SMTP id y33mr14611589ede.116.1559348940661; Fri, 31 May 2019 17:29:00 -0700 (PDT) Received: from archlinux-epyc ([2a01:4f9:2b:2b15::2]) by smtp.gmail.com with ESMTPSA id h20sm1244729eja.37.2019.05.31.17.28.59 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 31 May 2019 17:29:00 -0700 (PDT) Date: Fri, 31 May 2019 17:28:58 -0700 From: Nathan Chancellor To: Arnd Bergmann Subject: Re: [PATCH] ARM: xor-neon: Replace __GNUC__ checks with CONFIG_CC_IS_GCC Message-ID: <20190601002858.GA89184@archlinux-epyc> References: <20190528235742.105510-1-natechancellor@gmail.com> <20190531183227.GA34102@archlinux-epyc> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190531_172904_774939_BD7EE104 X-CRM114-Status: GOOD ( 18.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Pitre , Ard Biesheuvel , Nick Desaulniers , Linux Kernel Mailing List , Stefan Agner , Russell King , clang-built-linux , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 31, 2019 at 11:03:19PM +0200, Arnd Bergmann wrote: > On Fri, May 31, 2019 at 10:06 PM 'Nick Desaulniers' via Clang Built > Linux wrote: > > > > On Fri, May 31, 2019 at 12:21 PM Arnd Bergmann wrote: > > > clang, I would suggest dropping your patch then, and instead adding > > > > I disagree. The minimum version of gcc required to build the kernel > > is 4.6, so the comment about older versions of gcc is irrelevant and > > should be removed. > > Sure, that's ok. It just feels wrong to remove a warning that points > to a real problem that still exists and can be detected at the moment. > > If we think that clang-9 is going to be fixed before its release, > the warning could be changed to test for that version as a minimum, > and point to the bugzilla entry for more details. > > Arnd I just tested the arm64 implementation and it shows the same warnings about cost as arm. However, I see a warning as something that can be resolved by the user. The GCC warning's solution is to just use a newer version of GCC (something fairly easily attainable). This new warning currently has no solution other than don't use clang. It is up to you and Nick but I would say unless we are going to prioritize fixing this, we shouldn't add a warning for it. I'd say it is more appropriate to fix it then add a warning saying upgrade to this version to fix it, like the GCC one (though I don't necessarily hate adding the warning assuming that clang 9 will have it fixed). Cheers, Nathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel