From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02072C04AB6 for ; Mon, 3 Jun 2019 09:06:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB74E27DF5 for ; Mon, 3 Jun 2019 09:06:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CfrPEElj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB74E27DF5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kvYGbJ2YM8Rwg2GGBfqi34KavrvEf9IbSX9AEX9OzxA=; b=CfrPEElj9jfyqz X/VQG4pa53wuheRkAL81v0vqDFrNYWaB/veo3D0PKQruh7hyBIGuM7DaiQdBKPwN+T+32rPIvcX1+ F0u2rvscQt+Dxc+o8mcRds6oBsRbBEY935xidOsrRO+UH3YnwQzHi5EtD8K6SQ85Lj8p/v2fu4cK0 +sDI5s8VT/A2wy3cuSll74XAJ9co1+EnfdyfKLgd5ELEPr/BgndeffF43WaIQbGyfb2MIIuIJsvEy aog51itWnga+APqvgGeWECjAc3Mt2pkWl2TckjZ69RF4Vol7obDrChNn/gYl57HY8rcZle6nDpMow CdOcQoN2lIx1qLg1rs8A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hXiuj-000618-Vz; Mon, 03 Jun 2019 09:05:58 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hXiud-0005pI-OT; Mon, 03 Jun 2019 09:05:54 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6AB3B374; Mon, 3 Jun 2019 02:05:49 -0700 (PDT) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2C69F3F690; Mon, 3 Jun 2019 02:05:45 -0700 (PDT) Date: Mon, 3 Jun 2019 10:05:31 +0100 From: Sudeep Holla To: Atish Patra Subject: Re: [PATCH v6 2/7] dt-binding: cpu-topology: Move cpu-map to a common binding. Message-ID: <20190603090531.GA26487@e107155-lin> References: <20190529211340.17087-1-atish.patra@wdc.com> <20190529211340.17087-3-atish.patra@wdc.com> <0515d803-0da5-dcbe-3d3e-bb786b320d8b@arm.com> <28118149-193d-2a8a-995a-2f1829e95c1c@wdc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <28118149-193d-2a8a-995a-2f1829e95c1c@wdc.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190603_020552_608460_7CDD7EFF X-CRM114-Status: GOOD ( 22.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "Rafael J. Wysocki" , "Peter Zijlstra \(Intel\)" , Catalin Marinas , Linus Walleij , Palmer Dabbelt , Will Deacon , Mauro Carvalho Chehab , "linux-riscv@lists.infradead.org" , Ingo Molnar , Rob Herring , Anup Patel , Russell King , Morten Rasmussen , "devicetree@vger.kernel.org" , Albert Ou , Rob Herring , Paul Walmsley , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Jeremy Linton , Otto Sabart , Sudeep Holla , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 03, 2019 at 01:49:13AM -0700, Atish Patra wrote: > On 5/30/19 1:55 PM, Jeremy Linton wrote: > > Hi, > > > > On 5/29/19 4:13 PM, Atish Patra wrote: > > > cpu-map binding can be used to described cpu topology for both > > > RISC-V & ARM. It makes more sense to move the binding to document > > > to a common place. > > > > > > The relevant discussion can be found here. > > > https://lkml.org/lkml/2018/11/6/19 > > > > > > Signed-off-by: Atish Patra > > > Reviewed-by: Sudeep Holla > > > Reviewed-by: Rob Herring > > > --- > > > .../topology.txt => cpu/cpu-topology.txt} | 82 +++++++++++++++---- > > > 1 file changed, 66 insertions(+), 16 deletions(-) > > > rename Documentation/devicetree/bindings/{arm/topology.txt => cpu/cpu-topology.txt} (86%) > > > [...] > > > > > > While socket is optional, its probably a good idea to include the node > > in the example even if the result is the same. > > Sure. I will update that. > > That is because at least > > on arm64 the DT clusters=sockets decision had performance implications > > for larger systems. > > > > Assuring the socket information is correct is helpful by itself to avoid > > having to explain why a single socket machine is displaying some other > > value in lscpu. > > > Just for my understanding, can you give a example? > That's simple. Today any ARM{32,64} DT based platform sets their cluster id to physical package id, which is exposed to userspace. The userspace can/must interpret that as multi-socket system. E.g. TC2/Juno which 2 clusters show up as 2 socket systems which is wrong and needs fixing. We have fixed it for ARM64 ACPI based systems but for DT(mostly used in mobile/embedded) we need to make sure we don't break anything else before we fix it. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel