From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8CAEC282CE for ; Tue, 4 Jun 2019 10:03:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD40624B8B for ; Tue, 4 Jun 2019 10:03:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BEJCT9Bp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD40624B8B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z0CfP0txAH0uA9+HARIyEbbhOlw7qxBC4HTsbf2EZS4=; b=BEJCT9BpghN5mE XKKNff6TTWDOvW2r2FyNhpV2S0ODEpFYxYrkSG4AY/0Y03K15HCGM4ntqXk20+Oe+/cqeYFRMlXBO MaFR3QQxnGO0sWipNZgFluyCU0Wca4kH3Mvc1LJw77qRweBlyLURCdd3uLlsaFXH5hzKnC2AtBMRs VxsYN+TUn9wNWIjTR7N4yaRQWAjerhXrqAEhXemTFYWYKnCxKYIYJbK9UmMd9GmfZbKVa85wsJBhN 0d3IwWfKID5qeHdGD/LmOrTy+kHAoQtQkvLGBhZpgCBLXYY3pnjhVk5zslN5ECrhXcgZg4IbybM2M qHb95URG2Xbb83W+MCOA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hY6Hf-0002CX-1m; Tue, 04 Jun 2019 10:03:11 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hY6Hc-0002C4-3w for linux-arm-kernel@lists.infradead.org; Tue, 04 Jun 2019 10:03:09 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7867615A2; Tue, 4 Jun 2019 03:03:06 -0700 (PDT) Received: from e103592.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A79573F246; Tue, 4 Jun 2019 03:03:04 -0700 (PDT) Date: Tue, 4 Jun 2019 11:03:02 +0100 From: Dave Martin To: Kristina Martsenko Subject: Re: [RFC v2 5/7] arm64: initialize and switch ptrauth kernel keys Message-ID: <20190604100301.GX28398@e103592.cambridge.arm.com> References: <20190529190332.29753-1-kristina.martsenko@arm.com> <20190529190332.29753-6-kristina.martsenko@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190529190332.29753-6-kristina.martsenko@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190604_030308_165800_6DFAB4A7 X-CRM114-Status: GOOD ( 16.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Suzuki K Poulose , Catalin Marinas , Ard Biesheuvel , Will Deacon , Ramana Radhakrishnan , Amit Kachhap , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 29, 2019 at 08:03:30PM +0100, Kristina Martsenko wrote: > Set up keys to use pointer authentication within the kernel. The kernel > will be compiled with APIAKey instructions, the other keys are currently > unused. Each task is given its own APIAKey, which is initialized during > fork. The key is changed during context switch and on kernel entry from > EL0. > > A function that changes the key cannot return, so compile such functions > without pointer auth (using __no_ptrauth which will be defined to a > compiler function attribute later). > > Signed-off-by: Kristina Martsenko > --- [...] > diff --git a/arch/arm64/include/asm/pointer_auth.h b/arch/arm64/include/asm/pointer_auth.h > index a97b7dc10bdb..79f35f5ecff5 100644 > --- a/arch/arm64/include/asm/pointer_auth.h > +++ b/arch/arm64/include/asm/pointer_auth.h > @@ -25,10 +25,6 @@ struct ptrauth_key { > unsigned long lo, hi; > }; > > -/* > - * We give each process its own keys, which are shared by all threads. The keys > - * are inherited upon fork(), and reinitialised upon exec*(). > - */ > struct ptrauth_keys { > struct ptrauth_key apia; > struct ptrauth_key apib; > @@ -37,16 +33,18 @@ struct ptrauth_keys { > struct ptrauth_key apga; > }; Do we need all this struct for the kernel thread case? It may be a bit pointless trying to optimise this, though. [...] Cheers ---Dave _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel