From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 034ADC282CE for ; Tue, 4 Jun 2019 12:36:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB5282231F for ; Tue, 4 Jun 2019 12:36:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gzR1Blyt"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="sL71fl8k" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB5282231F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/UNJtcXLaUydIX2wxPqoP3GcWizABDun0rjKQ0yFyxo=; b=gzR1BlythOmQGb pPwOXG9l78ylFF+Qunhgd3/T9tX9BELr3zltexvNj/4QGhZ2xuzpsWQCTQc/FjwcCRZK2F3H488g3 KHrvIfPt7WjzULhjm9wov27fQjlZucxddb8RNIxJIosPrKoLyDcwr783l7Sr9jUuOl0gfVFIJUUJS jSkU/CH9aNJIX0N3J99YtOeIwDRhIcvNx77McMEa0kTcJpX/U9m7mYq0xT/aB/7dgxVds4AZekLge HNGFqrg8R0VAAdVbtyB7LfoZgWpnvR7N2I5rHo6wO0tpokMkfCMP6TXponkIBuT1mWr4oHxsQuaQB wHnsMf8zgIl1Zsju6tWA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hY8gE-0002U6-Lc; Tue, 04 Jun 2019 12:36:42 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hY8gB-0002T0-Vw for linux-arm-kernel@lists.infradead.org; Tue, 04 Jun 2019 12:36:41 +0000 Received: from localhost (unknown [117.99.94.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D25C52231F; Tue, 4 Jun 2019 12:36:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559651799; bh=6OleqzP9quO2zeSwzsj8bZMeC8Hf2G1MKsJM7hbM2y8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sL71fl8ksf2Ja1HmqStkjNNeRgC7UL/xPDVK/wp7YJZkONHwjxdusA5XmNr9iQnHA CPnGDlVR4TZRrq9zl16yEt13Z0/3Kl035kY7Ipn6UGuSrr5bTvLzkbrE9x2QIXqbiL YxbXRHqG6DcMl7mNpHZRpPIhA1VPbU0b0bh/0aTI= Date: Tue, 4 Jun 2019 18:03:31 +0530 From: Vinod Koul To: yibin.gong@nxp.com Subject: Re: [PATCH v3 5/8] dmaengine: fsl-edma: add drvdata for vf610 Message-ID: <20190604123331.GE15118@vkoul-mobl> References: <20190529090848.34350-1-yibin.gong@nxp.com> <20190529090848.34350-6-yibin.gong@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190529090848.34350-6-yibin.gong@nxp.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190604_053640_045776_BA3A5248 X-CRM114-Status: UNSURE ( 8.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, robh@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, dmaengine@vger.kernel.org, dan.j.williams@intel.com, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 29-05-19, 17:08, yibin.gong@nxp.com wrote: > @@ -205,8 +228,9 @@ static int fsl_edma_probe(struct platform_device *pdev) > if (!fsl_edma) > return -ENOMEM; > > - fsl_edma->version = v1; > - fsl_edma->dmamux_nr = DMAMUX_NR; > + fsl_edma->drvdata = drvdata; > + fsl_edma->version = drvdata->version; > + fsl_edma->dmamux_nr = drvdata->dmamuxs; And can we avoid the duplication here, you have version and dmamuxs represented in two places. But right now it looks logical so the removal should be done after this series -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel