From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_ADSP_DISCARD,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EE23C282CE for ; Tue, 4 Jun 2019 16:22:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 61AD923CCA for ; Tue, 4 Jun 2019 16:22:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hAZTy718"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=megous.com header.i=@megous.com header.b="gg+XXo5Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61AD923CCA Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=megous.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1QxLctWHFGjn6ckO2XZhflSp0WIGEk0apyL/Df25BlI=; b=hAZTy718cl3iRO OO3uDRSMvdnbFY26L88rb7UXDtuuMlzMgluRTF9rRQckwU+TI6dmXbI8JCCjZFmPXEbaP/5VfqlRE +QygMt+fPGTmS7eYniA1/CRjAY4V4CcXLHrsHiIIVtCS13rGHnN89azUNOQKJSQsiB/scMuF73Enf voHUjueH4BWMzbZhju55UrjdhyGw6tZmAKsIRP3Yg5ZmMczRLe767FD9KHCskHbQVXPgh5pQUboPS YQ607aFz0A9lcoTX5L8y6gNfo7ppU+Oou7Md60qMh9rpFka4rXztW/o0635DnEBg6jE8gubkifM4P IVFR6UQ0jjQsiVzMVaqA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYCC8-00027u-Sd; Tue, 04 Jun 2019 16:21:52 +0000 Received: from vps.xff.cz ([195.181.215.36]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYCC5-000277-3x for linux-arm-kernel@lists.infradead.org; Tue, 04 Jun 2019 16:21:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1559665305; bh=qm5r7h8IIEdRL40O9VMAH9oDefKlLBdaHOgDq3xcAx4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gg+XXo5YGTIbCkKbpbL3v8FG0/Jel8Q4iepzwyWg0wYkRjoNxyYP0/4SxXfYhN2yH So04IwaJWADhd4PF9Ku/DQaA0uhU4TggtAkiHQvYXkgOb+zXVTzxsFa5xy2Acgzwf2 GpteETgWrKs2aV143FMJGHL+6CqDtmNnO5TXleg8= Date: Tue, 4 Jun 2019 18:21:44 +0200 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= Subject: Re: [linux-sunxi] [PATCH v2] clk: sunxi-ng: sun50i-h6-r: Fix incorrect W1 clock gate register Message-ID: <20190604162144.hba5bmkdnidco7pf@core.my.home> Mail-Followup-To: =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= , linux-sunxi , Maxime Ripard , Chen-Yu Tsai , Michael Turquette , Stephen Boyd , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:COMMON CLK FRAMEWORK" , open list References: <20190604154036.23211-1-megous@megous.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190604_092149_661006_A7B568CD X-CRM114-Status: GOOD ( 23.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , Michael Turquette , Chen-Yu Tsai , open list , Stephen Boyd , linux-sunxi , "open list:COMMON CLK FRAMEWORK" , "moderated list:ARM/Allwinner sunXi SoC support" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Cl=E9ment, On Tue, Jun 04, 2019 at 06:14:15PM +0200, Cl=E9ment P=E9ron wrote: > Hi Ondrej, > = > On Tue, 4 Jun 2019 at 17:40, megous via linux-sunxi > wrote: > > > > From: Ondrej Jirman > > > > The current code defines W1 clock gate to be at 0x1cc, overlaying it > > with the IR gate. > > > > Clock gate for r-apb1-w1 is at 0x1ec. This fixes issues with IR receiver > > causing interrupt floods on H6 (because interrupt flags can't be cleare= d, > > due to IR module's bus being disabled). > > > > Signed-off-by: Ondrej Jirman > > Fixes: b7c7b05065aa77ae ("clk: sunxi-ng: add support for H6 PRCM CCU") > > --- > > drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c b/drivers/clk/sunxi= -ng/ccu-sun50i-h6-r.c > > index 27554eaf6929..8d05d4f1f8a1 100644 > > --- a/drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c > > +++ b/drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c > > @@ -104,7 +104,7 @@ static SUNXI_CCU_GATE(r_apb2_i2c_clk, "r-apb2= -i2c", "r-apb2", > > static SUNXI_CCU_GATE(r_apb1_ir_clk, "r-apb1-ir", "r-apb1", > > 0x1cc, BIT(0), 0); > > static SUNXI_CCU_GATE(r_apb1_w1_clk, "r-apb1-w1", "r-apb1", > > - 0x1cc, BIT(0), 0); > > + 0x1ec, BIT(0), 0); > Just for information where did you find this information? > Using the vendor kernel or user manual? Informed guess. All gates and resets are in the same register. And you can see below that reset register for w1 is 0x1ec. (reset register for ir is 0x1cc) regards, o. > Thanks, > Cl=E9ment > = > > > > /* Information of IR(RX) mod clock is gathered from BSP source code */ > > static const char * const r_mod0_default_parents[] =3D { "osc32k", "os= c24M" }; > > -- > > 2.21.0 > > > > -- > > You received this message because you are subscribed to the Google Grou= ps "linux-sunxi" group. > > To unsubscribe from this group and stop receiving emails from it, send = an email to linux-sunxi+unsubscribe@googlegroups.com. > > To view this discussion on the web, visit https://groups.google.com/d/m= sgid/linux-sunxi/20190604154036.23211-1-megous%40megous.com. > > For more options, visit https://groups.google.com/d/optout. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel