From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B62BCC282DE for ; Wed, 5 Jun 2019 07:34:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CC0E2075C for ; Wed, 5 Jun 2019 07:34:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RjR3Bdkq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CC0E2075C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6whXtW0ni8EUW0FspbI311nVz6eutlDnRXgKLIX8t/8=; b=RjR3Bdkqk8Ti5w o6PdaQgJMfD9P7Tnf5E2IqnGTHAIlMhBezZnTk6/MP7qPzcqdeQG+SWbfIdjfI1JQ5WQz8JDZMjkz lNY2QhMIWYr6TvAtgP89j9d+JKBJ26QnluqHH2P+tPYPei0bqEJ5EsK4iw/JW6OstNgxSC8XBzzz3 FH4XfzkeBjp6UNPux1meLGWntq+jj/idNV7K/kwnYqouQfK9VOzco77urldoF2q3gbc59DZtnwBK3 hAPxWfHvvN7cE2Rb1IHDrt5w2EGA95ONTT5fFtB7DOxGHEUl1f4m0JRPoSgzKIFuqGDL5cC9Imzrx Vsk0dF0uhgnJmGbKvIPg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYQR6-0003vB-0o; Wed, 05 Jun 2019 07:34:16 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYQR3-0003si-M0 for linux-arm-kernel@lists.infradead.org; Wed, 05 Jun 2019 07:34:15 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 14F59A78; Wed, 5 Jun 2019 00:34:11 -0700 (PDT) Received: from mbp (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1EF683F246; Wed, 5 Jun 2019 00:34:09 -0700 (PDT) Date: Wed, 5 Jun 2019 08:34:07 +0100 From: Catalin Marinas To: Masahiro Yamada Subject: Re: [PATCH 0/2] Allow assembly code to use BIT(), GENMASK(), etc. and clean-up arm64 header Message-ID: <20190605073406.geesp3rbrxajmac6@mbp> References: <20190527083412.26651-1-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190527083412.26651-1-yamada.masahiro@socionext.com> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190605_003413_770486_09F24CE3 X-CRM114-Status: GOOD ( 13.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 27, 2019 at 05:34:10PM +0900, Masahiro Yamada wrote: > Some in-kernel headers use _BITUL() instead of BIT(). > > arch/arm64/include/asm/sysreg.h > arch/s390/include/asm/*.h > > I think the reason is because BIT() is currently not available > in assembly. It hard-codes 1UL, which is not available in assembly. [...] > Masahiro Yamada (2): > linux/bits.h: make BIT(), GENMASK(), and friends available in assembly > arm64: replace _BITUL() with BIT() > > arch/arm64/include/asm/sysreg.h | 82 ++++++++++++++++----------------- > include/linux/bits.h | 17 ++++--- I'm not sure it's worth the hassle. It's nice to have the same BIT macro but a quick grep shows arc, arm64, s390 and x86 using _BITUL. Maybe a tree-wide clean-up would be more appropriate. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel