From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AF88C28CC6 for ; Wed, 5 Jun 2019 07:57:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E80F92083E for ; Wed, 5 Jun 2019 07:57:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZH1NvKC6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E80F92083E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iltWMvEHRXuUxLKSEBmNM3i61/hnUG+cwntYhlBi17U=; b=ZH1NvKC6PkrbcD 5nZBOvZ/340ehGtIxJbzLSBu66mHwC/Vx7QScofdqNxN1/WzMENgXMntJLkCZUMeMJuE+1eBal2Ry Q/cxWG9IGUAm7Lw7EfEAFea1T6RCtkvDXdsigNaMIBfm2O6Chc9Jq5Mne4bD6k6F6rg0JenU1tCEM cu8Uu4wK7Rr6gSzDigtBceuOJI+yK4PAFRQrU+y3LiWd1HmFJxWoRUU8oyfX01s5KvBmFfv6HK7IY 0D65727wW62nTEg523Qk0iMOD7VnVvAW/Fiut4N/Jp9shmtIcF+zVSc2p1WdV8HJ/bzM76JsAM13q /iULIZI6IjmVjrTtdwtg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYQnE-00056y-S7; Wed, 05 Jun 2019 07:57:08 +0000 Received: from mail-lf1-f65.google.com ([209.85.167.65]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYQn8-0004zQ-FK for linux-arm-kernel@lists.infradead.org; Wed, 05 Jun 2019 07:57:04 +0000 Received: by mail-lf1-f65.google.com with SMTP id y198so7882172lfa.1 for ; Wed, 05 Jun 2019 00:57:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BIGkKcYfLrKZMcNofxFte/MwlnM+iUUU8rGg0Es0KCI=; b=rqYNtw2aGKc3+9OD5UmQa78jlsNjSC3nf79VrW61Hw3I1jPe4yez7rWIypkqXezm8Z 4SPehEcYoWLdq2G+ln9yQhlr35fEvWd7AqdX5+3blE08QunkXjTtA1cUEr/jSTuojfBj URvQJn8K0+lxROXWn5U7rxXH0O6wf0bWVxRDenEZUlpFdGFdSh8Xcm7q6erP+8NdJYc4 yIQhqgVDMDkyc7mAIbuAGq5WTHO7A7g94zoCPRUURj5zqYJhMotClKPwnkDo9soFMYU7 6CpzEwDQ6pMJtaiii6hVwDHdQLWexcv2Dq3bf3Mp3GuGCPmtomm9e5Oi/O10hk6vMpbo pDSg== X-Gm-Message-State: APjAAAVRVYNtF7ZjD6qvptpJMWocgePzr3tCVg4yIfW/Q9dZhXYicR/F xImkhgnTQyhFzUio79+OF71McUB2hPw= X-Google-Smtp-Source: APXvYqyJTHFtU2ZPnYiQSPpENJAgbw8I3+7lh4a0s29uA2IVhDFXd/5pYXop0LCfMkGc18+7XLWDyw== X-Received: by 2002:a19:6a01:: with SMTP id u1mr17636778lfu.141.1559721419930; Wed, 05 Jun 2019 00:56:59 -0700 (PDT) Received: from xi.terra (c-74bee655.07-184-6d6c6d4.bbcust.telenor.se. [85.230.190.116]) by smtp.gmail.com with ESMTPSA id t22sm4189527lje.58.2019.06.05.00.56.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Jun 2019 00:56:59 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.91) (envelope-from ) id 1hYQn2-00063e-Gt; Wed, 05 Jun 2019 09:56:57 +0200 Date: Wed, 5 Jun 2019 09:56:56 +0200 From: Johan Hovold To: Lee Jones Subject: Re: [PATCH 2/8] i2c: i2c-qcom-geni: Signify successful driver probe Message-ID: <20190605075656.GC29637@localhost> References: <20190604104455.8877-1-lee.jones@linaro.org> <20190604104455.8877-2-lee.jones@linaro.org> <20190605062020.GL22737@tuxbook-pro> <20190605071625.GK4797@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190605071625.GK4797@dell> User-Agent: Mutt/1.12.0 (2019-05-25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190605_005702_507574_200EBD49 X-CRM114-Status: GOOD ( 23.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: balbi@kernel.org, david.brown@linaro.org, gregkh@linuxfoundation.org, linus.walleij@linaro.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , wsa+renesas@sang-engineering.com, alokc@codeaurora.org, kramasub@codeaurora.org, linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, andy.gross@linaro.org, jlhugo@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 05, 2019 at 08:16:25AM +0100, Lee Jones wrote: > On Tue, 04 Jun 2019, Bjorn Andersson wrote: > > > On Tue 04 Jun 03:44 PDT 2019, Lee Jones wrote: > > > > > The Qualcomm Geni I2C driver currently probes silently which can be > > > confusing when debugging potential issues. Add a low level (INFO) > > > print when each I2C controller is successfully initially set-up. > > > > > > Signed-off-by: Lee Jones > > > --- > > > drivers/i2c/busses/i2c-qcom-geni.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c > > > index 0fa93b448e8d..e27466d77767 100644 > > > --- a/drivers/i2c/busses/i2c-qcom-geni.c > > > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > > > @@ -598,6 +598,8 @@ static int geni_i2c_probe(struct platform_device *pdev) > > > return ret; > > > } > > > > > > + dev_info(&pdev->dev, "Geni-I2C adaptor successfully added\n"); > > > + > > > > I would prefer that we do not add such prints, as it would be to accept > > the downstream behaviour of spamming the log to the point where no one > > will ever look through it. > > We should be able to find a middle ground. Spamming the log with all > sorts of device specific information/debug is obviously not > constructive, but a single liner to advertise that an important > device/controller has been successfully initialised is more helpful > than it is hinderous. > > This print was added due to the silent initialisation costing me > several hours of debugging ACPI device/driver code (albeit learning a > lot about ACPI as I go) just to find out that it was already doing the > right thing - just very quietly. No, we don't add noise like this to the logs just because it may be useful while debugging. Even one-liners add up. There are plenty of options for debugging already ranging from adding a temporary dev_info() to the probe function in question to using dynamic debugging to have driver core log every successful probe. And in this case you say the driver was in fact already bound; that can easily be verified through sysfs too in case things aren't behaving the way you expect. Johan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel