From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E44F2C282DE for ; Wed, 5 Jun 2019 08:34:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA6192075B for ; Wed, 5 Jun 2019 08:34:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="r06gIxAZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA6192075B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BbshbgkfmwTSqzdBZ6uRsOp+f/HuMlSgGTvbfIGhSc4=; b=r06gIxAZVxn0vV d3dsgP6GHKJk0L2cmJk5d6xs2VhZ95oRisbtf6Lp56ud6OhSocX/fwjM/0fUMJIIF1lGgsUh0em6A pZsEf+AABeIam/DOf0mJHKfbF1ZSCy5bL0qGwzQ+E5aral0YwAbJU5g4WPy/HTE89SgFS4hSWKuqs rlAfteZ73DrnYi/Gtv1U4Fgk99cVk1U/IZy3y1IaPUhaK+HGS+SYXyN3phm5NrV862VMm36X5YwV5 /UWCfc9Y/wcRDPiPiyXsg42Bvv/5l5t/2YrTjh+9eUYuLiliR4BGwMf0s4FYzeC+anUZwpvOHF4Ml OfRSKpNhUlifPT/tFY3g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYRNC-0001xF-HS; Wed, 05 Jun 2019 08:34:18 +0000 Received: from mail-lf1-f66.google.com ([209.85.167.66]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYRMs-0001Sh-Fc for linux-arm-kernel@lists.infradead.org; Wed, 05 Jun 2019 08:34:15 +0000 Received: by mail-lf1-f66.google.com with SMTP id 136so6900155lfa.8 for ; Wed, 05 Jun 2019 01:33:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Q9tx+jcvIT26cZO2scmHbp4TeAN9yH+3bSlg5LwUoqc=; b=LPz/JAAyuSetsr0yJSL6ZgoAMuZqpfabcIo8cMO1P7SUezqM6+MMc3vWg5zV9oNUlq UJjUuwWEiO+NMuDoQ2T4Hj93Gr9Xyu07X1eFRZPB3HpR+ToTGcoCtfD1uY4fqeNsveTs 5OIeMB9E9aA8pTL81zSPcso3oGU7Kavp0g2wO2iF333ndSyrlYxNRvL2iSUViyiBacfR uYiZBKyODf0lXHRqh//BoCyAzlBjXIHLLsp25l7RhmSLfJAi1TtLdAeeawm5RpDNi5wU +y+ER5t27SBvq7or8B8AGD/1x6qMJX28p7AU22Qq3X+A+dzsfVG7+AxhlqhqC8d2cP6Q 2Ydg== X-Gm-Message-State: APjAAAUYqudCZtma8sAJ5dppquFKyQ7O0eNDVn2EspMRaEQaRyJfdgwM gcreO2m6fcibhNkD6Bg1HVo= X-Google-Smtp-Source: APXvYqwtR8QAunhSjQP25Svspbkpa9nCnvW6tu0Kw7GQYZ2RLBSBlFAZRWmfA/bitG0hHGnEsRD1Tw== X-Received: by 2002:a19:f806:: with SMTP id a6mr15693187lff.102.1559723636153; Wed, 05 Jun 2019 01:33:56 -0700 (PDT) Received: from xi.terra (c-74bee655.07-184-6d6c6d4.bbcust.telenor.se. [85.230.190.116]) by smtp.gmail.com with ESMTPSA id q2sm1856972lfj.25.2019.06.05.01.33.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Jun 2019 01:33:55 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.91) (envelope-from ) id 1hYRMn-0006Ie-H7; Wed, 05 Jun 2019 10:33:53 +0200 Date: Wed, 5 Jun 2019 10:33:53 +0200 From: Johan Hovold To: Lee Jones Subject: Re: [PATCH 2/8] i2c: i2c-qcom-geni: Signify successful driver probe Message-ID: <20190605083353.GD29637@localhost> References: <20190604104455.8877-1-lee.jones@linaro.org> <20190604104455.8877-2-lee.jones@linaro.org> <20190605062020.GL22737@tuxbook-pro> <20190605071625.GK4797@dell> <20190605075656.GC29637@localhost> <20190605082047.GM4797@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190605082047.GM4797@dell> User-Agent: Mutt/1.12.0 (2019-05-25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190605_013359_171614_16481E6D X-CRM114-Status: GOOD ( 16.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, balbi@kernel.org, david.brown@linaro.org, gregkh@linuxfoundation.org, linus.walleij@linaro.org, linux-usb@vger.kernel.org, Johan Hovold , Bjorn Andersson , wsa+renesas@sang-engineering.com, alokc@codeaurora.org, kramasub@codeaurora.org, linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, andy.gross@linaro.org, jlhugo@gmail.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 05, 2019 at 09:20:47AM +0100, Lee Jones wrote: > On Wed, 05 Jun 2019, Johan Hovold wrote: > > No, we don't add noise like this to the logs just because it may be > > useful while debugging. Even one-liners add up. > > One line per device is should not cause an issue. > > Problems occur when developers try to print all kinds of device > specifics to the boot log. A simple, single line for such an > important device/controller has more benefits than drawbacks. What about the thousands of probe functions which do not currently spam the logs? If you want to see all successful probes reliably, you tell driver core to print it. > > There are plenty of options for debugging already ranging from adding a > > temporary dev_info() to the probe function in question to using dynamic > > debugging to have driver core log every successful probe. > > This is what I ended up doing. It was time consuming to parse though > a log of that size when you have no paging or keyboard. With the right command-line option to enable dynamic debugging you get one line per successful probe, just like you wanted. Or are you now saying that one-line per device is too much after all? ;) > > And in this case you say the driver was in fact already bound; that can > > easily be verified through sysfs too in case things aren't behaving the > > way you expect. > > Not in a non-booting system with no keyboard you can't. ;) Fair enough, but the above would still work. Johan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel