From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6EDBC28CC5 for ; Wed, 5 Jun 2019 11:02:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDCCB206BA for ; Wed, 5 Jun 2019 11:02:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="audHfbjt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDCCB206BA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k03IgypzLOOq/ZTkLNKDGpSZkV/8ZShy2ecZS6dNxjs=; b=audHfbjtGPH2jB kp/QbIYWc4hMt/6pHkDAjLmm6XZAdZv2Gudwujgx29PcoL/qwi8z7l7ee1kFzYAN7xpjDbQ07+Cyt 5zM6ta6TS7JD7PDreuZXqQatKV0ImNgU6JXOM8WWUHlvO3/bb6hAA4e0VrjrmIk6opjqU+fubAAlX ETGVWj6pwiA1N3+mznFRifvbFDoqRbLTY0y81I9StYib0cBup1YG63D+n5pYi+GJC4M6TV8RzR84v h5lo3DxOUnK5/i18SvP15ld3f0+emoZdnRYG2mcBQu67HRLPS4dMYEWNB/GUaHL0zPtJz3bYY74CB O/sQH7R82TP30QF9jEGA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYTgn-0005Aa-8j; Wed, 05 Jun 2019 11:02:41 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYTgj-00059T-T6 for linux-arm-kernel@lists.infradead.org; Wed, 05 Jun 2019 11:02:39 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4A58E374; Wed, 5 Jun 2019 04:02:37 -0700 (PDT) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BD2F63F690; Wed, 5 Jun 2019 04:02:34 -0700 (PDT) Date: Wed, 5 Jun 2019 12:02:32 +0100 From: Sudeep Holla To: Mark Rutland Subject: Re: [PATCH 2/3] arm64: export acpi_psci_use_hvc Message-ID: <20190605110232.GB20813@e107155-lin> References: <20190604203100.15050-1-alisaidi@amazon.com> <20190604203100.15050-3-alisaidi@amazon.com> <20190605094031.GB28613@e107155-lin> <20190605103840.GA30925@lakrids.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190605103840.GA30925@lakrids.cambridge.arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190605_040237_941461_6CF6EB0E X-CRM114-Status: GOOD ( 21.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sudeep Holla , Herbert Xu , Arnd Bergmann , Greg Kroah-Hartman , Benjamin Herrenschmidt , Matt Mackall , Will Deacon , linux-kernel@vger.kernel.org, Ron Rindjunsky , Ali Saidi , Catalin Marinas , David Woodhouse , linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 05, 2019 at 11:38:40AM +0100, Mark Rutland wrote: > On Wed, Jun 05, 2019 at 10:40:31AM +0100, Sudeep Holla wrote: > > On Tue, Jun 04, 2019 at 08:30:59PM +0000, Ali Saidi wrote: > > > Allow a module that wants to make SMC calls to detect if it should be > > > using smc or hvc. > > > > > > Signed-off-by: Ali Saidi > > > --- > > > arch/arm64/kernel/acpi.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c > > > index 803f0494dd3e..ea41c6541d3c 100644 > > > --- a/arch/arm64/kernel/acpi.c > > > +++ b/arch/arm64/kernel/acpi.c > > > @@ -119,6 +119,7 @@ bool acpi_psci_use_hvc(void) > > > { > > > return acpi_gbl_FADT.arm_boot_flags & ACPI_FADT_PSCI_USE_HVC; > > > } > > > +EXPORT_SYMBOL_GPL(acpi_psci_use_hvc); > > > > > > > I would rather have this in drivers/firmware/psci/psci.c checking the > > value of psci_ops.conduit so that it's not just ACPI specific and can > > be used on DT platforms too if required. > > I'd also like this to not hook into PSCI internals. This code cares > about SMCCC, not PSCI. We also really shouldn't need to spread the > conduit management everywhere, too. I agree. I remember suggesting the same to Xilinx a while ago but I didn't see your patches in the mainline. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel