From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 648DCC28CC5 for ; Wed, 5 Jun 2019 21:21:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35F0C2075B for ; Wed, 5 Jun 2019 21:21:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VUYjejQb"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HtLdXNwl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35F0C2075B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version: References:Message-ID:Subject:To:From:Date:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vDyw2RcFZAuD2jpY/dsQeQPHtHT3ToSHlc+aBhkm4RA=; b=VUYjejQbgGclh3 JuLpqQPTjg5TTTa3J7RaiK6lFUim+ozWnyxBDp25A59WSPWYVgMw1WpA3JPeFHhJP4UO10850gF1L StldjK25JYgVdGI9WmRPGJPAj+YCRG1uKcibQsTcPtHhHpnOPr0Xkjc4BEXQ3HKxy0OuK3N9oia3Z BcTLCBuB7PwaoVLxx84qCeiFa5Bko7gdDev1brJdOsonAWknSjhM3yTr1EfcPUOkE1zidk/YnN1Qs zwR75PvwasvW/B0Ed3llvqLz1tQ5POIp3DHQuYPQycmHC6vA9b3RYhtcU6R/wdj6dFfXuiaKSqEIs utddxScCHBazh3K6w/ug==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYdLi-0000Lc-7F; Wed, 05 Jun 2019 21:21:34 +0000 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYdLe-0000JE-Qj for linux-arm-kernel@lists.infradead.org; Wed, 05 Jun 2019 21:21:32 +0000 Received: by mail-ed1-x542.google.com with SMTP id f20so7711128edt.12 for ; Wed, 05 Jun 2019 14:21:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jmqIL302FliKztrku23iEbel/vN8Om9KZr4KoJVUQBs=; b=HtLdXNwlPpU1RFxmpHZq/rH78NiFyUbMRNR4XLHGl5DFaciTYXzczF+YOEaOthAltb LzfrkniAfXeG9XfS8k8l9WWdWJTCb5t0Qydwrx9HDSWfQxVverG9o6eBxNShll611+Xk D8MDiZNeQ9S8YaEkKYI92ohNxvxiKGjBgdANYmGfcUxcUcAmDq0kOuCUWCUGDd+d7T8p u6tdGt0M3uFblUt67ApuYvpm2psLcK1H66EYwESimtXZEx5o8tKBJ+DBxrVlRNPstQNp 2xk+bEsv5+yigah3/6Lj+npsGt7LKO/9d2Bkh2IRQhSgPxae7KCEIl0WkMOEkno6k2FP 1Lng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=jmqIL302FliKztrku23iEbel/vN8Om9KZr4KoJVUQBs=; b=e9EXUqsza3le+HAgTGBBjbnO+zW0TfAs5VFiGbpiAmePj5f+9Dl9JB1lKoTA2IIo6G 0Y4QEpPpjKNKRnFCfucgXXpHJP9ElfAlZYbWMTDpAjHUDMndiEM+9NJ/psSzjxiwgE0K LOnw2MJPW8lsOCb7UX6VwFDln65pXuHvnixDdERDliSNMAcOvnRrk/xQkOteJsns114V 0BT7W4i/O7BdUHqUjGrlhKoYFAOl4up1DUunaQZrCzmQW2cRM91Ig0vPG7jKXrxqji6P ldxpRPY/7j4mDujrWYpn/ZJz5NoaMAIwqlftFBmqUEvg/7/21abAselCRaDxsbaocNUk NlBQ== X-Gm-Message-State: APjAAAVKyNfvAeThkpRA6edfUSar/UvAX6/5SSzeGYIKBG540OMJ26rF +OwRwHPvASHXPyj5MuomJuI= X-Google-Smtp-Source: APXvYqxldygk3PkHMpihOlAqhwTjzhXRQF4Z9tCxVu286QjlehnozfaHCkEEtI5NYMQPFpu5SuYeWg== X-Received: by 2002:a50:ca48:: with SMTP id e8mr45737760edi.101.1559769687081; Wed, 05 Jun 2019 14:21:27 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id e19sm3550413edy.36.2019.06.05.14.21.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Jun 2019 14:21:26 -0700 (PDT) Date: Wed, 5 Jun 2019 21:21:25 +0000 From: Wei Yang To: David Hildenbrand Subject: Re: [PATCH v3 11/11] mm/memory_hotplug: Remove "zone" parameter from sparse_remove_one_section Message-ID: <20190605212125.gwmvjjicylhp3wcz@master> References: <20190527111152.16324-1-david@redhat.com> <20190527111152.16324-12-david@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190527111152.16324-12-david@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190605_142130_869279_07D15104 X-CRM114-Status: GOOD ( 12.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Wei Yang Cc: linux-s390@vger.kernel.org, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, Wei Yang , linux-mm@kvack.org, Igor Mammedov , akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org, Dan Williams , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 27, 2019 at 01:11:52PM +0200, David Hildenbrand wrote: >The parameter is unused, so let's drop it. Memory removal paths should >never care about zones. This is the job of memory offlining and will >require more refactorings. > >Reviewed-by: Dan Williams >Signed-off-by: David Hildenbrand Reviewed-by: Wei Yang >--- > include/linux/memory_hotplug.h | 2 +- > mm/memory_hotplug.c | 2 +- > mm/sparse.c | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h >index 2f1f87e13baa..1a4257c5f74c 100644 >--- a/include/linux/memory_hotplug.h >+++ b/include/linux/memory_hotplug.h >@@ -346,7 +346,7 @@ extern void move_pfn_range_to_zone(struct zone *zone, unsigned long start_pfn, > extern bool is_memblock_offlined(struct memory_block *mem); > extern int sparse_add_one_section(int nid, unsigned long start_pfn, > struct vmem_altmap *altmap); >-extern void sparse_remove_one_section(struct zone *zone, struct mem_section *ms, >+extern void sparse_remove_one_section(struct mem_section *ms, > unsigned long map_offset, struct vmem_altmap *altmap); > extern struct page *sparse_decode_mem_map(unsigned long coded_mem_map, > unsigned long pnum); >diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >index 82136c5b4c5f..e48ec7b9dee2 100644 >--- a/mm/memory_hotplug.c >+++ b/mm/memory_hotplug.c >@@ -524,7 +524,7 @@ static void __remove_section(struct zone *zone, struct mem_section *ms, > start_pfn = section_nr_to_pfn((unsigned long)scn_nr); > __remove_zone(zone, start_pfn); > >- sparse_remove_one_section(zone, ms, map_offset, altmap); >+ sparse_remove_one_section(ms, map_offset, altmap); > } > > /** >diff --git a/mm/sparse.c b/mm/sparse.c >index d1d5e05f5b8d..1552c855d62a 100644 >--- a/mm/sparse.c >+++ b/mm/sparse.c >@@ -800,8 +800,8 @@ static void free_section_usemap(struct page *memmap, unsigned long *usemap, > free_map_bootmem(memmap); > } > >-void sparse_remove_one_section(struct zone *zone, struct mem_section *ms, >- unsigned long map_offset, struct vmem_altmap *altmap) >+void sparse_remove_one_section(struct mem_section *ms, unsigned long map_offset, >+ struct vmem_altmap *altmap) > { > struct page *memmap = NULL; > unsigned long *usemap = NULL; >-- >2.20.1 -- Wei Yang Help you, Help me _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel