From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4581C28EB3 for ; Thu, 6 Jun 2019 17:05:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE5FF20868 for ; Thu, 6 Jun 2019 17:05:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cs4BamSO"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="LJouhF83" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE5FF20868 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:From:Subject:To: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Bdn49hw92XKDk1Q6VCTOeenE9wl22RlpRvKRwuBbUGM=; b=cs4BamSOsVC5ru pmdIdjfsbp8ED7Sw11ukWYBmyfFwFI+ok3s3R/0mpRHQYDDFutVsAcOj1EiOdrzkQ8HS0IdO4aDyx wuPUq18e/QBgd/V9ujJE+4q92KYUOwFFFu0rr2nG1qwfoNgrC1DxCEzEouceQo/PMoN2dv7YQNBZ3 ytSjxYvQoDBuF6cevHM+G73JVs3rTWkdoL0gsLn7drPqrO+02peb6GA0UNhA6D2OOIxqcHwLx+RMj j/V6i/ao6miuAF7gDC8dkhZ9WAalbTyPll9rsOQ/k4wGRUF15pBJaVBaQmDFNt3gnr0Gku/PWT6dF s1p/zuLP1Oc1AQ4LdbLg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYvp7-0002Sw-9H; Thu, 06 Jun 2019 17:05:09 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYvp3-00025E-L8; Thu, 06 Jun 2019 17:05:06 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 39C5B20693; Thu, 6 Jun 2019 17:05:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559840705; bh=uHOnF18rQ1x4hUh7PQwXCuloLsMPslXGMYzeeFg/e18=; h=In-Reply-To:References:To:Subject:From:Cc:Date:From; b=LJouhF834bm0oyjp4K3HMzEfmeO/CynTLHON+s66xYLMS9rlFer55d4RIjFRsHe0h sKukE1s08fJcwj3HnI+19EmuFXk7pOcCRuTS5VjlCZQhSB64usa6fFp9BL+hN4jdCs OtnljmrrtAcwblV5a0vLj2vb6pEVb4Bf3VNMrNAA= MIME-Version: 1.0 In-Reply-To: <20190606142255.29454-6-nsaenzjulienne@suse.de> References: <20190606142255.29454-1-nsaenzjulienne@suse.de> <20190606142255.29454-6-nsaenzjulienne@suse.de> To: Nicolas Saenz Julienne , linux-kernel@vger.kernel.org, stefan.wahren@i2se.com Subject: Re: [PATCH v2 5/7] clk: raspberrypi: register platform device for raspberrypi-cpufreq From: Stephen Boyd User-Agent: alot/0.8.1 Date: Thu, 06 Jun 2019 10:05:04 -0700 Message-Id: <20190606170505.39C5B20693@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190606_100505_717493_129E0F0C X-CRM114-Status: UNSURE ( 9.27 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, f.fainelli@gmail.com, ptesarik@suse.com, viresh.kumar@linaro.org, mturquette@baylibre.com, linux-pm@vger.kernel.org, rjw@rjwysocki.net, eric@anholt.net, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Nicolas Saenz Julienne , linux-clk@vger.kernel.org, mbrugger@suse.de, ssuloev@orpaltech.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Nicolas Saenz Julienne (2019-06-06 07:22:58) > diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c > index b1365cf19f3a..052296b5fbe4 100644 > --- a/drivers/clk/bcm/clk-raspberrypi.c > +++ b/drivers/clk/bcm/clk-raspberrypi.c > @@ -63,6 +63,8 @@ struct raspberrypi_firmware_prop { > __le32 disable_turbo; > } __packed; > > +static struct platform_device *rpi_cpufreq; Why can't this be stored in platform driver data? > + > static int raspberrypi_clock_property(struct rpi_firmware *firmware, u32 tag, > u32 clk, u32 *val) > { > @@ -285,6 +287,17 @@ static int raspberrypi_clk_probe(struct platform_device *pdev) > return ret; > } > > + rpi_cpufreq = platform_device_register_data(dev, "raspberrypi-cpufreq", > + -1, NULL, 0); > + > + return 0; > +} > + > +static int raspberrypi_clk_remove(struct platform_device *pdev) > +{ > + platform_device_unregister(rpi_cpufreq); > + rpi_cpufreq = NULL; This assignment to NULL looks unnecessary. > + > return 0; > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel