From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DE39C04AB5 for ; Thu, 6 Jun 2019 17:21:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 45B682083E for ; Thu, 6 Jun 2019 17:21:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="McXwTuBS"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="VXzwjZh3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45B682083E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:From:Subject:To: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2MWbXMvLDl4I4t4nxbEvCA89ItC2vAt+r2BIRNbBhCo=; b=McXwTuBSNnjSsd wi2SBW9RNG672N130omqAzpOh7+gy24bmEv+37eM3bAH8D6Hp4L1fJnyMIgbzqa9PAWOR+OLW/my0 ZFXUIIMH7ryPYnUUq9TMe13pFIeCfgwVq5AUIY0lrLnfLqtno4V4LmhmVs4rvnH1DLXe+JM6t/jzp zZTENea7XMNtzmU49D8dEqny3Ls0TrJv0kMbA/5NTg9VePsmMBWesscvIbcXX7a4EpvsBPjNV3Lqy GB3GXtVvP9QgVf5oe5XwyUUgb9DssYo2m/90+pefCWqHzdsBfX6/9+k+MroByDWBF/SXHrClA4Mxp Dah2+PJHt5LLEGrv9t6A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYw4P-0008Lz-5P; Thu, 06 Jun 2019 17:20:57 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYw4M-0008LT-9f; Thu, 06 Jun 2019 17:20:55 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C82E42083E; Thu, 6 Jun 2019 17:20:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559841653; bh=6YEYS2jdADr9Oq/g9NGffgzEuz06f2gVd4Lh8QYw1TU=; h=In-Reply-To:References:To:Subject:From:Cc:Date:From; b=VXzwjZh3p8VZPRX7PnXTwCco6S3FNWuYLO+sKtg5HELRMD6B9ePLckxb34uA2Cdf1 E4h9AF7o7xvUfaf15aGV0oFVFX1Jn2Y9f99Ts1r8xIDiC7zJ0rX+eQ7RRT4EEmnlQC TLG6b1DoufRctlYPm6z9bbwhRwD2UcJiehne1uwM= MIME-Version: 1.0 In-Reply-To: <2dd0a516bbfe6150112ec7dc5f7d4d85cbe3cd03.camel@suse.de> References: <20190606142255.29454-1-nsaenzjulienne@suse.de> <20190606142255.29454-6-nsaenzjulienne@suse.de> <20190606170505.39C5B20693@mail.kernel.org> <2dd0a516bbfe6150112ec7dc5f7d4d85cbe3cd03.camel@suse.de> To: Nicolas Saenz Julienne , linux-kernel@vger.kernel.org, stefan.wahren@i2se.com Subject: Re: [PATCH v2 5/7] clk: raspberrypi: register platform device for raspberrypi-cpufreq From: Stephen Boyd User-Agent: alot/0.8.1 Date: Thu, 06 Jun 2019 10:20:52 -0700 Message-Id: <20190606172053.C82E42083E@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190606_102054_351447_F79FE06B X-CRM114-Status: GOOD ( 10.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: f.fainelli@gmail.com, linux-pm@vger.kernel.org, viresh.kumar@linaro.org, mturquette@baylibre.com, ptesarik@suse.com, rjw@rjwysocki.net, mbrugger@suse.de, eric@anholt.net, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ssuloev@orpaltech.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Nicolas Saenz Julienne (2019-06-06 10:16:56) > On Thu, 2019-06-06 at 10:05 -0700, Stephen Boyd wrote: > > Quoting Nicolas Saenz Julienne (2019-06-06 07:22:58) > > > diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk- > > > raspberrypi.c > > > index b1365cf19f3a..052296b5fbe4 100644 > > > --- a/drivers/clk/bcm/clk-raspberrypi.c > > > +++ b/drivers/clk/bcm/clk-raspberrypi.c > > > @@ -63,6 +63,8 @@ struct raspberrypi_firmware_prop { > > > __le32 disable_turbo; > > > } __packed; > > > > > > +static struct platform_device *rpi_cpufreq; > > > > Why can't this be stored in platform driver data? > > It actually could, I just followed the same pattern as the code found in patch > #3. I'll update it in the next version if you prefer it. > Yes please. It reduces global state. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel