From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 526B6C04AB5 for ; Thu, 6 Jun 2019 17:36:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 303F02083D for ; Thu, 6 Jun 2019 17:36:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RQjXQM/6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="BwVfvF8v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 303F02083D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:From:Subject:To: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XwkhLXG37B7g8YVfPUtWloCeShvPyQAKw1KLHg/ChgU=; b=RQjXQM/6a30hTI rCkIhykygXlGZwJzDetVTyVhKWKYfIseXNJ2MxffX+lc8UmOnrUvoTFUMDSau06Wgq6wyhpxc7M9W PUGQGiMJjPjZIUn0XS3sfPQ3ZssYicqapWREV55iT17ONRHwG7xplzuydN6cVUzY94GTpY5dxDZYX g520wqeclVX/jN/WH1SH+PVmSPol1kPVgA6wdxjnrb4z8Hqg5xCvcZHnjfugDMlS8VYL7/E4zxOuo gYiScuIOJmybQlgolKTrF1pEnKjRmutueWSNZjfyhlT1bAj+FJpi3lY4ni14S4k5klEPFuf9DeH5S h/Liw5DD9otUfmV6NkHA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYwJA-0005pv-LN; Thu, 06 Jun 2019 17:36:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYwJ7-0005pR-QQ; Thu, 06 Jun 2019 17:36:11 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2C3952083D; Thu, 6 Jun 2019 17:36:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559842569; bh=pdq8qWIQe2AXVUfwDoQAl3L/f1GBHM2CtgEayvOOJOg=; h=In-Reply-To:References:To:Subject:From:Cc:Date:From; b=BwVfvF8v2Q979AL6mVsnn+nE3xjQrUjwkRimjqFEJhiFbEf8SR2T9nCVGTybohqdR AOoYSR0emcwc0BLcR1DkGl8wBOGZukuLZfVlGmkot+thcQ2z546O2TpYYmzUUHW5zj KTFdSDZq6kGs2i8xJJOqYFuh01E18mzPP7/+4R5Y= MIME-Version: 1.0 In-Reply-To: References: <20190606142255.29454-1-nsaenzjulienne@suse.de> <20190606142255.29454-5-nsaenzjulienne@suse.de> <20190606170949.4A46720652@mail.kernel.org> To: "Rafael J. Wysocki" , Nicolas Saenz Julienne , Viresh Kumar , stefan.wahren@i2se.com Subject: Re: [PATCH v2 4/7] cpufreq: add driver for Raspbery Pi From: Stephen Boyd User-Agent: alot/0.8.1 Date: Thu, 06 Jun 2019 10:36:08 -0700 Message-Id: <20190606173609.2C3952083D@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190606_103609_878741_BF02719F X-CRM114-Status: GOOD ( 18.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: f.fainelli@gmail.com, linux-pm@vger.kernel.org, mturquette@baylibre.com, ptesarik@suse.com, linux-kernel@vger.kernel.org, mbrugger@suse.de, eric@anholt.net, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ssuloev@orpaltech.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Nicolas Saenz Julienne (2019-06-06 10:22:16) > Hi Stephen, > Thanks for the review. > > On Thu, 2019-06-06 at 10:09 -0700, Stephen Boyd wrote: > > Quoting Nicolas Saenz Julienne (2019-06-06 07:22:56) > > > diff --git a/drivers/cpufreq/raspberrypi-cpufreq.c > > > b/drivers/cpufreq/raspberrypi-cpufreq.c > > > new file mode 100644 > > > index 000000000000..99b59d5a50aa > > > --- /dev/null > > > +++ b/drivers/cpufreq/raspberrypi-cpufreq.c > > [...] > > > + > > > +/* > > > + * Since the driver depends on clk-raspberrypi, which may return > > > EPROBE_DEFER, > > > + * all the activity is performed in the probe, which may be defered as > > > well. > > > + */ > > > +static struct platform_driver raspberrypi_cpufreq_driver = { > > > + .driver = { > > > + .name = "raspberrypi-cpufreq", > > > + }, > > > + .probe = raspberrypi_cpufreq_probe, > > > + .remove = raspberrypi_cpufreq_remove, > > > +}; > > > +module_platform_driver(raspberrypi_cpufreq_driver); > > > > How does this driver probe? Do you have a node in DT named > > raspberrypi-cpufreq that matches and probes this? I would think this > > would follow the drivers/cpufreq/cpufreq-dt-platdev.c design where it's > > an initcall that probes the board compatible string. > > > > Or, if it depends on clk-raspberrypi probing, maybe it could create the > > platform device in that drivers probe function. > > Well you just reviewed that patch :) Ok. So what's your plan? > > > > + > > > +MODULE_AUTHOR("Nicolas Saenz Julienne > > +MODULE_DESCRIPTION("Raspberry Pi cpufreq driver"); > > > +MODULE_LICENSE("GPL"); > > > +MODULE_ALIAS("platform:raspberrypi-cpufreq"); > > > > I don't think the module alias is needed anymore. > > That's surprising. I remember the driver not being loaded by udev without it. > Maybe I'm wrong. Could be not needed for DT based platform devices with an OF table. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel