From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B704AC28EBD for ; Fri, 7 Jun 2019 02:21:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D8EF206DF for ; Fri, 7 Jun 2019 02:21:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="i1mqLKrH"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sbZ4UhtQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D8EF206DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VGaYxoGqZ3Hzzb31WbP5pjJ44JXjvL1oF/NgI6VyfJM=; b=i1mqLKrHN29pZ0 riP0BDRu8QXH/4NP4vzi9p4u8wo/7bjcXqM0bgrRpxn5JS00naJ70+x0l1Ke7tn5FuE7J0gTvMe+9 E8waKAAkev5mrS7rrIW3aJJAfGMUvfQW2acqz8MSgE1NEuH/jf5B0LFHdGTsyj36dztkBiNSre9/T /gSAQb5ChFfTzrlwLwKwDZrN91qtPPBRQPbKBzD9QlC0Y6pNqYrqGjuZ/L/KvqkXihNzM/dKkmXLV JA6OiTLwkoJFY43FlkN8kapg3GXbp/zvJWi3H4LiltkgJFeAycC/SSHsEg6lCDMwQvl8XcmvLtcAp uI8MjBJ8J/ibUikEOK6Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hZ4Vo-0004uS-Oo; Fri, 07 Jun 2019 02:21:48 +0000 Received: from mail-yb1-xb44.google.com ([2607:f8b0:4864:20::b44]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hZ4Vm-0004u3-7A for linux-arm-kernel@lists.infradead.org; Fri, 07 Jun 2019 02:21:47 +0000 Received: by mail-yb1-xb44.google.com with SMTP id x187so227557ybc.11 for ; Thu, 06 Jun 2019 19:21:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ypCRpLGfpU1UTauZw8qNAOgzbjXvHTif8VBKbvg8Yv0=; b=sbZ4UhtQKg5EgRtrg7vRjKJMr8vXoJDJ2sy0wlwAvzzyODxcsgFiYX+gdXWWxxMmc2 t+dbJScuXiVZQoszVJ4kfPowotE8aLagjUWGrTfUytsiU/fKwNxGIpx/heREknnLhU8G bA6s09NdVszAHpONG5qJHWmBAF/l7+nVKgQiskJgH1g1cEaRq5k/3jjkLCak0ttca1gF M9LJjLvkeheLN0Imi7fmeNspKiJhpOl1dL6MQrwhEjzynL+ETosKxZfTQbKZcfy4/kC6 9xnl9C5s8K7ckGISDEJ5xcw+YqRoFw0Dy9VUaoV+zJnC6pWCLCOd0JDFOB9UjbRBKN8n fa/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ypCRpLGfpU1UTauZw8qNAOgzbjXvHTif8VBKbvg8Yv0=; b=byYOavcnKnGFTKu6Tnafx2s2rguYm2Ha5bZj2m7O0UUU4WqkaEXEi/VDFU+QZPLCNP Z/laWgrdddz4EoCnO3sKMX9qI8qX+1h0fjbZBbndan6MgydHDi8hgumgfEFIbIdNh1zx TwhUQthQa432aSfSvIMgoRS4bwKcl65AdZrZZLx+eBiJZNUzw6q/DuzP5MjpgXIaQ4Bq KXpTL+F1AoovYBFSW/uRky6luwQjtvguuOj6s7VUTRc7lAlq4w6MZA+K4bY3mckKAezz ZoMyC7C7aR9+vP+8zkl8w6AL4PKSNeIe56m4GA3bNNSweROMXKqXb2OEeZQ4xU13TvpN 99GA== X-Gm-Message-State: APjAAAUktgUUjxf65h9+zOAhkB/wQZ44OB4233R5LOBFu+jU0AhJR1Or B7LgmAnnAbjelLfetsF2+X0vvA== X-Google-Smtp-Source: APXvYqx8iXRsTTJwXfeqfERnwv6goa9I+YMKIbTRglHzyqAa1kuPeFPIxG0H3RXeycT45RqygpWihw== X-Received: by 2002:a25:97c6:: with SMTP id j6mr24142048ybo.513.1559874104275; Thu, 06 Jun 2019 19:21:44 -0700 (PDT) Received: from leoy-ThinkPad-X240s (li1322-146.members.linode.com. [45.79.223.146]) by smtp.gmail.com with ESMTPSA id j14sm215444ywi.7.2019.06.06.19.21.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 06 Jun 2019 19:21:43 -0700 (PDT) Date: Fri, 7 Jun 2019 10:21:36 +0800 From: Leo Yan To: Suzuki K Poulose Subject: Re: [PATCH] Documentation: coresight: Update the generic device names Message-ID: <20190607022136.GE5970@leoy-ThinkPad-X240s> References: <1559229077-26436-1-git-send-email-suzuki.poulose@arm.com> <20190603190133.GA20462@xps15> <99055755-6525-694e-a15d-5de7318a80da@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <99055755-6525-694e-a15d-5de7318a80da@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190606_192146_324126_E222080A X-CRM114-Status: GOOD ( 19.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, corbet@lwn.net, linux-arm-kernel@lists.infradead.org, mathieu.poirier@linaro.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Suzuki, On Thu, Jun 06, 2019 at 05:21:19PM +0100, Suzuki K Poulose wrote: > Hi Mathieu, > > On 03/06/2019 20:01, Mathieu Poirier wrote: > > Hi Suzuki, > > > > On Thu, May 30, 2019 at 04:11:17PM +0100, Suzuki K Poulose wrote: > > > Update the documentation to reflect the new naming scheme with > > > latest changes. > > > > > > Reported-by: Leo Yan > > > Cc: Mathieu Poirier > > > Cc: Jonathan Corbet > > > Signed-off-by: Suzuki K Poulose > > > --- > > > Documentation/trace/coresight.txt | 34 +++++++++++++++++++--------------- > > > 1 file changed, 19 insertions(+), 15 deletions(-) > > > > > > diff --git a/Documentation/trace/coresight.txt b/Documentation/trace/coresight.txt > > > index efbc832..7b427cf 100644 > > > --- a/Documentation/trace/coresight.txt > > > +++ b/Documentation/trace/coresight.txt > > > @@ -326,16 +326,20 @@ amount of processor cores), the "cs_etm" PMU will be listed only once. > > > A Coresight PMU works the same way as any other PMU, i.e the name of the PMU is > > > listed along with configuration options within forward slashes '/'. Since a > > > Coresight system will typically have more than one sink, the name of the sink to > > > -work with needs to be specified as an event option. Names for sink to choose > > > -from are listed in sysFS under ($SYSFS)/bus/coresight/devices: > > > +work with needs to be specified as an event option. > > > +On newer kernels the available sinks are listed in sysFS under: > > > +($SYSFS)/bus/event_source/devices/cs_etm/sinks/ > > > - root@linaro-nano:~# ls /sys/bus/coresight/devices/ > > > - 20010000.etf 20040000.funnel 20100000.stm 22040000.etm > > > - 22140000.etm 230c0000.funnel 23240000.etm 20030000.tpiu > > > - 20070000.etr 20120000.replicator 220c0000.funnel > > > - 23040000.etm 23140000.etm 23340000.etm > > > + root@localhost:/sys/bus/event_source/devices/cs_etm/sinks# ls > > > + tmc_etf0 tmc_etr0 tpiu0 > > > - root@linaro-nano:~# perf record -e cs_etm/@20070000.etr/u --per-thread program > > > +On older kernels, this may need to be found from the list of coresight devices, > > > +available under ($SYSFS)/bus/coresight/devices/: > > > + > > > + root@localhost:/sys/bus/coresight/devices# ls > > > + etm0 etm1 etm2 etm3 etm4 etm5 funnel0 funnel1 funnel2 replicator0 stm0 tmc_etf0 tmc_etr0 tpiu0 > > > + > > > + root@linaro-nano:~# perf record -e cs_etm/@tmc_etr0/u --per-thread program > > > > On the "older" kernels you are referring to one would find the original naming > > convention. Everything else looks good to me. > > True, but do we care what we see there ? All we care about is the location, > where to find them. I could fix it, if you think thats needed. IIUC, either the old kernel or newer kernel, both we can find the event from ($SYSFS)/bus/event_source/devices/cs_etm/sinks/; the only difference between them is the naming convention. So the doc can use the same location to find event for both new and old kernel, and explain the naming convention difference? Thanks, Leo Yan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel