From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B61E3C468BC for ; Fri, 7 Jun 2019 13:37:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B93E20840 for ; Fri, 7 Jun 2019 13:37:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RO7BaUIj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B93E20840 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aDqCDvI8irU9j9m4lp9OARYJVt+eAerr1WchDmlONdQ=; b=RO7BaUIjR4FH9J YxuhlqZkmV3nvXXwUKYJovsncnsMatGX2Oxoo1LNoWlCGvrS1n08eYxj67WRWvN8BzuxbJYl+8co3 /KQdkzKCQ1eAfsMgklZuBWU9PX1U7Mp92Q+rJXQETgqpGMdtEGVN3Fjv7oroWYSec2OFPZpzvgsew YtaIcb/oC8ZZfGh2bZnXudCBI4Yn3Un7HtmUMjvZI9H4D16SMne1HvX75cd8grzdo0JfntZ3/+Rls RbTOfICpqD5twdSqVYEbJwK/RjnyNiLGzkAYRO+viQPVVF9V/9jm6pPlTIx4yB9nERJktLKR6Vqx/ fUjhL6Gjw/YKGKINNAmA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hZF3e-000585-2E; Fri, 07 Jun 2019 13:37:26 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hZF3b-00057i-G6 for linux-arm-kernel@lists.infradead.org; Fri, 07 Jun 2019 13:37:24 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 64EDC346; Fri, 7 Jun 2019 06:37:21 -0700 (PDT) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E8AA63F96A; Fri, 7 Jun 2019 06:37:19 -0700 (PDT) Date: Fri, 7 Jun 2019 14:37:14 +0100 From: Sudeep Holla To: Jeremy Linton Subject: Re: [PATCH v3 4/5] arm_pmu: acpi: spe: Add initial MADT/SPE probing Message-ID: <20190607133714.GA15577@e107155-lin> References: <20190503232407.37195-1-jeremy.linton@arm.com> <20190503232407.37195-5-jeremy.linton@arm.com> <20190607095729.GD2429@e107155-lin> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190607_063723_629012_9D904C48 X-CRM114-Status: GOOD ( 29.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, lorenzo.pieralisi@arm.com, will.deacon@arm.com, john.garry@huawei.com, rjw@rjwysocki.net, linuxarm@huawei.com, linux-acpi@vger.kernel.org, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, lenb@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 07, 2019 at 08:28:04AM -0500, Jeremy Linton wrote: > Hi, > > On 6/7/19 4:57 AM, Sudeep Holla wrote: > > On Fri, May 03, 2019 at 06:24:06PM -0500, Jeremy Linton wrote: > > > ACPI 6.3 adds additional fields to the MADT GICC > > > structure to describe SPE PPI's. We pick these out > > > of the cached reference to the madt_gicc structure > > > similarly to the core PMU code. We then create a platform > > > device referring to the IRQ and let the user/module loader > > > decide whether to load the SPE driver. > > > > > > Signed-off-by: Jeremy Linton > > > --- > > > arch/arm64/include/asm/acpi.h | 3 ++ > > > drivers/perf/Kconfig | 5 +++ > > > drivers/perf/arm_pmu_acpi.c | 76 +++++++++++++++++++++++++++++++++++ > > > include/linux/perf/arm_pmu.h | 2 + > > > 4 files changed, 86 insertions(+) > > > > > > diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h > > > index 7628efbe6c12..d10399b9f998 100644 > > > --- a/arch/arm64/include/asm/acpi.h > > > +++ b/arch/arm64/include/asm/acpi.h > > > @@ -41,6 +41,9 @@ > > > (!(entry) || (entry)->header.length < ACPI_MADT_GICC_MIN_LENGTH || \ > > > (unsigned long)(entry) + (entry)->header.length > (end)) > > > +#define ACPI_MADT_GICC_SPE (ACPI_OFFSET(struct acpi_madt_generic_interrupt, \ > > > + spe_interrupt) + sizeof(u16)) > > > + > > > /* Basic configuration for ACPI */ > > > #ifdef CONFIG_ACPI > > > pgprot_t __acpi_get_mem_attribute(phys_addr_t addr); > > > diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig > > > index af9bc178495d..bc2647c64c9d 100644 > > > --- a/drivers/perf/Kconfig > > > +++ b/drivers/perf/Kconfig > > > @@ -52,6 +52,11 @@ config ARM_PMU_ACPI > > > depends on ARM_PMU && ACPI > > > def_bool y > > > +config ARM_SPE_ACPI > > > + depends on ARM_PMU_ACPI && ARM_SPE_PMU > > > + def_bool y > > > + > > > + > > > config ARM_DSU_PMU > > > tristate "ARM DynamIQ Shared Unit (DSU) PMU" > > > depends on ARM64 > > > diff --git a/drivers/perf/arm_pmu_acpi.c b/drivers/perf/arm_pmu_acpi.c > > > index 0f197516d708..b0244e1e8c91 100644 > > > --- a/drivers/perf/arm_pmu_acpi.c > > > +++ b/drivers/perf/arm_pmu_acpi.c > > > @@ -74,6 +74,80 @@ static void arm_pmu_acpi_unregister_irq(int cpu) > > > acpi_unregister_gsi(gsi); > > > } > > > +#ifdef CONFIG_ARM_SPE_ACPI > > > +static struct resource spe_resources[] = { > > > + { > > > + /* irq */ > > > + .flags = IORESOURCE_IRQ, > > > + } > > > +}; > > > + > > > +static struct platform_device spe_dev = { > > > + .name = ARMV8_SPE_PDEV_NAME, > > > + .id = -1, > > > + .resource = spe_resources, > > > + .num_resources = ARRAY_SIZE(spe_resources) > > > +}; > > > + > > > +/* > > > + * For lack of a better place, hook the normal PMU MADT walk > > > + * and create a SPE device if we detect a recent MADT with > > > + * a homogeneous PPI mapping. > > > + */ > > > +static int arm_spe_acpi_register_device(void) > > > +{ > > > + int cpu, ret, irq; > > > + int hetid; > > > + u16 gsi = 0; > > > + bool first = true; > > > + > > > + struct acpi_madt_generic_interrupt *gicc; > > > + > > > + /* > > > + * sanity check all the GICC tables for the same interrupt number > > > + * for now we only support homogeneous ACPI/SPE machines. > > > + */ > > > + for_each_possible_cpu(cpu) { > > > + gicc = acpi_cpu_get_madt_gicc(cpu); > > > + > > > + if (gicc->header.length < ACPI_MADT_GICC_SPE) > > > + return -ENODEV; > > > + if (first) { > > > + gsi = gicc->spe_interrupt; > > > + if (!gsi) > > > + return -ENODEV; > > > + hetid = find_acpi_cpu_topology_hetero_id(cpu); > > > + first = false; > > > + } else if ((gsi != gicc->spe_interrupt) || > > > + (hetid != find_acpi_cpu_topology_hetero_id(cpu))) { > > > > Sorry, I should have noticed this in patch 2 itself. Won't this break for > > multi-socket system ? The hetid in that case will be package id, no ? > > Your assuming a PPTT with multiple trees, one for each socket? Yes it breaks > in that case, and is what I was complaining about in the cover letter > because there won't be a common node with the IDENTICAL flag set. OTOH, I > think it works fine for multi-socket given a single tree where the root has > IDENTICAL set (I did some very light testing on such a machine). > Ah OK, so you are saying such system must have root with IDENTICAL flag set. Sounds fine, but is there any way to check that ? It's not mandated right. At least, I didn't have when I hacked up PPTT for Juno and no one complains(iasl/uefi/linux). But yes that's a different problem, at-least we know how to fix such PPTT topology. > I don't think there is a solution to this problem that won't break in the > case of a heterogeneous machine with multiple sockets populated with > differing cores. > Agreed, I was worried about only about case, but having root node is feasible solution. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel