From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31E89C2BCA1 for ; Fri, 7 Jun 2019 18:46:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BCE8208C0 for ; Fri, 7 Jun 2019 18:46:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="corIfSDH"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Z47c1q/I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BCE8208C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:From:To: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pPmMMDfRXk9oxa3YGBCPPbjlhGiou+46x2DX/zqDR8s=; b=corIfSDHVXcMEw QMCAdnOspJYLXdxQNs6CNdnOrLVKetqtvrVamxm1cidGixtt2Va/vZxnA/s9n1L1TcArW2ujxXizE 4g2cZ/PpuC/Nx3Rf0t5XUre/VQL1ccZBKSVvuKaUW7Tt0nGzl46z7y3Fv76hpJWQh5rL8f4Au35dy o3q3nK61LkyJvhHy/RyMSiO2H5tw9vt+z+rjbBwl1e89JXq67hikmxus3jUdSU1lwmhklq2X0YNCq Amu+aiGHV4/VtCk3wi8PzIDYJ/gM9Ct6YEbYdN2UmBziO1QDhk89kZwwPLMYeTEW7R+EKtc5fM+G+ yN3wOOEICFJLLAQwUXlg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hZJsg-0003je-DH; Fri, 07 Jun 2019 18:46:26 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hZJsd-0003iT-4N for linux-arm-kernel@lists.infradead.org; Fri, 07 Jun 2019 18:46:24 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D5C3F212F5; Fri, 7 Jun 2019 18:46:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559933181; bh=J0nw1E2EN/TtoXc1Q4Yuy9LdBjugC1jeuRsyc4v7azA=; h=In-Reply-To:References:To:From:Subject:Cc:Date:From; b=Z47c1q/I05xsmjxvEUBEAn9G+zpsYmIOQeKwpy7p4Btrw2EpCxb0q8fJGbpPHUUmU aNTuF4bwgnnRPh1KEcMQ9msRSOofsnngKvr2604IcjxKCESd1FvjyA7KT3jARjeqSQ 95Z/vIJbonxZgUyzNQ2EOd3GFUTSDOBC/uqGjPY0= MIME-Version: 1.0 In-Reply-To: References: <20190520080421.12575-1-wens@kernel.org> <20190520090327.iejd3q7c3iwomzlz@flea> To: Chen-Yu Tsai From: Stephen Boyd Subject: Re: [PATCH 00/25] clk: sunxi-ng: clk parent rewrite part 1 User-Agent: alot/0.8.1 Date: Fri, 07 Jun 2019 11:46:21 -0700 Message-Id: <20190607184621.D5C3F212F5@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190607_114623_207346_DC529AF9 X-CRM114-Status: GOOD ( 23.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , Michael Turquette , linux-kernel , Chen-Yu Tsai , linux-clk , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Chen-Yu Tsai (2019-06-03 09:38:22) > Hi Stephen, > > On Mon, May 20, 2019 at 5:03 PM Maxime Ripard wrote: > > > > On Mon, May 20, 2019 at 04:03:56PM +0800, Chen-Yu Tsai wrote: > > > From: Chen-Yu Tsai > > > > > > Hi everyone, > > > > > > This is series is the first part of a large series (I haven't done the > > > rest) of patches to rewrite the clk parent relationship handling within > > > the sunxi-ng clk driver. This is based on Stephen's recent work allowing > > > clk drivers to specify clk parents using struct clk_hw * or parsing DT > > > phandles in the clk node. > > > > > > This series can be split into a few major parts: > > > > > > 1) The first patch is a small fix for clk debugfs representation. This > > > was done before commit 1a079560b145 ("clk: Cache core in > > > clk_fetch_parent_index() without names") was posted, so it might or > > > might not be needed. Found this when checking my work using > > > clk_possible_parents. > > > > > > 2) A bunch of CLK_HW_INIT_* helper macros are added. These cover the > > > situations I encountered, or assume I will encounter, such as single > > > internal (struct clk_hw *) parent, single DT (struct clk_parent_data > > > .fw_name), multiple internal parents, and multiple mixed (internal + > > > DT) parents. A special variant for just an internal single parent is > > > added, CLK_HW_INIT_HWS, which lets the driver share the singular > > > list, instead of having the compiler create a compound literal every > > > time. It might even make sense to only keep this variant. > > > > > > 3) A bunch of CLK_FIXED_FACTOR_* helper macros are added. The rationale > > > is the same as the single parent CLK_HW_INIT_* helpers. > > > > > > 4) Bulk conversion of CLK_FIXED_FACTOR to use local parent references, > > > either struct clk_hw * or DT .fw_name types, whichever the hardware > > > requires. > > > > > > 5) The beginning of SUNXI_CCU_GATE conversion to local parent > > > references. This part is not done. They are included as justification > > > and examples for the shared list of clk parents case. > > > > That series is pretty neat. As far as sunxi is concerned, you can add my > > Acked-by: Maxime Ripard > > > > > I realize this is going to be many patches every time I convert a clock > > > type. Going forward would the people involved prefer I send out > > > individual patches like this series, or squash them all together? > > > > For bisection, I guess it would be good to keep the approach you've > > had in this series. If this is really too much, I guess we can always > > change oru mind later on. > > Any thoughts on this series and how to proceed? > I have a few minor nitpicks but otherwise the series looks good to me. I'm perfectly happy to see the individual patches unless you want to squash them into one big patch. I can review the conversions either way. Did you need me to apply any patches here? Or can I assume you'll resend with a pull request so it can be merged into clk-next? BTW, did you have to update any DT bindings or documentation? I didn't see anything, so I'm a little surprised that all that stuff was already in place. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel