From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28565C468BC for ; Fri, 7 Jun 2019 19:03:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA11E20868 for ; Fri, 7 Jun 2019 19:03:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="f3N2LyCW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="aBft8Ng3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA11E20868 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:From:To: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EnRUTiyYN6Wj396iF/uy5XXhHdh0Z+GrKyBV227+HJU=; b=f3N2LyCWZpWnEJ XgDeMgiM16ldrE9K/3x87FlWu7ewluHEGPpDrrgheJPO3SbLvrcQ2j0zkFl3yM0X/OPX8obzmsYCv CjMdtaQF72E/8OrO+NZ4uDsFhKcp4W/SINGeCBPN3DrZw//XFhRt51b4Ig362ekz4aBQLnXIr5LLE EZUSu2wbdr6DPe26qhdQCT1u3rQl1CwMueLDJmEy+WDmF7Cpq5UFnqhWE3/v5XSdCEPw7jePh0PvW GQ7RaEj5w91Z/XvADMjzZsFEWI2a4y549JLFgCB3O7xNoyKrZ1y7Li/d6TK7z8MkZf69I/K4Wfyct Zlj8TVXkfjxdcYo1FGsA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hZK9H-0002cE-3u; Fri, 07 Jun 2019 19:03:35 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hZK9D-0002bK-Uy; Fri, 07 Jun 2019 19:03:33 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8B06020868; Fri, 7 Jun 2019 19:03:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559934211; bh=mrL8ZvU1j098gqUDw8JKIJmCCxGU9vpbYH6xVhe34iM=; h=In-Reply-To:References:To:From:Subject:Cc:Date:From; b=aBft8Ng32JulEBE9OCaXF/cfqepkKpawjKLmviZxT4hl2AUj+eStMAu2WpzSfOfr6 CYtJlXMPERBWssrLSooM/NOAcjFr3wTTXL59aQAzpUKEiVsJuCAco1QNi9mo+uqxI3 F0zju3tuU/ktvo9M1pqGD5IuNkLFt43gwkfkoHJU= MIME-Version: 1.0 In-Reply-To: <20190607104533.14700-1-colin.king@canonical.com> References: <20190607104533.14700-1-colin.king@canonical.com> To: Colin King , Eric Anholt , Florian Fainelli , Michael Turquette , Ray Jui , Scott Branden , Stefan Wahren , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org From: Stephen Boyd Subject: Re: [PATCH][next] clk: bcm2835: fix memork leak on unfree'd pll struct User-Agent: alot/0.8.1 Date: Fri, 07 Jun 2019 12:03:30 -0700 Message-Id: <20190607190331.8B06020868@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190607_120332_011543_F2996CAB X-CRM114-Status: GOOD ( 15.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Colin King (2019-06-07 03:45:33) > From: Colin Ian King > > The pll struct is being allocated but not kfree'd on an error return > path when devm_clk_hw_register fails. Fix this with a kfree on pll > if an error occurs. > > Addresses-Coverity: ("Resource leak") > Fixes: b19f009d4510 ("clk: bcm2835: Migrate to clk_hw based registration and OF APIs") I suspect this problem was there before this commit, but OK. > Signed-off-by: Colin Ian King > --- > drivers/clk/bcm/clk-bcm2835.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c > index 770bb01f523e..90584deaf416 100644 > --- a/drivers/clk/bcm/clk-bcm2835.c > +++ b/drivers/clk/bcm/clk-bcm2835.c > @@ -1310,8 +1310,10 @@ static struct clk_hw *bcm2835_register_pll(struct bcm2835_cprman *cprman, > pll->hw.init = &init; > > ret = devm_clk_hw_register(cprman->dev, &pll->hw); > - if (ret) > + if (ret) { > + kfree(pll); > return NULL; > + } > return &pll->hw; > } Aren't there more leaks in this driver? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel