From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0436AC28EBD for ; Sun, 9 Jun 2019 10:36:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC88F2067C for ; Sun, 9 Jun 2019 10:36:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KbyJkWcn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC88F2067C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dh8XGyGNCEzSIQh68tsCutN0MpSmvv79s4PLoVXucx4=; b=KbyJkWcnHN7wV+ tdmf/2stxqeg2UA65Z9CzUGLA2BLQKF8RJOSgRfPJNZ35n4Yxgbfo/eLvccWPW4pGx4q6vEpncQVT G4YRwkwdx/N52t4wR2pOMXo8eAOLTPif3CFPR4PJkAmewfrK+D2s77560nCqvyUlrMJfBPCNTJXVv 0W129OVTJr8LkuVku6KJUITaYEBnBXrkJ9ok6wd762b2pEdowuDA3IjZAPCAg4f1njbtgO92tyb1Z y91081bk6ExNRlVkf6pHLpgklkzcNfDi0GkQAaX5FnN/dgtRk70C4D7Tr3ImuuoLCahxO+sAz9a7+ 5uwnUVuKQCtnnshfMkIg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hZvBA-0005xL-Pe; Sun, 09 Jun 2019 10:36:00 +0000 Received: from asavdk3.altibox.net ([109.247.116.14]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hZv8B-0001wa-On; Sun, 09 Jun 2019 10:32:59 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id C6F642002D; Sun, 9 Jun 2019 12:32:42 +0200 (CEST) Date: Sun, 9 Jun 2019 12:32:41 +0200 From: Sam Ravnborg To: Jitao Shi Subject: Re: [1/2] dt-bindngs: display: panel: Add BOE tv101wum-nl6 panel bindings Message-ID: <20190609103241.GA28935@ravnborg.org> References: <20190608070230.55381-1-jitao.shi@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190608070230.55381-1-jitao.shi@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=mpaa-ttXAAAA:8 a=GOHkJZeNjhEJBjOU3QsA:9 a=zQRrZ5hHoVty9KUv:21 a=G8XELezRatH2Uwd4:21 a=CjuIK1q_8ugA:10 a=6heAxKwa5pAsJatQ0mat:22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190609_033256_167672_EE009904 X-CRM114-Status: GOOD ( 18.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , stonea168@163.com, dri-devel@lists.freedesktop.org, Ajay Kumar , Vincent Palatin , cawa.cheng@mediatek.com, yingjoe.chen@mediatek.com, Thierry Reding , Sean Paul , linux-pwm@vger.kernel.org, Pawel Moll , Ian Campbell , Rob Herring , linux-mediatek@lists.infradead.org, Russell King , Matthias Brugger , eddie.huang@mediatek.com, linux-arm-kernel@lists.infradead.org, Rahul Sharma , srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, Sascha Hauer , Andy Yan Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jitao Always good to see more panels added. On Sat, Jun 08, 2019 at 03:02:29PM +0800, Jitao Shi wrote: > Add documentation for boe tv101wum-n16 panel. The changelog says tv101wum-n16 but the compatible says tv101wum-nl6. Please pick the right one and be consistent. (number one '1' versus character 'l') > > Signed-off-by: Jitao Shi > --- > .../display/panel/boe,tv101wum-nl6.txt | 34 +++++++++++++++++++ > 1 file changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.txt b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.txt > new file mode 100644 > index 000000000000..2a84735d742d > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.txt > @@ -0,0 +1,34 @@ > +Boe Corporation 10.1" WUXGA TFT LCD panel > + > +Required properties: > +- compatible: should be "boe,tv101wum" The example uses "boe,tv101wum-nl6", which matches the filename. Please fix so it is the same all over. > +- reg: the virtual channel number of a DSI peripheral > +- enable-gpios: a GPIO spec for the enable pin > +- pp1800-supply: core voltage supply > +- avdd-supply: > +- avee-supply: Missing descriptions - please add. > +- backlight: phandle of the backlight device attached to the panel > + > +The device node can contain one 'port' child node with one child > +'endpoint' node, according to the bindings defined in > +media/video-interfaces.txt. This node should describe panel's video bus. > + > +Example: > +&dsi { > + ... > + panel@0 { > + compatible = "boe,tv101wum-nl6"; > + reg = <0>; > + enable-gpios = <&pio 45 0>; > + avdd-supply = <&ppvarn_lcd>; > + avee-supply = <&ppvarp_lcd>; > + pp1800-supply = <&pp1800_lcd>; > + backlight = <&backlight_lcd0>; > + status = "okay"; > + port { > + panel_in: endpoint { > + remote-endpoint = <&dsi_out>; > + }; > + }; > + }; > +}; > \ No newline at end of file Please add newline. Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel