From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E6F0C28EBD for ; Sun, 9 Jun 2019 11:22:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1D8620840 for ; Sun, 9 Jun 2019 11:22:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Wg4Mrx0u"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="NN9O7/gF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1D8620840 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mD/iwwbh0/0FgZz2AP++rf1NSbJIdG6Jhdin3KjF7Uk=; b=Wg4Mrx0uWHy8WK 4FbLHbs9JimryV4fex6ep9lfGHuJaG/cKA2MNYv4PuqVPCxRlE2PdJMjg5wTJIv4S5VeIx0mKmhsn MRuNmlLA9d/lrSzwCDqGQ22uVR8dYKQnaFlmUFkRaMTF988WGoz/rhk+ZX1sKNCsTm+fg12F8cibf ZJFFkp0Fxfs33SSuJ9R6w3od/670RrH0I3ruMtRg22BtbFU4f4S2Beweo7kl2booWzTw1b5N/8Sra hHJWF9uwS1qDdecgynVMX/TSX3jwSb5cL2Ks1ZYQP8BExW/nUvZUcSbKCtnYX91hDLw+MkH3CtXZX XbEqZKwXOb1wmB+djj/Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hZvuO-0004xW-Hy; Sun, 09 Jun 2019 11:22:44 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hZvuK-0004wb-Tg for linux-arm-kernel@lists.infradead.org; Sun, 09 Jun 2019 11:22:42 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 68C3320840; Sun, 9 Jun 2019 11:22:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560079357; bh=ptu/UtjTcmnAD1z/pLhf3hslt2ujtQSdCDjEoDsQr5E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NN9O7/gFk1Lu0voj3XZWaNIG3tO9qAqauL2HIr3aJNZYG6sErjLPD/exbvN6lYQiX bt8ZJM7fS52FYas4GwKAJpD71NzE+zmcpfiTEfC0+ZIbIASkYXNArIk6qOawWrFGB0 2y4LIYHF8XI3bqdCNw+Vn5/+T2UNaKu0jbs4HNs4= Date: Sun, 9 Jun 2019 13:22:35 +0200 From: Greg KH To: Dragan Cvetic Subject: Re: [PATCH V5 02/11] misc: xilinx-sdfec: add core driver Message-ID: <20190609112235.GA16574@kroah.com> References: <1560038656-380620-1-git-send-email-dragan.cvetic@xilinx.com> <1560038656-380620-3-git-send-email-dragan.cvetic@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1560038656-380620-3-git-send-email-dragan.cvetic@xilinx.com> User-Agent: Mutt/1.12.0 (2019-05-25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190609_042240_993053_DF2A7955 X-CRM114-Status: GOOD ( 21.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, arnd@arndb.de, michal.simek@xilinx.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, Derek Kiernan , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jun 09, 2019 at 01:04:07AM +0100, Dragan Cvetic wrote: > Implement a platform driver that matches with xlnx, > sd-fec-1.1 device tree node and registers as a character > device, including: > - SD-FEC driver binds to sdfec DT node. > - creates and initialise an initial driver dev structure. > - add the driver in Linux build and Kconfig. > > Tested-by: Dragan Cvetic > Signed-off-by: Derek Kiernan > Signed-off-by: Dragan Cvetic > --- > drivers/misc/Kconfig | 12 +++++ > drivers/misc/Makefile | 1 + > drivers/misc/xilinx_sdfec.c | 118 ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 131 insertions(+) > create mode 100644 drivers/misc/xilinx_sdfec.c > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig > index 6b0417b..319a6bf 100644 > --- a/drivers/misc/Kconfig > +++ b/drivers/misc/Kconfig > @@ -471,6 +471,18 @@ config PCI_ENDPOINT_TEST > Enable this configuration option to enable the host side test driver > for PCI Endpoint. > > +config XILINX_SDFEC > + tristate "Xilinx SDFEC 16" > + help > + This option enables support for the Xilinx SDFEC (Soft Decision > + Forward Error Correction) driver. This enables a char driver > + for the SDFEC. > + > + You may select this driver if your design instantiates the > + SDFEC(16nm) hardened block. To compile this as a module choose M. > + > + If unsure, say N. > + > config MISC_RTSX > tristate > default MISC_RTSX_PCI || MISC_RTSX_USB > diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile > index b9affcd..0cb3546 100644 > --- a/drivers/misc/Makefile > +++ b/drivers/misc/Makefile > @@ -59,3 +59,4 @@ obj-$(CONFIG_OCXL) += ocxl/ > obj-y += cardreader/ > obj-$(CONFIG_PVPANIC) += pvpanic.o > obj-$(CONFIG_HABANA_AI) += habanalabs/ > +obj-$(CONFIG_XILINX_SDFEC) += xilinx_sdfec.o > diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c > new file mode 100644 > index 0000000..75cc980 > --- /dev/null > +++ b/drivers/misc/xilinx_sdfec.c > @@ -0,0 +1,118 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Xilinx SDFEC > + * > + * Copyright (C) 2019 Xilinx, Inc. > + * > + * Description: > + * This driver is developed for SDFEC16 (Soft Decision FEC 16nm) > + * IP. It exposes a char device which supports file operations > + * like open(), close() and ioctl(). > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +static int xsdfec_ndevs; You should use an idr for this, not just a number you bump up and down. This will not work properly at all. Think about this situation: probe device 0 xsdfec_ndevs = 1 probe device 1 xsdfec_ndevs = 2 remove device 0 xsdfec_ndevs = 0 probe another device misc device fails due to duplicate name. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel