From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BADDBC282DD for ; Mon, 10 Jun 2019 10:32:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9400A204FD for ; Mon, 10 Jun 2019 10:32:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kvTOpkgk"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=codeweavers.com header.i=@codeweavers.com header.b="hjRROG+s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9400A204FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=codeweavers.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rjP8EbXCYvombEXmaX0/vOOiK3cldjEkg2zK1bIIaOI=; b=kvTOpkgkvZoUu2 L7tOEoky47sa0NnldqfTP+JaJ0fyP0hQkjTAPGSJ06SOgqNhs5adowXpPxphll4LlYINsZ8CCheV4 DAUHSde4uPz69Z65vejMkBC2IkJjwdN15ZRKZ3Vbdq5C7AsiLOBSvBFLIUhYPNpSF1yy457CwUlGC 2KhWAOZXwZP/PmQnwcjAVVPFSdtIm/3m1AtrX759YqK0/aqQ35Tw4NC7GeHIQza3ZqqS0ZWS7c/Jl sOv6vQoBIwhyFDwshJR1yhBODSjX2zb2uOgehe0KBpE2hN0YxXjG/cqO37W69RO+1vuNbvPgvcm5K six+ydqkJ0AYDw5hBNeA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1haHat-0008Mr-00; Mon, 10 Jun 2019 10:32:03 +0000 Received: from mail.codeweavers.com ([50.203.203.244]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1haHaq-0008MC-I5 for linux-arm-kernel@lists.infradead.org; Mon, 10 Jun 2019 10:32:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codeweavers.com; s=6377696661; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=r1QCXvsFSkr/gu9OZ1c2/BfPNle5pK0zTIVRxi0RTVk=; b=hjRROG+sFrE9zFuM8Vg02v27O FDAbrF9af8NdndoODfFLAOuxiRPtskkK//A2yPN7rMVtXXfjqy2nquqVAFGRrrlctF0cBo6tq86nF i18hKpNeWqZwPmeQllUbNGCa5spznXUBbErcn4I9xgPQepcYoVDaO8pH6i3y1BaBLsuCY=; Received: from merlot.physics.ox.ac.uk ([163.1.241.98] helo=merlot) by mail.codeweavers.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1haHbL-0004O8-8w; Mon, 10 Jun 2019 05:32:32 -0500 Received: from daviesh by merlot with local (Exim 4.90_1) (envelope-from ) id 1haHai-0003ER-2l; Mon, 10 Jun 2019 11:31:52 +0100 Date: Mon, 10 Jun 2019 11:31:52 +0100 From: Huw Davies To: Vincenzo Frascino Subject: Re: [PATCH v6 01/19] kernel: Standardize vdso_datapage Message-ID: <20190610103151.GD11076@merlot.physics.ox.ac.uk> References: <20190530141531.43462-1-vincenzo.frascino@arm.com> <20190530141531.43462-2-vincenzo.frascino@arm.com> <20190610092751.GA11076@merlot.physics.ox.ac.uk> <58cedde2-0d54-7d2d-f519-77cb71f543fd@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <58cedde2-0d54-7d2d-f519-77cb71f543fd@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190610_033200_657706_D2F6E507 X-CRM114-Status: UNSURE ( 9.38 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Shuah Khan , Arnd Bergmann , Catalin Marinas , Daniel Lezcano , Will Deacon , linux-kernel@vger.kernel.org, Ralf Baechle , linux-mips@vger.kernel.org, Dmitry Safonov <0x7f454c46@gmail.com>, Paul Burton , linux-kselftest@vger.kernel.org, Rasmus Villemoes , Russell King , Thomas Gleixner , Mark Salyzyn , Peter Collingbourne , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 10, 2019 at 11:17:48AM +0100, Vincenzo Frascino wrote: > On 10/06/2019 10:27, Huw Davies wrote: > > On Thu, May 30, 2019 at 03:15:13PM +0100, Vincenzo Frascino wrote: > >> --- /dev/null > >> +++ b/include/vdso/datapage.h > >> @@ -0,0 +1,91 @@ > >> +/* SPDX-License-Identifier: GPL-2.0 */ > >> +#ifndef __VDSO_DATAPAGE_H > >> +#define __VDSO_DATAPAGE_H > >> + > >> +#ifdef __KERNEL__ > >> + > >> +#ifndef __ASSEMBLY__ > >> + > >> +#include > >> +#include > >> +#include > >> + > >> +#define VDSO_BASES (CLOCK_TAI + 1) > >> +#define VDSO_HRES (BIT(CLOCK_REALTIME) | \ > >> + BIT(CLOCK_MONOTONIC) | \ > >> + BIT(CLOCK_BOOTTIME) | \ > >> + BIT(CLOCK_TAI)) > >> +#define VDSO_COARSE (BIT(CLOCK_REALTIME_COARSE) | \ > >> + BIT(CLOCK_MONOTONIC_COARSE)) > >> +#define VDSO_RAW (BIT(CLOCK_MONOTONIC_RAW)) > >> + > >> +#define CS_HRES_COARSE 0 > >> +#define CS_RAW 1 > > > > CS_HRES_COARSE seems like a confusing name choice to me. What you > > really mean is not RAW. > > > > How about CS_ADJ to indicate that its updated by adjtime? > > CS_XTIME might be another option. > > > > I divided the timers in 3 sets (HRES, COARSE, RAW), CS_HRES_COARSE refers to the > first two and CS_RAW to the third. I will ad a comment to explain the logic in > the next iteration. I'm thinking ahead about a possible CLOCK_MONOTONIC_RAW_COARSE (which would be useful at least for Wine). In that case you'd have four clock types non-raw and raw, each with either hres or coarse. Huw. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel