From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF2FAC282DD for ; Mon, 10 Jun 2019 10:00:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B982B20862 for ; Mon, 10 Jun 2019 10:00:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OvLCGH+A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B982B20862 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=foss.arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S+4TzRq1nwjfYAp8AUUJwipWdPDEmft2b+RM8lZKivA=; b=OvLCGH+AANXGtq oL8KduAV4NlcDWmGgdK/obP68/EjnWtK22gUQf3sTo0GlUd0F5/2rZkDethM10Bakifz87HQLRCoZ fCCiIgNLkheiUYeZAVOImuJm2DdJBEkf2qg9xeRnlea2KcS7EWtVCDIBIksUdjJ9VotglHBxhPCwl nkKylqMApcd5BHrTdjap95OqcFm0v1tDAXheAXniZy3rgKrTjqsdODNceNNpvkV7WEaV7d1MIP7Yo lbXlfDDsjAzt/V2cI6krTWD/AdrVClLhokO1yBdOLbpKSrqhYCTZVaB6gNnyXfqHUkt4BPXhVpY6m Pc9puNsB1cp6CYlzxF8g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1haH6X-0001KP-8x; Mon, 10 Jun 2019 10:00:41 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1haH6U-0001JY-Lh for linux-arm-kernel@lists.infradead.org; Mon, 10 Jun 2019 10:00:39 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6F84C344; Mon, 10 Jun 2019 03:00:37 -0700 (PDT) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7B2E13F246; Mon, 10 Jun 2019 03:02:17 -0700 (PDT) Date: Mon, 10 Jun 2019 11:00:33 +0100 From: Andre Przywara To: Peng Fan Subject: Re: [PATCH V2 2/2] mailbox: introduce ARM SMC based mailbox Message-ID: <20190610110033.28d21d21@donnerap.cambridge.arm.com> In-Reply-To: References: <20190603083005.4304-1-peng.fan@nxp.com> <20190603083005.4304-3-peng.fan@nxp.com> <866db682-785a-e0a6-b394-bb65c7a694c6@gmail.com> <20190606142056.68272dc0@donnerap.cambridge.arm.com> Organization: ARM X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190610_030038_755068_54561F64 X-CRM114-Status: GOOD ( 14.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , Florian Fainelli , "festevam@gmail.com" , "jassisinghbrar@gmail.com" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "sudeep.holla@arm.com" , "van.freenix@gmail.com" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 10 Jun 2019 01:32:49 +0000 Peng Fan wrote: Hi Peng, [ ... ] > > > > + > > > > + irq_count = platform_irq_count(pdev); > > > > + if (irq_count == -EPROBE_DEFER) > > > > + return irq_count; > > > > + > > > > + if (irq_count && irq_count != val) { > > > > + dev_err(dev, "Interrupts not match num-chans\n"); > > > > > > Interrupts property does not match \"arm,num-chans\" would be more > > correct. > > > > Given that interrupts are optional, do we have to rely on this? > > If there is interrupt property, the interrupts should match channel counts. > > Do we actually > > need one interrupt per channel? > > I thought about this, provide one interrupt for all channels. > But there is no good way to let interrupt handlers know which > channel triggers the interrupt. So I use one interrupt per channel. Yeah, I was wondering about this as well. Seems like we need this indeed. Just sounds wasteful, but I guess we don't expect many channels anyway, normally. Cheers, Andre. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel