From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC923C28CC7 for ; Mon, 10 Jun 2019 13:51:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1D0E20859 for ; Mon, 10 Jun 2019 13:51:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="R+hzvliq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1D0E20859 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cHkSpkH4zYsBEWKEh2dfNLUMD4A8z9CWCbGeB8I8oXM=; b=R+hzvliqsPrVJ5IN5O6Re7tBM V3xI0gNcuUtjSaYN7G4IbB7S9VLhAO5TBaZVye5KBQwDMwncHym1J0OKrx8nXuhPRGcwHqp6kJ/zJ dRexLDlBCT1Zib5ej4OmTWD0RNEeYsTa4cJmO43sz0vAlcPt+V+Uidfd4/iqv9eBs6aufgl/Fn/n+ zH/xfZWTzQLZ9DcDcTy2wwwiFss3EPppX+GyQ/V3KaUr/FlzAobsjt4hOoRRoT8LG7U7i9YdxAfpW fkoNzCH7tnHoklVcyA0iriIBxg22Qjczvq/EiFla3ZROgUEoq0I8QAchWuf085eIG3WFpi+DsVWWo tbHclUqRQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1haKhu-0001ar-FR; Mon, 10 Jun 2019 13:51:30 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1haKhp-0001ZH-5G; Mon, 10 Jun 2019 13:51:27 +0000 X-Originating-IP: 90.88.159.246 Received: from localhost (aaubervilliers-681-1-40-246.w90-88.abo.wanadoo.fr [90.88.159.246]) (Authenticated sender: maxime.ripard@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 22AD7E0004; Mon, 10 Jun 2019 13:51:09 +0000 (UTC) Date: Mon, 10 Jun 2019 15:51:09 +0200 From: Maxime Ripard To: Martin Blumenstingl Subject: Re: [RFC next v1 0/5] stmmac: honor the GPIO flags for the PHY reset GPIO Message-ID: <20190610135109.7alkvruvw2jbtwph@flea> References: <20190609180621.7607-1-martin.blumenstingl@googlemail.com> <20190609204510.GB8247@lunn.ch> <20190610114700.tymqzzax334ahtz4@flea> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190610_065125_513195_B4FD9D41 X-CRM114-Status: GOOD ( 18.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , alexandre.torgue@st.com, bgolaszewski@baylibre.com, netdev@vger.kernel.org, linus.walleij@linaro.org, Neil Armstrong , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, joabreu@synopsys.com, khilman@baylibre.com, peppe.cavallaro@st.com, linux-amlogic@lists.infradead.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============5597522775939242324==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5597522775939242324== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hlwqgl7jkkjm4sqs" Content-Disposition: inline --hlwqgl7jkkjm4sqs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Martin, On Mon, Jun 10, 2019 at 02:31:17PM +0200, Martin Blumenstingl wrote: > On Mon, Jun 10, 2019 at 1:47 PM Maxime Ripard wrote: > > > > Hi Andrew, > > > > On Sun, Jun 09, 2019 at 10:45:10PM +0200, Andrew Lunn wrote: > > > > Patch #1 and #4 are minor cleanups which follow the boyscout rule: > > > > "Always leave the campground cleaner than you found it." > > > > > > > I > > > > am also looking for suggestions how to handle these cross-tree changes > > > > (patch #2 belongs to the linux-gpio tree, patches #1, 3 and #4 should > > > > go through the net-next tree. I will re-send patch #5 separately as > > > > this should go through Kevin's linux-amlogic tree). > > > > > > Patches 1 and 4 don't seem to have and dependencies. So i would > > > suggest splitting them out and submitting them to netdev for merging > > > independent of the rest. > > > > Jumping on the occasion of that series. These properties have been > > defined to deal with phy reset, while it seems that the PHY core can > > now handle that pretty easily through generic properties. > > > > Wouldn't it make more sense to just move to that generic properties > > that already deals with the flags properly? > thank you for bringing this up! > if anyone else (just like me) doesn't know about it, there are generic > bindings defined here: [0] > > I just tested this on my X96 Max by defining the following properties > inside the PHY node: > reset-delay-us = <10000>; > reset-assert-us = <10000>; > reset-deassert-us = <10000>; > reset-gpios = <&gpio GPIOZ_15 (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>; > > that means I don't need any stmmac patches which seems nice. I'm glad it works for you :) > instead I can submit a patch to mark the snps,reset-gpio properties in > the dt-bindings deprecated (and refer to the generic bindings instead) > what do you think? I already did as part of the binding reworks I did earlier today: http://lists.infradead.org/pipermail/linux-arm-kernel/2019-June/658427.html Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --hlwqgl7jkkjm4sqs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXP5gTQAKCRDj7w1vZxhR xTX2AQDErQs37AlgMjoegkuBtrfya5ARL23dKC2yJPk5bFAPIQEA8brM32gT3g4u 5bbyMYmku0KJTlZo2bHr8P+VKtd70A0= =Jc07 -----END PGP SIGNATURE----- --hlwqgl7jkkjm4sqs-- --===============5597522775939242324== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5597522775939242324==--