From: Greg KH <gregkh@linuxfoundation.org>
To: Michal Simek <michal.simek@xilinx.com>
Cc: monstr@monstr.eu, Nava kishore Manne <nava.manne@xilinx.com>,
linux-kernel@vger.kernel.org, johan@kernel.org,
linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] serial: xilinx_uartps: Fix warnings in the driver
Date: Mon, 10 Jun 2019 16:44:25 +0200 [thread overview]
Message-ID: <20190610144425.GC31086@kroah.com> (raw)
In-Reply-To: <c6753260caf8b20cc002b15fcbf22b759c91d760.1560156294.git.michal.simek@xilinx.com>
On Mon, Jun 10, 2019 at 10:44:55AM +0200, Michal Simek wrote:
> From: Nava kishore Manne <nava.manne@xilinx.com>
>
> This patch fixes the below warning
>
> -->Symbolic permissions 'S_IRUGO' are not preferred.
> Consider using octal permissions '0444'.
> -->macros should not use a trailing semicolon.
> -->line over 80 characters.
> -->void function return statements are not generally useful.
> -->Prefer 'unsigned int' to bare use of 'unsigned'.
>
> Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> Happy to split it if needed.
Please split. Do not do more than one "logical thing" per patch.
And the subject is not correct, there are no general "warnings", these
are all checkpatch warnings, not a build issue.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-10 14:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 8:44 [PATCH 1/2] serial: xilinx_uartps: Fix warnings in the driver Michal Simek
2019-06-10 8:44 ` [PATCH 2/2] serial: uartps: Use the same dynamin major number for all ports Michal Simek
2019-06-10 17:13 ` Greg KH
2019-06-10 14:44 ` Greg KH [this message]
2019-06-10 15:06 ` [PATCH 1/2] serial: xilinx_uartps: Fix warnings in the driver Michal Simek
2019-06-10 15:12 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190610144425.GC31086@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=nava.manne@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).