From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9A8CC31E41 for ; Mon, 10 Jun 2019 15:14:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9EEC3207E0 for ; Mon, 10 Jun 2019 15:14:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="udDV+/uN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="t/3aX0Fv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9EEC3207E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:From:To: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MAvTdYM0Jn19eD7e80+nwucyITTeA+yKcI5cVspTeYM=; b=udDV+/uNwmXGhh FkPCbdV5+5BOUeB5sTl2JABWMj0PfnT/nq69/fH2mM5QLQlgqZQ4GaAlB64vJjPGyMi7HTdaRG/TK vE5N6NNePPHBmavCD5I/uN++mveKj0LXzlkmZwWlk8wG8JXjeBBJcQrqSq0BSntFhnRSXZ5ZhNBQ1 FGSSe6lVRvOeRHFlAwjgoNka6EhgjurDCoTu2PiGm3krdJ2OhaN181i292FaEq2xBYlXextl3bSos jOZuEeFSwsciVcvhvbsDEXkczud/BKZ7SXEmoW62Hbad/1BxJkp8xAi+VczGPEI0N8lcR9SmQ3snd fo1A3TpZoTWcCLSNCw2A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1haM0D-0003gR-Mq; Mon, 10 Jun 2019 15:14:29 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1haM0A-0003fw-BJ for linux-arm-kernel@lists.infradead.org; Mon, 10 Jun 2019 15:14:27 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D8139207E0; Mon, 10 Jun 2019 15:14:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560179666; bh=P0dkD9ENiSJ+hO8sohQ82M4kCSPlYg9QTn6ACh1pGBM=; h=In-Reply-To:References:To:From:Cc:Subject:Date:From; b=t/3aX0FvHhHEPaDvxLC/Zt72Z7M8KIX/RV4nCGE26f5wvCqRAHSDFsqqyMKDezdSK Xl2KSBSHTNZKMlEfsDGPkQTwOxV+jTJYQSxnTn5KPI5682IJHA0IEh2WBH09u9Pabp UNDXWvPZA+0vbsuahyuhEOhz5rGFaIGoHZHPVXOY= MIME-Version: 1.0 In-Reply-To: References: <20190604015928.23157-1-Anson.Huang@nxp.com> <20190604015928.23157-3-Anson.Huang@nxp.com> <20190606162543.EFFB820645@mail.kernel.org> <20190607180039.611C7208C0@mail.kernel.org> To: "bjorn.andersson@linaro.org" , "catalin.marinas@arm.com" , "devicetree@vger.kernel.org" , "dinguyen@kernel.org" , "enric.balletbo@collabora.com" , "festevam@gmail.com" , "horms+renesas@verge.net.au" , "jagan@amarulasolutions.com" , "kernel@pengutronix.de" , "l.stach@pengutronix.de" , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "mark.rutland@arm.com" , "maxime.ripard@bootlin.com" , "mturquette@baylibre.com" , "olof@lixom.net" , "robh+dt@kernel.org" , "s.hauer@pengutronix .de" , "shawnguo@kernel.org" , "will.deacon@arm.com" , Abel Vesa , Aisheng Dong , Anson Huang , Jacky Bai , Leonard Crestez From: Stephen Boyd Subject: RE: [PATCH V3 3/4] clk: imx: Add support for i.MX8MN clock driver User-Agent: alot/0.8.1 Date: Mon, 10 Jun 2019 08:14:25 -0700 Message-Id: <20190610151425.D8139207E0@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190610_081426_427776_86CFF3AF X-CRM114-Status: GOOD ( 12.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dl-linux-imx Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Anson Huang (2019-06-08 02:58:18) > Hi, Stephen > > > -----Original Message----- > > From: Stephen Boyd > > Sent: Saturday, June 8, 2019 2:01 AM > > To: bjorn.andersson@linaro.org; catalin.marinas@arm.com; > > devicetree@vger.kernel.org; dinguyen@kernel.org; > > enric.balletbo@collabora.com; festevam@gmail.com; > > horms+renesas@verge.net.au; jagan@amarulasolutions.com; > > kernel@pengutronix.de; l.stach@pengutronix.de; linux-arm- > > kernel@lists.infradead.org; linux-clk@vger.kernel.org; linux- > > kernel@vger.kernel.org; mark.rutland@arm.com; > > maxime.ripard@bootlin.com; mturquette@baylibre.com; olof@lixom.net; > > robh+dt@kernel.org; s.hauer@pengutronix .de ; > > shawnguo@kernel.org; will.deacon@arm.com; Abel Vesa > > ; Aisheng Dong ; Anson > > Huang ; Jacky Bai ; Leonard > > Crestez > > Cc: dl-linux-imx > > Subject: RE: [PATCH V3 3/4] clk: imx: Add support for i.MX8MN clock driver > > > > Quoting Anson Huang (2019-06-06 17:50:28) > > > > > > I will use devm_platform_ioremap_resource() instead of ioremap(), and > > > can you be more specific about devmified clk registration? > > > > > > > I mean using things like devm_clk_hw_register(). > > Sorry, I am still a little confused, all the clock register(clk_register()) are via each different > clock types like imx_clk_gate4/imx_clk_pll14xx, if using clk_hw_register, means we need > to re-write the clock driver using different clk register method, that will make the driver > completely different from i.mx8mq/i.mx8mm, they are actually same series of SoC as i.mx8mn, > it will introduce many confusion, is my understanding correct? And is it OK to just keep what > it is and make them all aligned? > Ok, the problem I'm trying to point out is that clk registrations need to be undone, i.e. clk_unregister() needs to be called, when the driver fails to probe. devm_*() is one way to do this, but if you have other ways of removing all the registered clks then that works too. Makes sense? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel