From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 914D0C31E40 for ; Mon, 10 Jun 2019 17:16:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6645B207E0 for ; Mon, 10 Jun 2019 17:16:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GRuz/VwG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6645B207E0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=toc4su+YOc/trQWz/c9olGM5wJVxUyVAHAb45nhbZ6o=; b=GRuz/VwG4HvbFd an6HkVfopAjmTSA98wlg9NDZI8whEQJwVVZ4Fcm2ASdeLLJlsKuyXrRAdL9FIURtblXvXvQ+Uplba NBNlHjRMnEPH6X5w/M/7P1/daxoNnVfwD9ByZpsYFwUXaVY75Ay0Otkwo0m2EQnNMD1rI/NDMzyQ0 3r2Cl3E28YK3BxcOVdfsWx29f7s2ursTOljU9qTFSX15ONc9CazvmAswPPdhpzYvYh60A10TgCLhP cmPoVMG+fD9JqsAJ3ZlbTnOlueQMbTtWp7ojyOF2o+iIw0X829NwWFtyuYVo+XcpHY9fpg6IACXS9 36z3nVbloualq7uWM67w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1haNuR-0001jE-6T; Mon, 10 Jun 2019 17:16:39 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1haNuE-0001YY-BX for linux-arm-kernel@lists.infradead.org; Mon, 10 Jun 2019 17:16:27 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5CF56337; Mon, 10 Jun 2019 10:16:25 -0700 (PDT) Received: from redmoon (unknown [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AB4803F246; Mon, 10 Jun 2019 10:16:22 -0700 (PDT) Date: Mon, 10 Jun 2019 18:16:08 +0100 From: Lorenzo Pieralisi To: Ulf Hansson Subject: Re: [PATCH 00/18] ARM/ARM64: Support hierarchical CPU arrangement for PSCI Message-ID: <20190610171557.GA4560@redmoon> References: <20190513192300.653-1-ulf.hansson@linaro.org> <20190607154210.GJ15577@e107155-lin> <20190607193407.GB24059@builder> <20190610103225.GA26602@e107155-lin> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190610_101626_538413_5EE29F31 X-CRM114-Status: GOOD ( 15.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Linux Kernel Mailing List , Geert Uytterhoeven , "Rafael J. Wysocki" , Stephen Boyd , Viresh Kumar , Linux PM , Daniel Lezcano , "Rafael J . Wysocki" , Kevin Hilman , Amit Kucheria , Bjorn Andersson , Tony Lindgren , linux-arm-msm , Lina Iyer , Sudeep Holla , Niklas Cassel , Souvik Chakravarty , "Raju P . L . S . S . S . N" , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 10, 2019 at 05:54:39PM +0200, Ulf Hansson wrote: [...] > My summary from the earlier ones, is that because the PSCI spec > includes support for OSI, we should also support it in the kernel (and > ATF). In a discussion offlist, Lorenzo agreed that it's okay to add, > without an apple to apple comparison. Maybe Lorenzo can fill in and > state this publicly, to save us all some time? The comparison should have been made before even requesting PSCI OSI mode changes to the specifications, so we have a chip on our shoulders anyway. We will enable PSCI OSI but that's not where the problem lies, enabling PSCI OSI from a firmware perspective should take 10 lines of code, not: drivers/firmware/psci/Makefile | 2 +- drivers/firmware/psci/psci.c | 219 ++++++++-- drivers/firmware/psci/psci.h | 29 ++ drivers/firmware/psci/psci_pm_domain.c | 403 ++++++++++++++++++ I have some concerns about these changes that I will state in the relevant patches. > My final point in regards to the OSI mode support, it's a minor part > of the series. I don't see how that should hurt from a maintenance > point of view, or perhaps I am wrong? In any case, I offer my help > with review/maintenance in any form as you may see need/fit. I will go through the series but most of this code should move to core PM code, it has nothing to do with PSCI. BTW, apologies for the delay, I was away. Thanks, Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel