From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0363FC4321A for ; Tue, 11 Jun 2019 09:42:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAF9920673 for ; Tue, 11 Jun 2019 09:42:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NlDS6Ujb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAF9920673 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z4LN/FGEc1BQPMOMlrea0sJnljWpqVetlyuK3rdIIPY=; b=NlDS6UjbBpPOKM Fxbj+7/iR+8A8t1cKRkeanMO/k5i4FGeYC1fLOC5JKSN5PH/pritsYS1TaQRyNzuAGIjmWqmiaH7S QfnUhwHMMdisANKaju9H6A81nTNYA4OlYj5em5N6zjOhr6Z8ivKJdGu0+Dim7uoMinOOahdwvYJaR X5/ZJHsk7VXEZaFulCOXPjFNPlQealtoQ1v/GAk6QQt8jnXFoGMlcQuJBxDgeX/+Pi8+s7Hv0JAEw 3IaIqq2x6HrEzezOfmI8wPaXazOIkpZL/mb+K+PuykTfZ8ISG9v/VfqQOuKaD7q7go5lh4xUrXRIe RAExaiMx+fxCX0qFSMDQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hadIs-0003pS-9W; Tue, 11 Jun 2019 09:42:54 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hadIk-0003k2-3K for linux-arm-kernel@lists.infradead.org; Tue, 11 Jun 2019 09:42:50 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A8A5337; Tue, 11 Jun 2019 02:42:45 -0700 (PDT) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A31DE3F73C; Tue, 11 Jun 2019 02:44:26 -0700 (PDT) Date: Tue, 11 Jun 2019 10:42:29 +0100 From: Sudeep Holla To: Jean-Philippe Brucker Subject: Re: [PATCH v2] firmware/psci: psci_checker: Park kthreads before stopping them Message-ID: <20190611094229.GA6235@e107155-lin> References: <20190610173829.4741-1-jean-philippe.brucker@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190610173829.4741-1-jean-philippe.brucker@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190611_024246_238694_3B14BEBC X-CRM114-Status: GOOD ( 10.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, lorenzo.pieralisi@arm.com, linux-arm-kernel@lists.infradead.org, Sudeep Holla Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 10, 2019 at 06:38:29PM +0100, Jean-Philippe Brucker wrote: > Since commit 85f1abe0019f ("kthread, sched/wait: Fix kthread_parkme() > completion issue"), kthreads that are bound to a CPU must be parked > before being stopped. At the moment the PSCI checker calls > kthread_stop() directly on the suspend kthread, which triggers the > following warning: > > [ 6.068288] WARNING: CPU: 1 PID: 1 at kernel/kthread.c:398 __kthread_bind_mask+0x20/0x78 > ... > [ 6.190151] Call trace: > [ 6.192566] __kthread_bind_mask+0x20/0x78 > [ 6.196615] kthread_unpark+0x74/0x80 > [ 6.200235] kthread_stop+0x44/0x1d8 > [ 6.203769] psci_checker+0x3bc/0x484 > [ 6.207389] do_one_initcall+0x48/0x260 > [ 6.211180] kernel_init_freeable+0x2c8/0x368 > [ 6.215488] kernel_init+0x10/0x100 > [ 6.218935] ret_from_fork+0x10/0x1c > [ 6.222467] ---[ end trace e05e22863d043cd3 ]--- > > kthread_unpark() tries to bind the thread to its CPU and aborts with a > WARN() if the thread wasn't in TASK_PARKED state. Park the kthreads > before stopping them. > Reviewed-by: Sudeep Holla -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel