From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D551C4321A for ; Tue, 11 Jun 2019 17:39:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DDBE521743 for ; Tue, 11 Jun 2019 17:39:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="E3U75om5"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="NvT1h0wg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDBE521743 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=inV4dJ9Do9XVEDdkCqP4c8qcJaizvnJ9L3LWDAr6jaM=; b=E3U75om5uzjOPu co7K5fhh4kQi9I4o1E9XhuPXdJqMQxSBbsoCHOWI6pkKwwXU8Vxk2DOEOK+vbkve0q1xJveKkJE38 /qUoxTCsjdyMzww6EmPjlAeSj+p1DYc0ohJs+tRN6fxb3lAwEyCa1WkP0PsgS44sEzQYFRXhKhApO j8MmEx2yeWukakmHLbHymE3b4wEFcoK9/VNO75quF0zSvccxo3PF9cpNbmht1l7ANweXQEIoh1X6h dC/3tqAS/Q2tdUThTMAVZrI5dBqll9I0YU76Yq/mDFEM9eEV37DCf2hCA47u4hGvEDB45zQA92ToG pSotfaEVowbGqTag1OUQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hakkC-0006Ry-FG; Tue, 11 Jun 2019 17:39:36 +0000 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hakjt-0006Dh-2y for linux-arm-kernel@lists.infradead.org; Tue, 11 Jun 2019 17:39:21 +0000 Received: by mail-ed1-x542.google.com with SMTP id k8so6676098eds.7 for ; Tue, 11 Jun 2019 10:39:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=w5N2tKS/Rl6PSEhU2ojyJX68K3uG8DsBNcK2H7xhug8=; b=NvT1h0wggzS0hz0PDBCzPPh5Ge5ir++LUyVwr7g/5KfnulH0p5RSnOJH3v9BnXE2Pg OwQ+InctUir5CPHG97smHdUISweVsS2w8gLeRYPp4w7WW95GaLjJ6vw0eW2yLPvE5Cbd CYnFLtlFGwQlIjjVIMykJEYrhNDXANavV/TDs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=w5N2tKS/Rl6PSEhU2ojyJX68K3uG8DsBNcK2H7xhug8=; b=Vq7daGCgWmZ6eJTwz1bLXYGBI+CS5gIrDIKo5PA9WcmXKnOTAQefqrShiPV2AuFWTr vxa27V8E99IgDffRn/YGWPudJQFjoBVKrvQ0NYwPryClstHXsRaTgQuHsnph/ZTh9TYM nrgQoQ3uXMGe4J8OoHZmVD9cFxSuUbDe3J6UOGXRrqfy5jF3d55j9V7mCYbdGSAa15iB DYlbxTqr5RjrLYYdIZNv08DdB7/TkdJmsWwNHvHpYUt6QQSF2EMcZIKQWYqraLjk4odF ttU7NHeYI0ckDqJmgeIp/hCu/rdlVTgO+Rn6Hb0+D8veP9E3DE38EXZI6O8D981ikJIS BlzQ== X-Gm-Message-State: APjAAAVj8C1/5UTwScpn+4XoC5gTSQWa2sx3HWNz9Q7BbXd6KSlKqinK Bm8Lik0IxPNIAEZvlyVxPHozkQ== X-Google-Smtp-Source: APXvYqyeVmizdHwhgwHZgmr/e4kWY+FAahfl/COJf844taDtIr0xVpVkEX7mKGHw2WEC+CSOQQBDHg== X-Received: by 2002:a50:be03:: with SMTP id a3mr81819825edi.5.1560274755535; Tue, 11 Jun 2019 10:39:15 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id x98sm3013884ede.89.2019.06.11.10.39.14 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 11 Jun 2019 10:39:14 -0700 (PDT) Date: Tue, 11 Jun 2019 19:39:12 +0200 From: Daniel Vetter To: Sean Paul Subject: Re: [PATCH v5 06/11] drm/rockchip: Use dirtyfb helper Message-ID: <20190611173912.GL2458@phenom.ffwll.local> References: <20190611160844.257498-1-sean@poorly.run> <20190611160844.257498-7-sean@poorly.run> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190611160844.257498-7-sean@poorly.run> X-Operating-System: Linux phenom 4.14.0-3-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190611_103917_201021_904A5EE9 X-CRM114-Status: GOOD ( 17.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , David Airlie , Sandy Huang , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Sean Paul , Daniel Vetter , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 11, 2019 at 12:08:20PM -0400, Sean Paul wrote: > From: Sean Paul > > Instead of flushing all vops every time we get a dirtyfb call, use the > damage helper to kick off an atomic commit. Even though we don't use > damage clips, the helper commit will force us through the normal > psr_inhibit_get/put sequence. > > Changes in v3: > - Added to the set > Changes in v4: > - None > Changes in v5: > - None > > Link to v3: https://patchwork.freedesktop.org/patch/msgid/20190502194956.218441-7-sean@poorly.run > Link to v4: https://patchwork.freedesktop.org/patch/msgid/20190508160920.144739-7-sean@poorly.run > > Suggested-by: Daniel Vetter > Tested-by: Heiko Stuebner > Signed-off-by: Sean Paul Reviewed-by: Daniel Vetter btw somewhat bigger fish to fry, but imo also very much worth it: Switching over to the generic fbdev emulation. Also, since everything up to this one is reviewed I think would be good to land that part already. So I can go around and haggle this to other drivers :-) -Daniel > --- > drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c > index 31030cf81bc97..a888e31aa545a 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -25,20 +26,10 @@ > #include "rockchip_drm_gem.h" > #include "rockchip_drm_psr.h" > > -static int rockchip_drm_fb_dirty(struct drm_framebuffer *fb, > - struct drm_file *file, > - unsigned int flags, unsigned int color, > - struct drm_clip_rect *clips, > - unsigned int num_clips) > -{ > - rockchip_drm_psr_flush_all(fb->dev); > - return 0; > -} > - > static const struct drm_framebuffer_funcs rockchip_drm_fb_funcs = { > .destroy = drm_gem_fb_destroy, > .create_handle = drm_gem_fb_create_handle, > - .dirty = rockchip_drm_fb_dirty, > + .dirty = drm_atomic_helper_dirtyfb, > }; > > static struct drm_framebuffer * > -- > Sean Paul, Software Engineer, Google / Chromium OS > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel