Re: [PATCH v2 1/2] dt-bindings: i2c: sun6i-p2wi: Add YAML schemas

From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Linux I2C <linux-i2c@vger.kernel.org>,
	Frank Rowand <frowand.list@gmail.com>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: i2c: sun6i-p2wi: Add YAML schemas
Date: Wed, 12 Jun 2019 17:38:18 +0200	[thread overview]
Message-ID: <20190612153818.q5xj5su33krlignu@flea> (raw)
In-Reply-To: <CAL_JsqL3cua3u2gNTzHEdgFU0On5J9ziPZeFNiTpu5HS=SJoDA@mail.gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1639 bytes --]

Hi,

On Tue, Jun 11, 2019 at 08:50:37AM -0600, Rob Herring wrote:
> On Tue, Jun 11, 2019 at 3:06 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> >
> > Hi Rob,
> >
> > On Mon, Jun 10, 2019 at 03:34:18PM -0600, Rob Herring wrote:
> > > On Wed, Jun 5, 2019 at 6:29 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > > +properties:
> > > > +  "#address-cells":
> > > > +    const: 1
> > > > +
> > > > +  "#size-cells":
> > > > +    const: 0
> > >
> > > These 2 are covered by i2c-controller.yaml, right?
> >
> > Indeed, I've removed them.
> >
> > > > +examples:
> > > > +  - |
> > > > +    p2wi@1f03400 {
> > >
> > > i2c@...
> > >
> > > That should fail on the schema (I need to get the schema checking of
> > > examples finished.)
> >
> > That would be great :) The compilation of the examples alone already
> > caught a good number of examples that weren't even compiling.
>
> I'm primarily waiting on a dtc change to be accepted[1]. Feel free to
> review/ack.

I guess it's too late now :)

> > Speaking of examples, one thing that would be great too would be to
> > allow the usage of our C headers. It's not supported at the moment,
> > and this often ends up with an example that is less readable than the
> > actual DT.
>
> It should be. You just have to add them. See
> Documentation/devicetree/bindings/timer/intel,ixp4xx-timer.yaml for
> example.

Hmmm, I'm pretty sure I tried this before. I'll try again.

> Maybe the common interrupt and gpio ones should be added by default.

I guess so, yeah. The GIC too is pretty common

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel