From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=DATE_IN_PAST_12_24, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63AD1C31E45 for ; Thu, 13 Jun 2019 13:27:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A40C2064A for ; Thu, 13 Jun 2019 13:27:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="blvM4vrj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A40C2064A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JHKdaooYtfhSWoBl1HMRA0a3Z4diQKwv5QB5MupuEiE=; b=blvM4vrjcvzZAftHc2w8NGW5r u94+REot3TufrH85ukr9FmsuKs3dWGSPaVHu/5u4T3VYrIB9BTn1z7OkTFj7ztJaubQTtfaGJQb+I //7gBT25GlPxpHUIFU+GIi1hH/dPYOdsFTaPP3p/S2clJaY8gFKWW+sgeTINsYfTN8N/zvgw0RBz4 GVM4Adp0RN39URI6y2ShevPWSQQeVZvZsAoUfDFyANwJ0zm843DpgeYpBH2wUFhT8dhl3WemrTWt7 edO8VCAJGKKEdAp763favyFp1Ik+q7kmgl4msAgv/qp/bDZk+LCEnlDVPUyXS4884q46PtHMG7FDg wUZOIUlKw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hbPlC-0004Pa-48; Thu, 13 Jun 2019 13:27:22 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hbPk2-0003L0-81 for linux-arm-kernel@lists.infradead.org; Thu, 13 Jun 2019 13:26:12 +0000 X-Originating-IP: 90.88.159.246 Received: from localhost (aaubervilliers-681-1-40-246.w90-88.abo.wanadoo.fr [90.88.159.246]) (Authenticated sender: maxime.ripard@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 48DD74000A; Thu, 13 Jun 2019 13:26:04 +0000 (UTC) Date: Wed, 12 Jun 2019 17:43:25 +0200 From: Maxime Ripard To: Frank Lee Subject: Re: [PATCH v3 1/3] thermal: sun8i: add thermal driver for h6 Message-ID: <20190612154325.m6z7xsxlpdq4wkxv@flea> References: <20190525181329.18657-1-tiny.windzz@gmail.com> <20190525181329.18657-2-tiny.windzz@gmail.com> <20190527122752.uc7q6zkjti3zag4q@flea> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190613_062610_548489_A2DAEF27 X-CRM114-Status: GOOD ( 15.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Linux PM , Greg Kroah-Hartman , Linus Walleij , Daniel Lezcano , Linux Kernel Mailing List , Eduardo Valentin , Chen-Yu Tsai , robh+dt@kernel.org, Mauro Carvalho Chehab , rui.zhang@intel.com, paulmck@linux.ibm.com, David Miller , Linux ARM Content-Type: multipart/mixed; boundary="===============5789302248751940124==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5789302248751940124== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oy7r5ps7iphlasam" Content-Disposition: inline --oy7r5ps7iphlasam Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 07, 2019 at 09:34:44PM +0800, Frank Lee wrote: > On Mon, May 27, 2019 at 8:27 PM Maxime Ripard wrote: > > > + ret = devm_request_threaded_irq(dev, irq, NULL, > > > + tmdev->chip->irq_thread, > > > + IRQF_ONESHOT, "ths", tmdev); > > > + if (ret) > > > + return ret; > > > > Is there any particular reason to use a threaded interrupt? > > Just to improve real-time. What do you mean by real-time here? If anything, that will increase the latency of the interrupts here. And in preempt-rt, regular top-half interrupts will be forced into a threaded interrupt anyway. > > > +static int sun8i_ths_remove(struct platform_device *pdev) > > > +{ > > > + struct ths_device *tmdev = platform_get_drvdata(pdev); > > > + > > > + clk_disable_unprepare(tmdev->bus_clk); > > > > I know that we discussed that already, but I'm not sure why you switch > > back to a regular call to regmap_init_mmio, while regmap_init_mmio_clk > > will take care of enabling and disabling the bus clock for you? > > It seems that regmap_init_mmio_clk just get clk and prepare clk > but no enable. At init time, yes. But it will enable it only when you access the registers, which is what you want anyway. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --oy7r5ps7iphlasam Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXQEdnQAKCRDj7w1vZxhR xXCpAQCYtE67+V1lgKQJZxd7NFi0spq61ecHzscNxJ/t6H+OXQD/ZYw/N1ST4pg3 MGrcJRd4vnNOs5alaAicdNFepVsmQQQ= =g51D -----END PGP SIGNATURE----- --oy7r5ps7iphlasam-- --===============5789302248751940124== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5789302248751940124==--