From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=DATE_IN_PAST_12_24, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64B7FC31E45 for ; Thu, 13 Jun 2019 13:28:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3AB0D2064A for ; Thu, 13 Jun 2019 13:28:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dJw/ADP3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3AB0D2064A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1wUeXDZ4mTaTt2Wep0bI2dp8Q9U7H24WYRywOkvVg5g=; b=dJw/ADP3Wjv4fnv1GDNoK12Bj pGCCZdgDO6x+r0jND/zlEXeCDUPO3UVxu/iKmIinsFUpz04NKTPDPOaFwwDQGrF+yz0MvfT02T8Aq F3T445ikYTFc4/m6OEVDsUVvus4ovLGroSVPZfbj+BPsipAL3/22bGZWUIBxppEhijjNGTD8BtOrt giSySIm2cSJW+aueMO/Iht9wGdSh2/IUgVTNO08dD+XyApF1s9eWv9wqODJiWry/+allF5kj2d3KA 8f1evJpXon8YSBwiFzIpZ9X7zVZlxKXEE3GtYsGfDbjvkUNw9qF66U3rNe9EvaEqBO1qdunZ2MEX6 SkGhTb1LQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hbPmb-0005lH-8H; Thu, 13 Jun 2019 13:28:49 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hbPkJ-0003X2-5n for linux-arm-kernel@lists.infradead.org; Thu, 13 Jun 2019 13:26:30 +0000 Received: from localhost (aaubervilliers-681-1-40-246.w90-88.abo.wanadoo.fr [90.88.159.246]) (Authenticated sender: maxime.ripard@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 88D46240015; Thu, 13 Jun 2019 13:26:09 +0000 (UTC) Date: Wed, 12 Jun 2019 17:54:06 +0200 From: Maxime Ripard To: Noralf =?utf-8?Q?Tr=C3=B8nnes?= Subject: Re: [PATCH v3 3/6] drm/modes: Allow to specify rotation and reflection on the commandline Message-ID: <20190612155406.kjv6z7jk74bblfts@flea> References: <9ccb7573-d46e-4b90-7caa-7b8cd7b8e7a2@tronnes.org> <20190611124933.2g6l3d7nx6lqft6k@flea> <1d0d6259-54cb-9a26-003d-2a35b8a40f3f@tronnes.org> MIME-Version: 1.0 In-Reply-To: <1d0d6259-54cb-9a26-003d-2a35b8a40f3f@tronnes.org> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190613_062627_475612_F1FD832B X-CRM114-Status: GOOD ( 15.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: eben@raspberrypi.org, David Airlie , Maarten Lankhorst , dri-devel@lists.freedesktop.org, Paul Kocialkowski , Eric Anholt , Sean Paul , Thomas Petazzoni , Daniel Vetter , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============7099746419947884823==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7099746419947884823== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3wxmvvtbskp5zcmd" Content-Disposition: inline --3wxmvvtbskp5zcmd Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Wed, Jun 12, 2019 at 02:43:44PM +0200, Noralf Tr=F8nnes wrote: > Den 11.06.2019 14.49, skrev Maxime Ripard: > >>> + } else if (!strncmp(option, "reflect_x", delim - option)) { > >>> + rotation |=3D DRM_MODE_REFLECT_X; > >>> + sep =3D delim; > >>> + } else if (!strncmp(option, "reflect_y", delim - option)) { > >> > >> I think you should drop reflect_x and _y for now since they're not > >> supported. People like me that only reads code and not documentation > >> (ahem..) will get the impression that this should work. > > > > I'm not sure what you mean here, this is definitely supposed to > > work. Is there a limitation you're thinking of? > > > > It's this one in drm_client_panel_rotation() which limits rotation to > DRM_MODE_ROTATE_180: > > /* > * TODO: support 90 / 270 degree hardware rotation, > * depending on the hardware this may require the framebuffer > * to be in a specific tiling format. > */ > if (*rotation !=3D DRM_MODE_ROTATE_180 || !plane->rotation_property) > return false; Indeed, it doesn't work anymore since I rebased on your work. I'll fix this, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --3wxmvvtbskp5zcmd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXQEgHgAKCRDj7w1vZxhR xVtoAP4s4HFc5+Xz+AXPD/wlio4qU+eBrbfl4+JEmTmEajYFegD/ZE7kOWnv9p2h CSwUuDXLN0UExixZ6eKQuhZLzV4pdAg= =axG9 -----END PGP SIGNATURE----- --3wxmvvtbskp5zcmd-- --===============7099746419947884823== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7099746419947884823==--