From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 812DAC31E45 for ; Thu, 13 Jun 2019 16:35:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 427F720644 for ; Thu, 13 Jun 2019 16:35:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kyAxhFHY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EhGkyDzs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 427F720644 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=r/o7sXXkI1x70WuXh7/l+dCqgSeqYLyP3Ut5sHyEG6U=; b=kyAxhFHYHpds0YzI28xfARtE7 WbBj2pY3WGZGG8KOCRYGmgGQ/ObAopOUd4q2gBUTwuvEgY9HOlqbxE7EPol4wL3UxX5qffJvxI1jI o7s47YyYCUMelvpBlU8jxFmw9hST73QX9/9jPsfPUP6mK46rQ3ItndT98l/AWM2rdui0hSqNIpcoq OvEfqcTGDjqYWvraav6h5OFPBXWLL4qIe64sD1RnCM03NrYBunyEKjivPBViDzrJMBhuxqnggDBti PNniF+NsNJfRpr5Gvwk59+1/IOPSwHbkPUq+hN5IM5JJZOsdqGAq7DSTE+iW0WSXXzDSt6tIj6fVB ESqy+qROg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hbSgl-0001Fs-Tj; Thu, 13 Jun 2019 16:34:59 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hbSgi-0001EO-Oc for linux-arm-kernel@lists.infradead.org; Thu, 13 Jun 2019 16:34:58 +0000 Received: by mail-wm1-x343.google.com with SMTP id s15so10817754wmj.3 for ; Thu, 13 Jun 2019 09:34:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=HzzbYgkXL3nx7rZNrWYRPJ9FH3eafUuwvWKYEt4rTNY=; b=EhGkyDzsyQVM4Y/94UxftsVuA8EG6DZPJt0ubfaHzbDr7060e2AlkRN8Zc/vD4NDL4 Rm2I07fxy+hjZLoiXHVtvVsdQlDzDGew4048qmTDkC0KvtFywEOnqbG7yjSTHZz32gJ7 z6lz5r5uDFsMQpL/RwT6OHB1szHoIpbZC7ACtuFr+8I59Haa6hu4tRdqkRIaKL4ffoos VbIjS3s6oZzhB68MHlgMpEw5oO4ANjp5e2BqrWgUn0w9zGoYUnKTVB/l8sf6CQMHK9o8 unty7DjXCoDCbcPwqA8q2yBIKhYeKg7l49QAIp30nEzBU8XuiVXkfexqQRQ8Qq19Dbkj hhnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HzzbYgkXL3nx7rZNrWYRPJ9FH3eafUuwvWKYEt4rTNY=; b=iVeonsPD2jY858tinxPL2RSkFmVaY7Ze82aFc6MJkHTGzU8rEe/j+/9PGHV6fGJ2lk TE+73bpe14Wk6p0i8Cr7woRePISgLlw1SXcTsJ4FxnbsfYRRUBwwjuyL3yUl/RMNJxzb awzfJG3LSmt8K1EW+iQZ8x8ia9eSEyu6iYSHAdAz7sRQwBh2l8/qWn475+Ub0EiBgvr3 sbr8cbv7gvSg+7Spi77P9Ckdr2ToR9FKNv5CGYphbE/33jzjgvB68m/RSsIUbNsU+dt1 1uR3u4BTK4MINxbLFABZH06T9UNoaZLitqurDyD13ehPiGhbmVSDfcBl7pkpOfkefNk3 IAxA== X-Gm-Message-State: APjAAAVvVTIjx0TbFzCMBa87sXBiAU8o6zU/qVYXuLQotYJecls8fAju MVjkBg/bmvcHnlQZdIsFzeg= X-Google-Smtp-Source: APXvYqzOLxHsCwuM6OpMKUGm47fWsof6HuxDcJQf5F/i/8IP53t/xc7LYVZx3n1KnRMnhi0CbPro6g== X-Received: by 2002:a1c:e3c1:: with SMTP id a184mr4173350wmh.24.1560443694373; Thu, 13 Jun 2019 09:34:54 -0700 (PDT) Received: from localhost (p2E5BEF36.dip0.t-ipconnect.de. [46.91.239.54]) by smtp.gmail.com with ESMTPSA id u5sm470875wmc.32.2019.06.13.09.34.53 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 13 Jun 2019 09:34:53 -0700 (PDT) Date: Thu, 13 Jun 2019 18:34:52 +0200 From: Thierry Reding To: Stephen Warren Subject: Re: [PATCH 1/3] arm64: tegra: Add ethernet alias on Jetson TX1 Message-ID: <20190613163452.GA3258@ulmo> References: <20190613161517.2837-1-thierry.reding@gmail.com> <04a355c8-a4ae-9275-a85a-791ce5c1b34c@wwwdotorg.org> MIME-Version: 1.0 In-Reply-To: <04a355c8-a4ae-9275-a85a-791ce5c1b34c@wwwdotorg.org> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190613_093456_828477_2AB4EDAC X-CRM114-Status: GOOD ( 15.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , linux-arm-kernel@lists.infradead.org, Jon Hunter Content-Type: multipart/mixed; boundary="===============1113257302511658468==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1113257302511658468== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7AUc2qLy4jB3hD7Z" Content-Disposition: inline --7AUc2qLy4jB3hD7Z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 13, 2019 at 10:22:23AM -0600, Stephen Warren wrote: > On 6/13/19 10:15 AM, Thierry Reding wrote: > > From: Thierry Reding > >=20 > > Adding this alias for the Ethernet interface on Jetson TX1 allows the > > bootloader to pass the MAC address to the Linux kernel. >=20 > > diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi b/arch/arm6= 4/boot/dts/nvidia/tegra210-p2597.dtsi >=20 > > + aliases { > > + ethernet =3D "/usb@70090000/ethernet@1"; > > + }; >=20 > Don't aliases require an ID in the property name, i.e shouldn't this be > "ethernet0" rather than just "ethernet"? This is a bit more obvious in the > TX2 patch where sdhci0, sdhci1, and serial0 are shown in the diff context. I don't think there's a requirement for aliases to have an ID. The IDs, in the cases that I'm aware of, are used to fix the index given to the controllers in Linux (which is sometimes abused to get fixed numbering that can be hardcoded, rather than having a more robust way to look up the right hardware block). U-Boot has a comment somewhere about ethernet being equivalent to ethernet0 and it treats them the same way, if I remember correctly. As for upstream Linux, there does indeed seem to be a slight tendency towards ethernet0, though it's pretty well mixed. 32-bit ARM is mostly balanced, whereas 64-bit ARM uses ethernet0 almost exclusively. Maybe this means that recently there's been a push to standardize on always adding the index? > Patch should probably be CC'd to some/all of ARM/DT/... mailing lists? Oops... I meant to include those. Added now. Thierry --7AUc2qLy4jB3hD7Z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl0CeygACgkQ3SOs138+ s6FZGRAAie3WvvLA3MldS9O2cqq/CUfmWuGxbWSyjTIhIRx49f0S1nHj0WJdYOzA EP7RUHDgqUwJDqkFsNjyZNU7fatwgd784WjL2vXUKZFf5PX04507kzZQvtDvW6g/ ARzahv1N/zU6YvTtLWGC7jgKRa6e8IltBQPIUYEURFamv3i+N+05oLz1xI22Nj3s b/UAOncXztcR5tlE2Uusk+Avz+uHva6oNYB6WLyIlB+VZMdlUDruMA1n4uy/QZGH ejkZOt3KteED40l5jQDxocBtqcJmudxE1HHMUsQh8Gz3JUtXK/l+ofks6DXgJ3H6 1ht2S3FoYJUETcV4GU8g1a8oeyuRGQ2yax8rHTBCiVIwBrlvc0b82wXYVOftPFtD hCur2A/UqlNS3CYSOsE1GuazVNrFPMuqk9qCs1XU0rnw9QioTkUt305vuxCwFoH1 oVFXQGajdXMiTu4QfTtoolCWAugCQLT2W3YFW1qKJ20egvCkvvTQFvz0MX4Q3wGP m1KD2eo+xCyWFetwLCZzl6yjaDOlzhqctWmVEhxZjV0Vl/C04KklxrD46gohgqzj fY6TDnjFHVM64MVy8c55OA3PniCv1aQ1brf54eUdlTWp4MS6R3+4zYBP+X5MF3Vb LQq624SnGItBbllLT+aoKhq0b8uUYszPiYImjX4VmsMqr+O6Q84= =LHm4 -----END PGP SIGNATURE----- --7AUc2qLy4jB3hD7Z-- --===============1113257302511658468== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1113257302511658468==--